{"id":20553,"url":"https://patchwork.libcamera.org/api/patches/20553/?format=json","web_url":"https://patchwork.libcamera.org/patch/20553/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240703175119.1872585-12-mzamazal@redhat.com>","date":"2024-07-03T17:51:11","name":"[v2,11/19] libcamera: software_isp: Call Algorithm::queueRequest","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8959351160f519dc13303c24dcf3424bf38d2a1c","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20553/mbox/","series":[{"id":4440,"url":"https://patchwork.libcamera.org/api/series/4440/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4440","date":"2024-07-03T17:51:00","name":"Software ISP refactoring","version":2,"mbox":"https://patchwork.libcamera.org/series/4440/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20553/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20553/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83860BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 17:52:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1384E6335E;\n\tWed, 3 Jul 2024 19:52:07 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A56363362\n\tfor ;\n\tWed, 3 Jul 2024 19:51:55 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-263-RSPV5GbAPcK8rz_VcRjW2w-1;\n\tWed, 03 Jul 2024 13:51:50 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2D36419560B1; Wed, 3 Jul 2024 17:51:48 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.13])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 7289A1954B0D; Wed, 3 Jul 2024 17:51:46 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ERPzFpFr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1720029113;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=2luqaJnYGTPMgjSgzM9RHdLsJ8Yl8itRFEar3wtfCj4=;\n\tb=ERPzFpFraptRZcMmjZaDgPoAkFFYRilSFhXSfcFJitgUyeMjKMFKOOnSi/kDdWIUMnhKlK\n\t4JyUQy1EbwLlkpu36DEwItv7xIk0QeeNt5HnB3rAJpJPa50mPrUw6y8jJ00Md7aTMPZxz2\n\tUM/G9HdmanZg7trD1B0vP99mIeDgmvE=","X-MC-Unique":"RSPV5GbAPcK8rz_VcRjW2w-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ","Subject":"[PATCH v2 11/19] libcamera: software_isp: Call\n\tAlgorithm::queueRequest","Date":"Wed, 3 Jul 2024 19:51:11 +0200","Message-ID":"<20240703175119.1872585-12-mzamazal@redhat.com>","In-Reply-To":"<20240703175119.1872585-1-mzamazal@redhat.com>","References":"<20240703175119.1872585-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch adds Algorithm::queueRequest call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nSigned-off-by: Milan Zamazal \n---\n include/libcamera/internal/software_isp/software_isp.h | 1 +\n include/libcamera/ipa/soft.mojom | 1 +\n src/ipa/simple/soft_simple.cpp | 9 +++++++++\n src/libcamera/pipeline/simple/simple.cpp | 2 ++\n src/libcamera/software_isp/software_isp.cpp | 10 ++++++++++\n 5 files changed, 23 insertions(+)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex ff26b1d4..1ba9eb62 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -72,6 +72,7 @@ public:\n \tint start();\n \tvoid stop();\n \n+\tvoid queueRequest(const uint32_t frame, const ControlList &controls);\n \tint queueBuffers(uint32_t frame, FrameBuffer *input,\n \t\t\t const std::map &outputs);\n \ndiff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 5e124016..426fee18 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -23,6 +23,7 @@ interface IPASoftInterface {\n \tconfigure(IPAConfigInfo configInfo)\n \t\t=> (int32 ret);\n \n+\tqueueRequest(uint32 frame, libcamera.ControlList sensorControls);\n \t[async] processStats(uint32 frame, uint32 bufferId, libcamera.ControlList sensorControls);\n };\n \ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 49fff312..bd0dea5f 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -77,6 +77,7 @@ public:\n \tint start() override;\n \tvoid stop() override;\n \n+\tvoid queueRequest(const uint32_t frame, const ControlList &controls) override;\n \tvoid processStats(const uint32_t frame, const uint32_t bufferId,\n \t\t\t const ControlList &sensorControls) override;\n \n@@ -269,6 +270,14 @@ void IPASoftSimple::stop()\n {\n }\n \n+void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &controls)\n+{\n+\tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n+\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->queueRequest(context_, frame, frameContext, controls);\n+}\n+\n void IPASoftSimple::processStats(\n \t[[maybe_unused]] const uint32_t frame,\n \t[[maybe_unused]] const uint32_t bufferId,\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex e0c9fe5c..6fb80209 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1430,6 +1430,8 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \tif (data->useConversion_)\n \t\tdata->conversionQueue_.push(std::move(buffers));\n \n+\tdata->swIsp_->queueRequest(request->sequence(), request->controls());\n+\n \treturn 0;\n }\n \ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 2bbb86da..4e6b3a2e 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -279,6 +279,16 @@ int SoftwareIsp::exportBuffers(unsigned int output, unsigned int count,\n \treturn count;\n }\n \n+/**\n+ * \\brief Queue a request and process the control list from the application\n+ * \\param[in] frame The number of the frame which will be processed next\n+ * \\param[in] controls The controls for the \\a frame\n+ */\n+void SoftwareIsp::queueRequest(const uint32_t frame, const ControlList &controls)\n+{\n+\tipa_->queueRequest(frame, controls);\n+}\n+\n /**\n * \\brief Queue buffers to Software ISP\n * \\param[in] frame The frame number\n","prefixes":["v2","11/19"]}