[{"id":30395,"web_url":"https://patchwork.libcamera.org/comment/30395/","msgid":"","date":"2024-07-13T07:01:50","subject":"Re: [PATCH v2 07/19] libcamera: software_isp: Remove final dots in\n\tdebayer.cpp docstrings","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan\n\nThank you for the patch\n\nOn 03/07/24 11:21 pm, Milan Zamazal wrote:\n> As required by the policy and the style checker.\n\nIf the style checker is happy, then I'm happy :-)\n\nReviewed-by: Umang Jain \n\n>\n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/software_isp/debayer.cpp | 48 +++++++++++++-------------\n> 1 file changed, 24 insertions(+), 24 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index f4a299d5..4d101798 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -58,47 +58,47 @@ Debayer::~Debayer()\n> \n> /**\n> * \\fn int Debayer::configure(const StreamConfiguration &inputCfg, const std::vector> &outputCfgs)\n> - * \\brief Configure the debayer object according to the passed in parameters.\n> - * \\param[in] inputCfg The input configuration.\n> - * \\param[in] outputCfgs The output configurations.\n> + * \\brief Configure the debayer object according to the passed in parameters\n> + * \\param[in] inputCfg The input configuration\n> + * \\param[in] outputCfgs The output configurations\n> *\n> - * \\return 0 on success, a negative errno on failure.\n> + * \\return 0 on success, a negative errno on failure\n> */\n> \n> /**\n> * \\fn Size Debayer::patternSize(PixelFormat inputFormat)\n> - * \\brief Get the width and height at which the bayer pattern repeats.\n> - * \\param[in] inputFormat The input format.\n> + * \\brief Get the width and height at which the bayer pattern repeats\n> + * \\param[in] inputFormat The input format\n> *\n> * Valid sizes are: 2x2, 4x2 or 4x4.\n> *\n> - * \\return Pattern size or an empty size for unsupported inputFormats.\n> + * \\return Pattern size or an empty size for unsupported inputFormats\n> */\n> \n> /**\n> * \\fn std::vector Debayer::formats(PixelFormat inputFormat)\n> - * \\brief Get the supported output formats.\n> - * \\param[in] inputFormat The input format.\n> + * \\brief Get the supported output formats\n> + * \\param[in] inputFormat The input format\n> *\n> - * \\return All supported output formats or an empty vector if there are none.\n> + * \\return All supported output formats or an empty vector if there are none\n> */\n> \n> /**\n> * \\fn std::tuple Debayer::strideAndFrameSize(const PixelFormat &outputFormat, const Size &size)\n> - * \\brief Get the stride and the frame size.\n> - * \\param[in] outputFormat The output format.\n> - * \\param[in] size The output size.\n> + * \\brief Get the stride and the frame size\n> + * \\param[in] outputFormat The output format\n> + * \\param[in] size The output size\n> *\n> * \\return A tuple of the stride and the frame size, or a tuple with 0,0 if\n> - * there is no valid output config.\n> + * there is no valid output config\n> */\n> \n> /**\n> * \\fn void Debayer::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n> - * \\brief Process the bayer data into the requested format.\n> - * \\param[in] input The input buffer.\n> - * \\param[in] output The output buffer.\n> - * \\param[in] params The parameters to be used in debayering.\n> + * \\brief Process the bayer data into the requested format\n> + * \\param[in] input The input buffer\n> + * \\param[in] output The output buffer\n> + * \\param[in] params The parameters to be used in debayering\n> *\n> * \\note DebayerParams is passed by value deliberately so that a copy is passed\n> * when this is run in another thread by invokeMethod().\n> @@ -106,21 +106,21 @@ Debayer::~Debayer()\n> \n> /**\n> * \\fn virtual SizeRange Debayer::sizes(PixelFormat inputFormat, const Size &inputSize)\n> - * \\brief Get the supported output sizes for the given input format and size.\n> - * \\param[in] inputFormat The input format.\n> - * \\param[in] inputSize The input size.\n> + * \\brief Get the supported output sizes for the given input format and size\n> + * \\param[in] inputFormat The input format\n> + * \\param[in] inputSize The input size\n> *\n> - * \\return The valid size ranges or an empty range if there are none.\n> + * \\return The valid size ranges or an empty range if there are none\n> */\n> \n> /**\n> * \\var Signal Debayer::inputBufferReady\n> - * \\brief Signals when the input buffer is ready.\n> + * \\brief Signals when the input buffer is ready\n> */\n> \n> /**\n> * \\var Signal Debayer::outputBufferReady\n> - * \\brief Signals when the output buffer is ready.\n> + * \\brief Signals when the output buffer is ready\n> */\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94BADBD87C\n\tfor ;\n\tSat, 13 Jul 2024 07:01:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ADA8D6336F;\n\tSat, 13 Jul 2024 09:01:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53D7762C99\n\tfor ;\n\tSat, 13 Jul 2024 09:01:55 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB059D01;\n\tSat, 13 Jul 2024 09:01:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lqNlsXYV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720854080;\n\tbh=UFXx407Y0gwOnMWQ2eD6wqVRqbXMA44Xl2bjhkwK6ak=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=lqNlsXYV/itEQjlJ/R9du9mf9CCeNQfxHxxQ90h7N16oOxIOymbIh4nClODgWX3tF\n\te5+WvbmobufEnSGysLBVSulc0kVxNPgwA2gItdSW0sHLixKkjJwqURNpzwrOhPn2Es\n\t8Bu0VBvNIDma8ub0J80KEbaJDqlciW0JVxrGuJzc=","Message-ID":"","Date":"Sat, 13 Jul 2024 12:31:50 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 07/19] libcamera: software_isp: Remove final dots in\n\tdebayer.cpp docstrings","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240703175119.1872585-1-mzamazal@redhat.com>\n\t<20240703175119.1872585-8-mzamazal@redhat.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240703175119.1872585-8-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]