[{"id":30394,"web_url":"https://patchwork.libcamera.org/comment/30394/","msgid":"","date":"2024-07-13T06:35:26","subject":"Re: [PATCH v2 05/19] libcamera: software_isp: Let IPASoftSimple\n\tinherit Module","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan\n\nThank you for the patch\n\nOn 03/07/24 11:21 pm, Milan Zamazal wrote:\n> The Module class is a base class for all IPA modules.\n> In addition, implement logPrefix() of the module for the softIPA.\n>\n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Umang Jain \n> ---\n> src/ipa/simple/soft_simple.cpp | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index 3cc873a2..b41b24c6 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -29,6 +29,7 @@\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> #include \"black_level.h\"\n> +#include \"module.h\"\n> \n> namespace libcamera {\n> LOG_DEFINE_CATEGORY(IPASoft)\n> @@ -53,7 +54,7 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n> */\n> static constexpr float kExposureSatisfactory = 0.2;\n> \n> -class IPASoftSimple : public ipa::soft::IPASoftInterface\n> +class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n> {\n> public:\n> \tIPASoftSimple()\n> @@ -75,6 +76,9 @@ public:\n> \n> \tvoid processStats(const ControlList &sensorControls) override;\n> \n> +protected:\n> +\tstd::string logPrefix() const override;\n> +\n> private:\n> \tvoid updateExposure(double exposureMSV);\n> \n> @@ -420,6 +424,11 @@ void IPASoftSimple::updateExposure(double exposureMSV)\n> \tagain_ = std::clamp(again_, againMin_, againMax_);\n> }\n> \n> +std::string IPASoftSimple::logPrefix() const\n> +{\n> +\treturn \"IPASoft\";\n> +}\n> +\n> } /* namespace ipa::soft */\n> \n> /*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC125BDB1C\n\tfor ;\n\tSat, 13 Jul 2024 06:35:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C09B6336F;\n\tSat, 13 Jul 2024 08:35:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06EC7619A7\n\tfor ;\n\tSat, 13 Jul 2024 08:35:31 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91BC8CDB;\n\tSat, 13 Jul 2024 08:34:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g234FC50\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720852496;\n\tbh=7LnRh7ZI9nCHm6OsHf+Jn4/t19KjKKmJQCZOHx0ZBGQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=g234FC509o6658VvEbcG9387BbBKReD585BckojYmY1ywVd/mlDnFYC1aZ+CY4pwN\n\tx7MLDmYz5MRMWx8YBYHNZ90I9a0YliQQEBn6crCv8fw8Tp5hvR8bO4i5XoaM5RVfIW\n\tFkhX1PEOVuSbkUMEwSdKPhZgsBYa12BxcUthiJ1o=","Message-ID":"","Date":"Sat, 13 Jul 2024 12:05:26 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 05/19] libcamera: software_isp: Let IPASoftSimple\n\tinherit Module","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240703175119.1872585-1-mzamazal@redhat.com>\n\t<20240703175119.1872585-6-mzamazal@redhat.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240703175119.1872585-6-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]