[{"id":30393,"web_url":"https://patchwork.libcamera.org/comment/30393/","msgid":"","date":"2024-07-13T06:34:31","subject":"Re: [PATCH v2 04/19] libcamera: software_isp: Define skeletons for\n\tIPA refactoring","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan\n\nThank you for the patch.\n\nOn 03/07/24 11:21 pm, Milan Zamazal wrote:\n> Software ISP image processing algorithms are currently defined in a\n> simplified way, different from other libcamera pipelines. This is not\n> good for several reasons:\n>\n> - It makes the software ISP code harder to understand due to its\n> different structuring.\n> - Adding more algorithms may make the code harder to understand\n> generally.\n> - Mass libcamera code changes may not be easily applicable to software\n> ISP.\n> - Algorithm sharing with other pipelines is not easily possible.\n>\n> This patch introduces basic software ISP IPA skeletons structured\n> similarly to the other pipelines. The newly added files are currently\n> not used or compiled and the general skeleton structures don't contain\n> anything particular. It is just a preparation step for a larger\n> refactoring and the code will be actually used and extended as needed in\n> followup patches.\n>\n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/algorithms/algorithm.h | 22 +++++++++++\n> src/ipa/simple/ipa_context.cpp | 53 +++++++++++++++++++++++++++\n> src/ipa/simple/ipa_context.h | 34 +++++++++++++++++\n> src/ipa/simple/meson.build | 1 +\n> src/ipa/simple/module.h | 28 ++++++++++++++\n> 5 files changed, 138 insertions(+)\n> create mode 100644 src/ipa/simple/algorithms/algorithm.h\n> create mode 100644 src/ipa/simple/ipa_context.cpp\n> create mode 100644 src/ipa/simple/ipa_context.h\n> create mode 100644 src/ipa/simple/module.h\n>\n> diff --git a/src/ipa/simple/algorithms/algorithm.h b/src/ipa/simple/algorithms/algorithm.h\n> new file mode 100644\n> index 00000000..41f63170\n> --- /dev/null\n> +++ b/src/ipa/simple/algorithms/algorithm.h\n> @@ -0,0 +1,22 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Red Hat, Inc.\n> + *\n> + * Software ISP control algorithm interface\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \"module.h\"\n> +\n> +namespace libcamera {\n> +\n> +namespace ipa::soft {\n> +\n> +using Algorithm = libcamera::ipa::Algorithm;\n> +\n> +} /* namespace ipa::soft */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/simple/ipa_context.cpp b/src/ipa/simple/ipa_context.cpp\n> new file mode 100644\n> index 00000000..0898e591\n> --- /dev/null\n> +++ b/src/ipa/simple/ipa_context.cpp\n> @@ -0,0 +1,53 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Google Inc.\n> + * Copyright (C) 2024 Red Hat Inc.\n> + *\n> + * Software ISP IPA Context\n> + */\n> +\n> +#include \"ipa_context.h\"\n> +\n> +/**\n> + * \\file ipa_context.h\n> + * \\brief Context and state information shared between the algorithms\n> + */\n> +\n> +namespace libcamera::ipa::soft {\n> +\n> +/**\n> + * \\struct IPASessionConfiguration\n> + * \\brief Session configuration for the IPA module\n> + *\n> + * The session configuration contains all IPA configuration parameters that\n> + * remain constant during the capture session, from IPA module start to stop.\n> + * It is typically set during the configure() operation of the IPA module, but\n> + * may also be updated in the start() operation.\n> + */\n> +\n> +/**\n> + * \\struct IPAActiveState\n> + * \\brief The active state of the IPA algorithms\n> + *\n> + * The IPA is fed with the statistics generated from the latest frame captured\n> + * by the hardware. The statistics are then processed by the IPA algorithms to\n\nI am not very sure here, but this line above reguarding the stats being \ngenerated by hardware needs to be defined in soft-IPA context.\nDo you have any thoughts on that ?\n\nOther than that, LGTM:\n\nReviewed-by: Umang Jain \n> + * compute ISP parameters required for the next frame capture. The current state\n> + * of the algorithms is reflected through the IPAActiveState to store the values\n> + * most recently computed by the IPA algorithms.\n> + */\n> +\n> +/**\n> + * \\struct IPAContext\n> + * \\brief Global IPA context data shared between all algorithms\n> + *\n> + * \\var IPAContext::configuration\n> + * \\brief The IPA session configuration, immutable during the session\n> + *\n> + * \\var IPAContext::frameContexts\n> + * \\brief Ring buffer of the IPAFrameContext(s)\n> + *\n> + * \\var IPAContext::activeState\n> + * \\brief The current state of IPA algorithms\n> + */\n> +\n> +} /* namespace libcamera::ipa::soft */\n> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n> new file mode 100644\n> index 00000000..bc1235b6\n> --- /dev/null\n> +++ b/src/ipa/simple/ipa_context.h\n> @@ -0,0 +1,34 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Red Hat, Inc.\n> + *\n> + * Simple pipeline IPA Context\n> + *\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +\n> +namespace libcamera {\n> +\n> +namespace ipa::soft {\n> +\n> +struct IPASessionConfiguration {\n> +};\n> +\n> +struct IPAActiveState {\n> +};\n> +\n> +struct IPAFrameContext : public FrameContext {\n> +};\n> +\n> +struct IPAContext {\n> +\tIPASessionConfiguration configuration;\n> +\tIPAActiveState activeState;\n> +\tFCQueue frameContexts;\n> +};\n> +\n> +} /* namespace ipa::soft */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n> index 33d1c96a..363251fb 100644\n> --- a/src/ipa/simple/meson.build\n> +++ b/src/ipa/simple/meson.build\n> @@ -3,6 +3,7 @@\n> ipa_name = 'ipa_soft_simple'\n> \n> soft_simple_sources = files([\n> + 'ipa_context.cpp',\n> 'soft_simple.cpp',\n> 'black_level.cpp',\n> ])\n> diff --git a/src/ipa/simple/module.h b/src/ipa/simple/module.h\n> new file mode 100644\n> index 00000000..33a7d1db\n> --- /dev/null\n> +++ b/src/ipa/simple/module.h\n> @@ -0,0 +1,28 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2024 Red Hat, Inc.\n> + *\n> + * Software ISP IPA Module\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \"libcamera/internal/software_isp/debayer_params.h\"\n> +#include \"libcamera/internal/software_isp/swisp_stats.h\"\n> +\n> +#include \n> +\n> +#include \"ipa_context.h\"\n> +\n> +namespace libcamera {\n> +\n> +namespace ipa::soft {\n> +\n> +using Module = ipa::Module +\t\t\t DebayerParams, SwIspStats>;\n> +\n> +} /* namespace ipa::soft */\n> +\n> +} /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F58BBD87C\n\tfor ;\n\tSat, 13 Jul 2024 06:34:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9A916336F;\n\tSat, 13 Jul 2024 08:34:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C658A619A7\n\tfor ;\n\tSat, 13 Jul 2024 08:34:36 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11CA8CDB;\n\tSat, 13 Jul 2024 08:34:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fGeeQaNj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720852441;\n\tbh=0H4MGtYHsNTcHNXjsjkaOjRNaBoG38gSc7Un/yuwyhU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=fGeeQaNjE3E21vlRhZax0ge3TOi3zMQ3mazNJieGLN+B4WUav4+iL8CuQlPo/sBcp\n\tPqF8QK1Mdv2P2mxqTo55RXp0EWX2a1cCp9Go+Sl7ilz9KbTP9bK2n9UO9Hn5NG40xa\n\tZU6AFPU5Si/WAIHrkZL5Dv6cUoz5A2jKg4pJo6W8=","Message-ID":"","Date":"Sat, 13 Jul 2024 12:04:31 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 04/19] libcamera: software_isp: Define skeletons for\n\tIPA refactoring","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240703175119.1872585-1-mzamazal@redhat.com>\n\t<20240703175119.1872585-5-mzamazal@redhat.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240703175119.1872585-5-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30398,"web_url":"https://patchwork.libcamera.org/comment/30398/","msgid":"<87bk31uw68.fsf@redhat.com>","date":"2024-07-13T15:51:59","subject":"Re: [PATCH v2 04/19] libcamera: software_isp: Define skeletons for\n\tIPA refactoring","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Umang,\n\nthank you for review.\n\nUmang Jain writes:\n\n> Hi Milan\n>\n> Thank you for the patch.\n>\n> On 03/07/24 11:21 pm, Milan Zamazal wrote:\n>> Software ISP image processing algorithms are currently defined in a\n>> simplified way, different from other libcamera pipelines. This is not\n>> good for several reasons:\n>>\n>> - It makes the software ISP code harder to understand due to its\n>> different structuring.\n>> - Adding more algorithms may make the code harder to understand\n>> generally.\n>> - Mass libcamera code changes may not be easily applicable to software\n>> ISP.\n>> - Algorithm sharing with other pipelines is not easily possible.\n>>\n>> This patch introduces basic software ISP IPA skeletons structured\n>> similarly to the other pipelines. The newly added files are currently\n>> not used or compiled and the general skeleton structures don't contain\n>> anything particular. It is just a preparation step for a larger\n>> refactoring and the code will be actually used and extended as needed in\n>> followup patches.\n>>\n>> Signed-off-by: Milan Zamazal \n>> ---\n>> src/ipa/simple/algorithms/algorithm.h | 22 +++++++++++\n>> src/ipa/simple/ipa_context.cpp | 53 +++++++++++++++++++++++++++\n>> src/ipa/simple/ipa_context.h | 34 +++++++++++++++++\n>> src/ipa/simple/meson.build | 1 +\n>> src/ipa/simple/module.h | 28 ++++++++++++++\n>> 5 files changed, 138 insertions(+)\n>> create mode 100644 src/ipa/simple/algorithms/algorithm.h\n>> create mode 100644 src/ipa/simple/ipa_context.cpp\n>> create mode 100644 src/ipa/simple/ipa_context.h\n>> create mode 100644 src/ipa/simple/module.h\n>>\n>> diff --git a/src/ipa/simple/algorithms/algorithm.h b/src/ipa/simple/algorithms/algorithm.h\n>> new file mode 100644\n>> index 00000000..41f63170\n>> --- /dev/null\n>> +++ b/src/ipa/simple/algorithms/algorithm.h\n>> @@ -0,0 +1,22 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2024 Red Hat, Inc.\n>> + *\n>> + * Software ISP control algorithm interface\n>> + */\n>> +\n>> +#pragma once\n>> +\n>> +#include \n>> +\n>> +#include \"module.h\"\n>> +\n>> +namespace libcamera {\n>> +\n>> +namespace ipa::soft {\n>> +\n>> +using Algorithm = libcamera::ipa::Algorithm;\n>> +\n>> +} /* namespace ipa::soft */\n>> +\n>> +} /* namespace libcamera */\n>> diff --git a/src/ipa/simple/ipa_context.cpp b/src/ipa/simple/ipa_context.cpp\n>> new file mode 100644\n>> index 00000000..0898e591\n>> --- /dev/null\n>> +++ b/src/ipa/simple/ipa_context.cpp\n>> @@ -0,0 +1,53 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2021, Google Inc.\n>> + * Copyright (C) 2024 Red Hat Inc.\n>> + *\n>> + * Software ISP IPA Context\n>> + */\n>> +\n>> +#include \"ipa_context.h\"\n>> +\n>> +/**\n>> + * \\file ipa_context.h\n>> + * \\brief Context and state information shared between the algorithms\n>> + */\n>> +\n>> +namespace libcamera::ipa::soft {\n>> +\n>> +/**\n>> + * \\struct IPASessionConfiguration\n>> + * \\brief Session configuration for the IPA module\n>> + *\n>> + * The session configuration contains all IPA configuration parameters that\n>> + * remain constant during the capture session, from IPA module start to stop.\n>> + * It is typically set during the configure() operation of the IPA module, but\n>> + * may also be updated in the start() operation.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAActiveState\n>> + * \\brief The active state of the IPA algorithms\n>> + *\n>> + * The IPA is fed with the statistics generated from the latest frame captured\n>> + * by the hardware. The statistics are then processed by the IPA algorithms to\n>\n> I am not very sure here, but this line above reguarding the stats being\n> generated by hardware needs to be defined in soft-IPA context.\n> Do you have any thoughts on that ?\n\nThis copy of a text from the hardware pipelines is confusing, I'll\nadjust the paragraph.\n\n> Other than that, LGTM:\n>\n> Reviewed-by: Umang Jain \n>> + * compute ISP parameters required for the next frame capture. The current state\n>> + * of the algorithms is reflected through the IPAActiveState to store the values\n>> + * most recently computed by the IPA algorithms.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAContext\n>> + * \\brief Global IPA context data shared between all algorithms\n>> + *\n>> + * \\var IPAContext::configuration\n>> + * \\brief The IPA session configuration, immutable during the session\n>> + *\n>> + * \\var IPAContext::frameContexts\n>> + * \\brief Ring buffer of the IPAFrameContext(s)\n>> + *\n>> + * \\var IPAContext::activeState\n>> + * \\brief The current state of IPA algorithms\n>> + */\n>> +\n>> +} /* namespace libcamera::ipa::soft */\n>> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n>> new file mode 100644\n>> index 00000000..bc1235b6\n>> --- /dev/null\n>> +++ b/src/ipa/simple/ipa_context.h\n>> @@ -0,0 +1,34 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2024 Red Hat, Inc.\n>> + *\n>> + * Simple pipeline IPA Context\n>> + *\n>> + */\n>> +\n>> +#pragma once\n>> +\n>> +#include \n>> +\n>> +namespace libcamera {\n>> +\n>> +namespace ipa::soft {\n>> +\n>> +struct IPASessionConfiguration {\n>> +};\n>> +\n>> +struct IPAActiveState {\n>> +};\n>> +\n>> +struct IPAFrameContext : public FrameContext {\n>> +};\n>> +\n>> +struct IPAContext {\n>> +\tIPASessionConfiguration configuration;\n>> +\tIPAActiveState activeState;\n>> +\tFCQueue frameContexts;\n>> +};\n>> +\n>> +} /* namespace ipa::soft */\n>> +\n>> +} /* namespace libcamera */\n>> diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n>> index 33d1c96a..363251fb 100644\n>> --- a/src/ipa/simple/meson.build\n>> +++ b/src/ipa/simple/meson.build\n>> @@ -3,6 +3,7 @@\n>> ipa_name = 'ipa_soft_simple'\n>> soft_simple_sources = files([\n>> + 'ipa_context.cpp',\n>> 'soft_simple.cpp',\n>> 'black_level.cpp',\n>> ])\n>> diff --git a/src/ipa/simple/module.h b/src/ipa/simple/module.h\n>> new file mode 100644\n>> index 00000000..33a7d1db\n>> --- /dev/null\n>> +++ b/src/ipa/simple/module.h\n>> @@ -0,0 +1,28 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2024 Red Hat, Inc.\n>> + *\n>> + * Software ISP IPA Module\n>> + */\n>> +\n>> +#pragma once\n>> +\n>> +#include \n>> +\n>> +#include \"libcamera/internal/software_isp/debayer_params.h\"\n>> +#include \"libcamera/internal/software_isp/swisp_stats.h\"\n>> +\n>> +#include \n>> +\n>> +#include \"ipa_context.h\"\n>> +\n>> +namespace libcamera {\n>> +\n>> +namespace ipa::soft {\n>> +\n>> +using Module = ipa::Module> +\t\t\t DebayerParams, SwIspStats>;\n>> +\n>> +} /* namespace ipa::soft */\n>> +\n>> +} /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 196ACBDB1C\n\tfor ;\n\tSat, 13 Jul 2024 15:52:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 184406336F;\n\tSat, 13 Jul 2024 17:52:13 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 226C363365\n\tfor ;\n\tSat, 13 Jul 2024 17:52:11 +0200 (CEST)","from mail-oi1-f199.google.com (mail-oi1-f199.google.com\n\t[209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-385-fZVP8Wq2OUKsoXTSgOC9qw-1; Sat, 13 Jul 2024 11:52:06 -0400","by mail-oi1-f199.google.com with SMTP id\n\t5614622812f47-3d94284e5e9so2803883b6e.1\n\tfor ;\n\tSat, 13 Jul 2024 08:52:05 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5614622812f47-3dab3e0fb31sm217278b6e.35.2024.07.13.08.52.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 13 Jul 2024 08:52:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"abR9WF42\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1720885929;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=yffrsRPEucpltgyi5bvO4/Y81dW0IQy7farz9Qk6N/4=;\n\tb=abR9WF42eMiHype0fonq5waQPn2PmGx22hLDEkmAXMqMKpA5zl7TXMD3ahEATWT++d0Raj\n\t8IOrz7AZy0e8hZCeDG5qwaziK0UqG8Lm2ltGmRqtmF0r/UwOyEOuCTDqdTstnarHRMIYhn\n\tJeKezfk2Q5UqabGNJp5Af8P43tJYAMo=","X-MC-Unique":"fZVP8Wq2OUKsoXTSgOC9qw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1720885924; x=1721490724;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=yffrsRPEucpltgyi5bvO4/Y81dW0IQy7farz9Qk6N/4=;\n\tb=nxye0R5/H8z8Ei03dLwDlXRqFw2JgClk0zkKH5ublxICalae6vCgEuKt+7tEaDUNnv\n\tjvIbPDzzlHZb75G7FQLSSySHtJe9/3zY4SuMOazH6xkwPqSh7lnDcDyQ6E+Zk4nltnuW\n\t0IZgkEy0IYGL9Z89gvmh6NRs9I7sQXdRVL5Tu9rAmXymGfSc0G5F6WyC+h52tSUcq45R\n\tgu2aWBYBfYZHIJRzxJQPkch8jF6vjK3PAk6LdQbaluYdv6+vVI3uEaO1dzSiYY3eNX7/\n\tJ7k88vqcSCd7YZBqBmOB4kIQljEtz2ntmWqZomVE7NPjgRPrzqQZfEdu6tZzs597YclP\n\tDi1A==","X-Gm-Message-State":"AOJu0Yy5xkaFDJOurGJCa9KYssOi3eza51AzXRBIZX1tJUwMp4Jf2qer\n\tHnZZ8wNkXuRG8CVnYVpU/JLYMQ2eSF4PWupGT4xjOI2ipdJxkcIO1sIfYA+D7xomCZG9/l5x4BY\n\tPF8MJuIoI5w6m2QksI6FGTpGc8zGd+9uoSFebJqW2wVhZX5uli+IqSz6Whh1Q1qvwLtvz3B6zUR\n\tWfHMxJP07LcjMGAuArm7N/QX3uNnsfQbb4RLgE1YKEgZDmVd4MJu1/tnA=","X-Received":["by 2002:a05:6808:2884:b0:3d9:dcbc:6b95 with SMTP id\n\t5614622812f47-3d9dcbc7354mr10532423b6e.31.1720885924079; \n\tSat, 13 Jul 2024 08:52:04 -0700 (PDT)","by 2002:a05:6808:2884:b0:3d9:dcbc:6b95 with SMTP id\n\t5614622812f47-3d9dcbc7354mr10532398b6e.31.1720885923393; \n\tSat, 13 Jul 2024 08:52:03 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEqAx9SwCzUmVrvySn8walVQ0I5jqo3WDxQ+Z2Br/JTnqj8QKPxat4nNd4qTnMU2x1N9gJJjw==","From":"Milan Zamazal ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 04/19] libcamera: software_isp: Define skeletons for\n\tIPA refactoring","In-Reply-To":" (Umang\n\tJain's message of \"Sat, 13 Jul 2024 12:04:31 +0530\")","References":"<20240703175119.1872585-1-mzamazal@redhat.com>\n\t<20240703175119.1872585-5-mzamazal@redhat.com>\n\t","Date":"Sat, 13 Jul 2024 17:51:59 +0200","Message-ID":"<87bk31uw68.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]