[{"id":30276,"web_url":"https://patchwork.libcamera.org/comment/30276/","msgid":"<20240703151840.GK27927@pendragon.ideasonboard.com>","date":"2024-07-03T15:18:40","subject":"Re: [PATCH resend 2/2] libcamera: pipeline: simple: Enable\n\tsimplepipeline for intel-ipu6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hans and Dennis,\n\nThank you for the patch.\n\nOn Wed, Jul 03, 2024 at 05:09:23PM +0200, Hans de Goede wrote:\n> From: Dennis Bonke \n> \n> Enable the simple pipeline handler with software ISP for the IPU6\n> now that te IPU6 CSI2 receiver (aka the isys driver) has landed\n\ns/that te/that the/\n\n> in media_staging/master.\n> \n> Signed-off-by: Dennis Bonke \n> Signed-off-by: Hans de Goede \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 5eb1dd21..60aafc4e 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -198,6 +198,7 @@ namespace {\n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {}, false },\n> \t{ \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> +\t{ \"intel-ipu6\", {}, true },\n> \t{ \"j721e-csi2rx\", {}, false },\n> \t{ \"mtk-seninf\", { { \"mtk-mdp\", 3 } }, false },\n> \t{ \"mxc-isi\", {}, false },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09640BD87C\n\tfor ;\n\tWed, 3 Jul 2024 15:19:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A4E262E22;\n\tWed, 3 Jul 2024 17:19:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FB3B62C95\n\tfor ;\n\tWed, 3 Jul 2024 17:19:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF4143E6;\n\tWed, 3 Jul 2024 17:18:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ivc2JCX4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720019913;\n\tbh=JT8LMV+lLYpV1JJNwoyLWzC9FXTSwM8wk0wm8Ga+rvI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ivc2JCX4YR8Ln0XeDDdFJpnrmQfE3j/cnPgixo8KQr4iPVsnARr1Fj2w3JTOeib1L\n\tsATalUeU+AzeAJ3/O77KUX5tdsSMBUMip1VyTHVlGlE+AjRoE5oKSF90VqdtRlGHWX\n\tp3o19Op6BWixvyLdgBf3OCq/WZJZQCBTeZSBG+Q0=","Date":"Wed, 3 Jul 2024 18:18:40 +0300","From":"Laurent Pinchart ","To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ,\n\tMaxime Ripard , Dennis Bonke ","Subject":"Re: [PATCH resend 2/2] libcamera: pipeline: simple: Enable\n\tsimplepipeline for intel-ipu6","Message-ID":"<20240703151840.GK27927@pendragon.ideasonboard.com>","References":"<20240703150923.25994-1-hdegoede@redhat.com>\n\t<20240703150923.25994-2-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240703150923.25994-2-hdegoede@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30287,"web_url":"https://patchwork.libcamera.org/comment/30287/","msgid":"<9c809ca8-1148-4cd3-afb3-314bb1d962fa@ideasonboard.com>","date":"2024-07-04T04:28:15","subject":"Re: [PATCH resend 2/2] libcamera: pipeline: simple: Enable\n\tsimplepipeline for intel-ipu6","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello all,\n\nOn 03/07/24 8:48 pm, Laurent Pinchart wrote:\n> Hi Hans and Dennis,\n>\n> Thank you for the patch.\n>\n> On Wed, Jul 03, 2024 at 05:09:23PM +0200, Hans de Goede wrote:\n>> From: Dennis Bonke \n>>\n>> Enable the simple pipeline handler with software ISP for the IPU6\n>> now that te IPU6 CSI2 receiver (aka the isys driver) has landed\n> s/that te/that the/\n>\n>> in media_staging/master.\n>>\n>> Signed-off-by: Dennis Bonke \n>> Signed-off-by: Hans de Goede \n> Reviewed-by: Laurent Pinchart \nIn subject,\n\ns/simplepipeline/simple pipeline/\n\nor can be better rephrased to,\n\nlibcamera: pipeline: simple: Enable intel-ipu6 with Soft ISP\n\nReviewed-by: Umang Jain \n>\n>> ---\n>> src/libcamera/pipeline/simple/simple.cpp | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index 5eb1dd21..60aafc4e 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -198,6 +198,7 @@ namespace {\n>> static const SimplePipelineInfo supportedDevices[] = {\n>> \t{ \"dcmipp\", {}, false },\n>> \t{ \"imx7-csi\", { { \"pxp\", 1 } }, false },\n>> +\t{ \"intel-ipu6\", {}, true },\n>> \t{ \"j721e-csi2rx\", {}, false },\n>> \t{ \"mtk-seninf\", { { \"mtk-mdp\", 3 } }, false },\n>> \t{ \"mxc-isi\", {}, false },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1013BD87C\n\tfor ;\n\tThu, 4 Jul 2024 04:28:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2DD462C96;\n\tThu, 4 Jul 2024 06:28:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B024619C3\n\tfor ;\n\tThu, 4 Jul 2024 06:28:22 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 463B4502;\n\tThu, 4 Jul 2024 06:27:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WEyj+20H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720067273;\n\tbh=1h7FBoaB243bHN4aAPvIliqlILXaKIdWgaQM+T0zrak=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=WEyj+20Hnwx90IzBKjVtGrSDTL5DBXQVoBL5R419J2m8ZFb5T53QvpKc6Jl46HK52\n\tB2lExO8uHzIJBsgut0bXvA3h0OLANiqgfNC1Bt1lWDQ06qclCNnST6lg1rrLfWUp4w\n\t2XhwNFd7sDdK9SEVrfi9hprj6OEj6mn84q9X1NtI=","Message-ID":"<9c809ca8-1148-4cd3-afb3-314bb1d962fa@ideasonboard.com>","Date":"Thu, 4 Jul 2024 09:58:15 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH resend 2/2] libcamera: pipeline: simple: Enable\n\tsimplepipeline for intel-ipu6","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tHans de Goede ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ,\n\tMaxime Ripard , Dennis Bonke ","References":"<20240703150923.25994-1-hdegoede@redhat.com>\n\t<20240703150923.25994-2-hdegoede@redhat.com>\n\t<20240703151840.GK27927@pendragon.ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240703151840.GK27927@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]