[{"id":30339,"web_url":"https://patchwork.libcamera.org/comment/30339/","msgid":"","date":"2024-07-05T06:29:57","subject":"Re: [PATCH v3 23/23] libtuning: agc: rkisp1: Increase y-target","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 04:17:12PM +0200, Stefan Klug wrote:\n> With the addition of gamma out correction the relative luminance target\n> was set too low. As brightness is a bit subjective it is difficult to\n> come up with the \"correct\" value. With 0.5 the patch 22 on the mac beth\n\ns/mac beth/macbeth/\n\n> chart (neutral grey, 18% reflectance) ended up a bit below 50% grey,\n> which seems reasonable.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> index 19a5555b6111..7147028a774a 100644\n> --- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n> +++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> @@ -64,7 +64,7 @@ class AGCRkISP1(AGC):\n> return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}\n> \n> def _generate_y_target(self) -> list:\n> - return 0.16\n> + return 0.5\n> \n> def process(self, config: dict, images: list, outputs: dict) -> dict:\n> output = {}\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26168BEFBE\n\tfor ;\n\tFri, 5 Jul 2024 06:30:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C360962E22;\n\tFri, 5 Jul 2024 08:30:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EEBB619BE\n\tfor ;\n\tFri, 5 Jul 2024 08:30:04 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DD3A7F3;\n\tFri, 5 Jul 2024 08:29:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uIy0LdJ4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720160974;\n\tbh=URDGcqjlx5pww/i9kzYFMWyp8JC+3idJ+z9CJ5+lr0E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uIy0LdJ4AlvRLpIXpwiPMg0ti6Evl1UbWRxcXeJOWh9PXJf/QmQlQZqCIFUnGPDlY\n\te2vI5ZhmeGwQerizJeeCjyBnYywbd7VQYSaZ2fMa7LrnexUQURVelN16r9uZwoKZvg\n\tNq4kMMCwoBqVxHI0SiWBggxUmjzXJS+zEI+crLnU=","Date":"Fri, 5 Jul 2024 15:29:57 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 23/23] libtuning: agc: rkisp1: Increase y-target","Message-ID":"","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>\n\t<20240703141726.252368-24-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703141726.252368-24-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]