[{"id":30307,"web_url":"https://patchwork.libcamera.org/comment/30307/","msgid":"","date":"2024-07-04T09:59:01","subject":"Re: [PATCH v3 19/23] libtuning: Add static module","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 04:17:08PM +0200, Stefan Klug wrote:\n> Add a static module class, that can be used to add static data to the\n> tuning file. This is propably not the best solution, but allows us to\n> progress without writing lots of dummy classes for static cases.\n\nI think this is actually a pretty good idea.\n\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/libtuning/modules/static.py | 24 ++++++++++++++++++++++++\n> 1 file changed, 24 insertions(+)\n> create mode 100644 utils/tuning/libtuning/modules/static.py\n> \n> diff --git a/utils/tuning/libtuning/modules/static.py b/utils/tuning/libtuning/modules/static.py\n> new file mode 100644\n> index 000000000000..4d0f7e18c24e\n> --- /dev/null\n> +++ b/utils/tuning/libtuning/modules/static.py\n> @@ -0,0 +1,24 @@\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> +#\n> +# Copyright (C) 2024, Ideas on Board\n> +#\n> +# Module implementation for static data\n> +\n> +from .module import Module\n> +\n> +\n> +# This module can be used in cases where the tuning file should contain\n> +# static data.\n> +class StaticModule(Module):\n> + def __init__(self, out_name: str, output: dict = {}):\n> + super().__init__()\n> + self.out_name = out_name\n> + self.hr_name = f'Static {out_name}'\n> + self.type = f'static_{out_name}'\n> + self.output = output\n> +\n> + def validate_config(self, config: dict) -> bool:\n> + return True\n> +\n> + def process(self, config: dict, images: list, outputs: dict) -> dict:\n> + return self.output\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61328BD87C\n\tfor ;\n\tThu, 4 Jul 2024 09:59:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01A5762E23;\n\tThu, 4 Jul 2024 11:59:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6E0A619C4\n\tfor ;\n\tThu, 4 Jul 2024 11:59:07 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7518502;\n\tThu, 4 Jul 2024 11:58:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tiK8bzXt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720087118;\n\tbh=8nitDa9tqsX21BGIQZrCr6HWx9+xi81TGsscR6olIoI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tiK8bzXtyukm0uIwzGyDFBg+p/XAnvjzZeC3ouENDMYJPN1xLUBk+bbhlHGRxWbqH\n\tH464NoYjifot8UT/B7wd3abG7BpcU3IBtnf4GreFLXTEy7OI/NstdcSm01v+jjDf0Z\n\tkiv5U/0Ujl88X6fGCf+kOJcb8fPMN4lh8iy4gUVE=","Date":"Thu, 4 Jul 2024 18:59:01 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 19/23] libtuning: Add static module","Message-ID":"","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>\n\t<20240703141726.252368-20-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703141726.252368-20-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]