[{"id":30314,"web_url":"https://patchwork.libcamera.org/comment/30314/","msgid":"","date":"2024-07-04T10:29:09","subject":"Re: [PATCH v3 18/23] libtuning: Only warn if processing returns None","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 04:17:07PM +0200, Stefan Klug wrote:\n> There are valid cases where a module returns None. E.g no images were\n> provided for lsc calibration. We should however define proper semantics\n> there. Continue with a warning for now.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/libtuning/generators/yaml_output.py | 3 +++\n> utils/tuning/libtuning/libtuning.py | 4 ++--\n> 2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/generators/yaml_output.py b/utils/tuning/libtuning/generators/yaml_output.py\n> index 31e265df4ea7..c490081d7de7 100644\n> --- a/utils/tuning/libtuning/generators/yaml_output.py\n> +++ b/utils/tuning/libtuning/generators/yaml_output.py\n> @@ -107,6 +107,9 @@ class YamlOutput(Generator):\n> ]\n> \n> for module in output_order:\n> + if module not in output_dict:\n> + continue\n> +\n> out_lines.append(f' - {module.out_name}:')\n> \n> if len(output_dict[module]) == 0:\n> diff --git a/utils/tuning/libtuning/libtuning.py b/utils/tuning/libtuning/libtuning.py\n> index 5342e5d6daaa..e7c63535fefd 100644\n> --- a/utils/tuning/libtuning/libtuning.py\n> +++ b/utils/tuning/libtuning/libtuning.py\n> @@ -200,8 +200,8 @@ class Tuner(object):\n> for module in self.modules:\n> out = module.process(self.config, images, self.output)\n> if out is None:\n> - logger.error(f'Module {module.hr_name} failed to process...')\n> - break\n> + logger.warning(f'Module {module.hr_name} failed to process...')\n> + continue\n> self.output[module] = out\n> \n> self.generator.write(args.output, self.output, self.output_order)\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5CA5BEFBE\n\tfor ;\n\tThu, 4 Jul 2024 10:29:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4DC262E24;\n\tThu, 4 Jul 2024 12:29:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3FC2619C8\n\tfor ;\n\tThu, 4 Jul 2024 12:29:15 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9392502;\n\tThu, 4 Jul 2024 12:28:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LjYTChR+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720088927;\n\tbh=KEDyN3jOJSRnOPdqjXenZevJTF6xd90GCJT3YlqoQxM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LjYTChR+2h2r0Ae1iDOi8nxHZF0OaekeTFyGjBuJHVnx770+6SrKNpCkgIWIADKuQ\n\tsg69VcunZayMEO6T3m6Z6DxNJtHU1PA0gngoi21Pir6nUPBe7zp1J6MRPcTSJD2h0b\n\tFyH8G+o466l8Zn4SnYdxbuzoachl1jWlwxB8q8wU=","Date":"Thu, 4 Jul 2024 19:29:09 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 18/23] libtuning: Only warn if processing returns None","Message-ID":"","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>\n\t<20240703141726.252368-19-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703141726.252368-19-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]