[{"id":30315,"web_url":"https://patchwork.libcamera.org/comment/30315/","msgid":"","date":"2024-07-04T10:30:04","subject":"Re: [PATCH v3 17/23] libtuning: Handle cases, where no lsc tuning\n\timages are present","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 04:17:06PM +0200, Stefan Klug wrote:\n> Make it clear that no lsc calibration was done by returning None instead\n> of a incomplete configuration.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n> index 57004104fc7a..512233aeae9d 100644\n> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py\n> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n> @@ -107,6 +107,9 @@ class LSCRkISP1(LSC):\n> \n> output['sets'] = self._do_all_lsc(images)\n> \n> + if len(output['sets']) == 0:\n> + return None\n> +\n> # \\todo Validate images from greyscale camera and force grescale mode\n> # \\todo Debug functionality\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EF94BEFBE\n\tfor ;\n\tThu, 4 Jul 2024 10:30:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC507619C8;\n\tThu, 4 Jul 2024 12:30:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95C12619C8\n\tfor ;\n\tThu, 4 Jul 2024 12:30:09 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB233502;\n\tThu, 4 Jul 2024 12:29:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sg+xmEZi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720088980;\n\tbh=ivvOZ3Aqg2H4IC/dwZt9dhPE9z1LDmfsYxBWxU+84cs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Sg+xmEZiREWsT3lJiS+u+Kye/Ocr12PjS7uawj7+HrKj+9pAuZSuTB9hco79Y5Z5e\n\tlr1/uW3sOMP0zevu/Zipr5ZRJFHHxyPoe5u5Wz0H+piwbUFJOODfE0CJ1nKYh7qcrI\n\tjIE34ei1mzINiiAq/V7jYz5nR6AkhstNg/nTHs0s=","Date":"Thu, 4 Jul 2024 19:30:04 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 17/23] libtuning: Handle cases, where no lsc tuning\n\timages are present","Message-ID":"","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>\n\t<20240703141726.252368-18-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703141726.252368-18-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]