[{"id":30305,"web_url":"https://patchwork.libcamera.org/comment/30305/","msgid":"","date":"2024-07-04T09:46:29","subject":"Re: [PATCH v3 15/23] libtuning: Remove need for Cam object from ccm","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 04:17:04PM +0200, Stefan Klug wrote:\n> Remove the need for the Cam object, as we don't want to port\n> it from Raspberry Pi.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/libtuning/ctt_ccm.py | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/ctt_ccm.py b/utils/tuning/libtuning/ctt_ccm.py\n> index 086ef8a2580b..2e87a6679f20 100644\n> --- a/utils/tuning/libtuning/ctt_ccm.py\n> +++ b/utils/tuning/libtuning/ctt_ccm.py\n> @@ -62,9 +62,8 @@ FInds colour correction matrices for list of images\n> \"\"\"\n> \n> \n> -def ccm(Cam, cal_cr_list, cal_cb_list):\n> +def ccm(imgs, cal_cr_list, cal_cb_list):\n> global matrix_selection_types, typenum\n> - imgs = Cam.imgs\n> \"\"\"\n> standard macbeth chart colour values\n> \"\"\"\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52EFFBD87C\n\tfor ;\n\tThu, 4 Jul 2024 09:46:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CBFF62E22;\n\tThu, 4 Jul 2024 11:46:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20EFE619C4\n\tfor ;\n\tThu, 4 Jul 2024 11:46:36 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 399283A2;\n\tThu, 4 Jul 2024 11:46:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FHigVSlD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720086367;\n\tbh=3dHXhyfzb+IZPRq842NzhSMB8olxOc0ZVY9488Z4AzU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FHigVSlDodaK+7KZfjXaulgWxrCtriDKgD+T7nEWuzdVHuiEa3sjH7x1LeEmxZG/v\n\t3LFc06If6GjoKtePI0qm/iUQbXdM/ht8aRjBRQDKvqTfJtg+8u36rIIQdB2v2aT9j1\n\tlDpHnQqyqhyCmSM39IY7tC9uffvlPf15KO1ApynA=","Date":"Thu, 4 Jul 2024 18:46:29 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 15/23] libtuning: Remove need for Cam object from ccm","Message-ID":"","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>\n\t<20240703141726.252368-16-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703141726.252368-16-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]