[{"id":30296,"web_url":"https://patchwork.libcamera.org/comment/30296/","msgid":"","date":"2024-07-04T09:01:02","subject":"Re: [PATCH v3 05/23] utils: tuning: Add requirements file and update\n\treadme","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 04:16:54PM +0200, Stefan Klug wrote:\n> Add a requirements file to ease the installation and use of the tuning\n> scripts. Document that in the readme. No debian packages are provided as\n> rawpy is not packaged as deb. So pip has to be used anyways.\n> \n> Also add pyyaml which was missing in the dependencies.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n> ---\n> utils/tuning/README.rst | 23 ++++++++++++++++-------\n> utils/tuning/requirements.txt | 5 +++++\n> 2 files changed, 21 insertions(+), 7 deletions(-)\n> create mode 100644 utils/tuning/requirements.txt\n> \n> diff --git a/utils/tuning/README.rst b/utils/tuning/README.rst\n> index ef3e6ad76f1b..ec05c116c536 100644\n> --- a/utils/tuning/README.rst\n> +++ b/utils/tuning/README.rst\n> @@ -1,11 +1,20 @@\n> .. SPDX-License-Identifier: CC-BY-SA-4.0\n> \n> -.. TODO: Write an overview of libtuning\n> +libcamera tuning tools\n> +======================\n> \n> -Dependencies\n> -------------\n> +.. Note:: The tuning tool are still very much work in progress. If in doubt, \n\ns/are/is/\n\nReviewed-by: Paul Elder \n\n> + please ask on the mailing list.\n> +\n> +.. todo::\n> + Write documentation\n> +\n> +Installation of dependencies\n> +----------------------------\n> +\n> +::\n> + # Using a venv\n> + python3 -m venv venv\n> + . ./venv/bin/activate\n> + pip3 install -r requirements.txt\n> \n> -- numpy\n> -- opencv-python\n> -- py3exiv2\n> -- rawpy\n> diff --git a/utils/tuning/requirements.txt b/utils/tuning/requirements.txt\n> new file mode 100644\n> index 000000000000..d1dc589d0329\n> --- /dev/null\n> +++ b/utils/tuning/requirements.txt\n> @@ -0,0 +1,5 @@\n> +numpy\n> +opencv-python\n> +py3exiv2\n> +pyyaml\n> +rawpy\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5DCBBD87C\n\tfor ;\n\tThu, 4 Jul 2024 09:01:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80CCF62E24;\n\tThu, 4 Jul 2024 11:01:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 106F162C99\n\tfor ;\n\tThu, 4 Jul 2024 11:01:10 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA39C83F;\n\tThu, 4 Jul 2024 11:00:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xgw2U1TO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720083641;\n\tbh=T3az/Iz52X6Hj30YkJGqKAoSuMr0qLdm2aSIimMZJHA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xgw2U1TORliDAG4z/Vy2RiCf3f4tSX/C4WNbJsghHWjtr/Deq2Ha9qwqT0u0Qc6Qz\n\tWv3W0ScagE3eEXGJJDvoa71oH/8y3U5TePVOMh6U6whixbytOjNHEshyDZA0oFma+B\n\twcXMnbQgkD/DxVMeYDTrPdS696HkLH00L5WoCCGM=","Date":"Thu, 4 Jul 2024 18:01:02 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 05/23] utils: tuning: Add requirements file and update\n\treadme","Message-ID":"","References":"<20240703141726.252368-1-stefan.klug@ideasonboard.com>\n\t<20240703141726.252368-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703141726.252368-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]