[{"id":30291,"web_url":"https://patchwork.libcamera.org/comment/30291/","msgid":"","date":"2024-07-04T08:40:46","subject":"Re: [PATCH v3 5/6] ipa: rkisp1: data: Update tuning files for imx219\n\tand imx258","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 03:49:53PM +0200, Stefan Klug wrote:\n> The black levels for imx219 and imx258 are now contained in the camera\n> sensor helpers. Remove them from the tuning file for the imx219. Add a\n> BLC entry to the imx258 tuning file.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 4 ----\n> src/ipa/rkisp1/data/imx258.yaml | 1 +\n> 2 files changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> index cbcc43b84ac7..0d99cb529392 100644\n> --- a/src/ipa/rkisp1/data/imx219.yaml\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -6,10 +6,6 @@ algorithms:\n> - Agc:\n> - Awb:\n> - BlackLevelCorrection:\n> - R: 256\n> - Gr: 256\n> - Gb: 256\n> - B: 256\n> - LensShadingCorrection:\n> x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> diff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml\n> index 43dddf20dcd2..202af36afbee 100644\n> --- a/src/ipa/rkisp1/data/imx258.yaml\n> +++ b/src/ipa/rkisp1/data/imx258.yaml\n> @@ -5,6 +5,7 @@ version: 1\n> algorithms:\n> - Agc:\n> - Awb:\n> + - BlackLevelCorrection:\n> - LensShadingCorrection:\n> x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B32A0BD87C\n\tfor ;\n\tThu, 4 Jul 2024 08:40:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FABA62E24;\n\tThu, 4 Jul 2024 10:40:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F309F619C4\n\tfor ;\n\tThu, 4 Jul 2024 10:40:52 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A0735502;\n\tThu, 4 Jul 2024 10:40:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ClgJnGa8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720082424;\n\tbh=z7/0rqRRp1c3CE6Db/lrt2zy24bNINZw24GY984Mdvg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ClgJnGa8+NqwSUan5wkt2APGvN+c52SQqbjI9LYuc6IL+ovXMSdX9T269U3NdW8G8\n\tk/6M2LIaudvODTNv8+PSHpskseC3dbagYfe6Kh5u5LHDncqTFyXGvsJkMWdpV7+3jY\n\ts65HqNlbK50RgpU26xLpqzlLr9gTBrCvL1S1IfEg=","Date":"Thu, 4 Jul 2024 17:40:46 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 5/6] ipa: rkisp1: data: Update tuning files for imx219\n\tand imx258","Message-ID":"","References":"<20240703135000.242227-1-stefan.klug@ideasonboard.com>\n\t<20240703135000.242227-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240703135000.242227-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]