[{"id":30257,"web_url":"https://patchwork.libcamera.org/comment/30257/","msgid":"<172000901295.3353312.8906253943668969407@ping.linuxembedded.co.uk>","date":"2024-07-03T12:16:52","subject":"Re: [PATCH v2 5/6] ipa: rkisp1: data: Update tuning files for imx219\n\tand imx258","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-07-03 11:39:52)\n> The black levels for imx219 and imx258 are now contained in the camera\n> sensor helpers. Remove them from the tuning file for the imx219. Add a\n> BLC entry to the imx258 tuning file.\n> \n> Signed-off-by: Stefan Klug \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 4 ----\n> src/ipa/rkisp1/data/imx258.yaml | 1 +\n> 2 files changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> index cbcc43b84ac7..0d99cb529392 100644\n> --- a/src/ipa/rkisp1/data/imx219.yaml\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -6,10 +6,6 @@ algorithms:\n> - Agc:\n> - Awb:\n> - BlackLevelCorrection:\n> - R: 256\n> - Gr: 256\n> - Gb: 256\n> - B: 256\n> - LensShadingCorrection:\n> x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> diff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml\n> index 43dddf20dcd2..202af36afbee 100644\n> --- a/src/ipa/rkisp1/data/imx258.yaml\n> +++ b/src/ipa/rkisp1/data/imx258.yaml\n> @@ -5,6 +5,7 @@ version: 1\n> algorithms:\n> - Agc:\n> - Awb:\n> + - BlackLevelCorrection:\n> - LensShadingCorrection:\n> x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 388B7BD87C\n\tfor ;\n\tWed, 3 Jul 2024 12:16:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC44F62C99;\n\tWed, 3 Jul 2024 14:16:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E261162C99\n\tfor ;\n\tWed, 3 Jul 2024 14:16:55 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE7233E6;\n\tWed, 3 Jul 2024 14:16:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mPOCRVgm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720008987;\n\tbh=m66xgC/Jp2lKtaNtjSOwfsfcW/xw9sniOaFWvTjo3D0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mPOCRVgmnpryQrMuJG/XeWZ1uqXF4BehTRKRnmUPOZmyNkdDDH2jaU9bGoxvLhSUU\n\tdqxp7qlflz9qv4UtLyWT1XdEG1cdl29tK+mLl8/K0JXlW5SDemV8XNddjMCgsPgKTu\n\t0w+kOkzJpALmYQa22nC0XUs5tWZl65ruukEwn3E4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240703104004.184783-6-stefan.klug@ideasonboard.com>","References":"<20240703104004.184783-1-stefan.klug@ideasonboard.com>\n\t<20240703104004.184783-6-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 5/6] ipa: rkisp1: data: Update tuning files for imx219\n\tand imx258","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 03 Jul 2024 13:16:52 +0100","Message-ID":"<172000901295.3353312.8906253943668969407@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30269,"web_url":"https://patchwork.libcamera.org/comment/30269/","msgid":"<20240703124525.GD27927@pendragon.ideasonboard.com>","date":"2024-07-03T12:45:25","subject":"Re: [PATCH v2 5/6] ipa: rkisp1: data: Update tuning files for imx219\n\tand imx258","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Wed, Jul 03, 2024 at 12:39:52PM +0200, Stefan Klug wrote:\n> The black levels for imx219 and imx258 are now contained in the camera\n> sensor helpers. Remove them from the tuning file for the imx219. Add a\n> BLC entry to the imx258 tuning file.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 4 ----\n> src/ipa/rkisp1/data/imx258.yaml | 1 +\n> 2 files changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> index cbcc43b84ac7..0d99cb529392 100644\n> --- a/src/ipa/rkisp1/data/imx219.yaml\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -6,10 +6,6 @@ algorithms:\n> - Agc:\n> - Awb:\n> - BlackLevelCorrection:\n> - R: 256\n> - Gr: 256\n> - Gb: 256\n> - B: 256\n> - LensShadingCorrection:\n> x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> diff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml\n> index 43dddf20dcd2..202af36afbee 100644\n> --- a/src/ipa/rkisp1/data/imx258.yaml\n> +++ b/src/ipa/rkisp1/data/imx258.yaml\n> @@ -5,6 +5,7 @@ version: 1\n> algorithms:\n> - Agc:\n> - Awb:\n> + - BlackLevelCorrection:\n> - LensShadingCorrection:\n> x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n> y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C38D1BD87C\n\tfor ;\n\tWed, 3 Jul 2024 12:45:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7762162E26;\n\tWed, 3 Jul 2024 14:45:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6753962C95\n\tfor ;\n\tWed, 3 Jul 2024 14:45:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5461E3E6;\n\tWed, 3 Jul 2024 14:45:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HXaAI84M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720010718;\n\tbh=npbEQj5TPiSfy2AAHUkMPx5o/rvtB3JsObTJ5OHOi3o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HXaAI84M7jgF0Q943Kip1qO6cgE8f0K/Oi09iLZhwGGynbW1YKcficHh4+CQDDwBY\n\t7gS2sn9YfWvfd+7bigAWqLD1qKsprMJFN1oAyn76kF6mI1Hn5MlehidY+igONaLAi6\n\tlaQjDJrerfjTzoCR0nOrKPC9HCRHQIPUwxjV6tpc=","Date":"Wed, 3 Jul 2024 15:45:25 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 5/6] ipa: rkisp1: data: Update tuning files for imx219\n\tand imx258","Message-ID":"<20240703124525.GD27927@pendragon.ideasonboard.com>","References":"<20240703104004.184783-1-stefan.klug@ideasonboard.com>\n\t<20240703104004.184783-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240703104004.184783-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]