{"id":20505,"url":"https://patchwork.libcamera.org/api/patches/20505/?format=json","web_url":"https://patchwork.libcamera.org/patch/20505/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240703104004.184783-6-stefan.klug@ideasonboard.com>","date":"2024-07-03T10:39:52","name":"[v2,5/6] ipa: rkisp1: data: Update tuning files for imx219 and imx258","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0d3f800e69af36b80b9503035174e4d592d9b6ea","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20505/mbox/","series":[{"id":4435,"url":"https://patchwork.libcamera.org/api/series/4435/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4435","date":"2024-07-03T10:39:47","name":"ipa: Add black level to camera sensor helpers","version":2,"mbox":"https://patchwork.libcamera.org/series/4435/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20505/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20505/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DDF5BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 10:40:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB45F63352;\n\tWed, 3 Jul 2024 12:40:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B4E962E27\n\tfor ;\n\tWed, 3 Jul 2024 12:40:26 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9263:c199:9587:576])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F25B3E6;\n\tWed, 3 Jul 2024 12:39:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lPyIH7SE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720003198;\n\tbh=X4rClZPn9FouOcVqNKttYH6S+sumwQKUduxEXHoiyd0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lPyIH7SEcdFAWXsCMFTshsN5wk+pGSWEXSZc4hbeMl7Zg8Fshdp6h1YlDbeTVl1Xn\n\tTPGUrmlxNyJo7A3/X6fWHgXD8B5HNP/UcAO5lYdP4pLVYyqg/lGx83MrOgfLVKYaZC\n\tHaZUjFmkgtW55/SzDZ1azevpzucGbPzufZK3aDEs=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 5/6] ipa: rkisp1: data: Update tuning files for imx219 and\n\timx258","Date":"Wed, 3 Jul 2024 12:39:52 +0200","Message-ID":"<20240703104004.184783-6-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240703104004.184783-1-stefan.klug@ideasonboard.com>","References":"<20240703104004.184783-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The black levels for imx219 and imx258 are now contained in the camera\nsensor helpers. Remove them from the tuning file for the imx219. Add a\nBLC entry to the imx258 tuning file.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/data/imx219.yaml | 4 ----\n src/ipa/rkisp1/data/imx258.yaml | 1 +\n 2 files changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\nindex cbcc43b84ac7..0d99cb529392 100644\n--- a/src/ipa/rkisp1/data/imx219.yaml\n+++ b/src/ipa/rkisp1/data/imx219.yaml\n@@ -6,10 +6,6 @@ algorithms:\n - Agc:\n - Awb:\n - BlackLevelCorrection:\n- R: 256\n- Gr: 256\n- Gb: 256\n- B: 256\n - LensShadingCorrection:\n x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\ndiff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml\nindex 43dddf20dcd2..202af36afbee 100644\n--- a/src/ipa/rkisp1/data/imx258.yaml\n+++ b/src/ipa/rkisp1/data/imx258.yaml\n@@ -5,6 +5,7 @@ version: 1\n algorithms:\n - Agc:\n - Awb:\n+ - BlackLevelCorrection:\n - LensShadingCorrection:\n x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n","prefixes":["v2","5/6"]}