[{"id":30234,"web_url":"https://patchwork.libcamera.org/comment/30234/","msgid":"<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>","date":"2024-07-03T07:13:45","subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Or should we maybe just unconditionally install all *.yaml files in this \nfolder?\n\nOn 03.07.24 06:52, Robert Mader wrote:\n> We have all these neat tuning files. Unfortunately we forgot to install\n> many of them.\n>\n> Signed-off-by: Robert Mader\n> ---\n> src/ipa/rkisp1/data/meson.build | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> index 7150e155..1e3522b2 100644\n> --- a/src/ipa/rkisp1/data/meson.build\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -2,8 +2,12 @@\n> \n> conf_files = files([\n> 'imx219.yaml',\n> + 'imx258.yaml',\n> + 'ov2685.yaml',\n> 'ov4689.yaml',\n> 'ov5640.yaml',\n> + 'ov5695.yaml',\n> + 'ov8858.yaml',\n> 'uncalibrated.yaml',\n> ])\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BACD0BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 07:13:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CF3A62E22;\n\tWed, 3 Jul 2024 09:13:48 +0200 (CEST)","from madrid.collaboradmins.com (madrid.collaboradmins.com\n\t[IPv6:2a00:1098:ed:100::25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE594619C7\n\tfor ;\n\tWed, 3 Jul 2024 09:13:46 +0200 (CEST)","from [100.107.172.5] (cola.collaboradmins.com [195.201.22.229])\n\t(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: rmader)\n\tby madrid.collaboradmins.com (Postfix) with ESMTPSA id 513E93781188\n\tfor ;\n\tWed, 3 Jul 2024 07:13:46 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"rT5AMfzs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1719990826;\n\tbh=lwxWf6L+gTBqOVL+oC5kkajg1ho5sckOEJsrccBYMuE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=rT5AMfzshYgwgH1kMcNqT958+Ts8IoivfHQGjrcbB3ZAm8bjmg+nemHPSsHngml/w\n\t7iQIXhBUN7VFZsTivfMU0Znc4EW4NdAaOYvA+l+FDJG1HRvtbVFUwbFmomqjOfeAfu\n\tieSsa1tAV9zNlGEmG/T4x4X5ILltboq61YtUfRFR3C2FTx0pAj5DNCYd4lKfySBlB7\n\tDAojLJIhFWyfDqIxEBxPQuqFxbiCb21YttH/bJRzKKLUhLiI6dXLrAq4MCj1U1F8Yu\n\ttEDNcCmIiR34MbuzSlx/nbKPLjqufIzohw7D+XEKaFkQWlYvyJ6QcnK+A6k4xIqZ6s\n\tmJGu9fCLC6soA==","Content-Type":"multipart/alternative;\n\tboundary=\"------------IFQ2457HraorP0WtccR39vR0\"","Message-ID":"<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>","Date":"Wed, 3 Jul 2024 09:13:45 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","To":"libcamera-devel@lists.libcamera.org","References":"<20240703045324.70160-1-robert.mader@collabora.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20240703045324.70160-1-robert.mader@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30241,"web_url":"https://patchwork.libcamera.org/comment/30241/","msgid":"<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>","date":"2024-07-03T07:58:44","subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Robert\n\nOn Wed, Jul 03, 2024 at 09:13:45AM GMT, Robert Mader wrote:\n> Or should we maybe just unconditionally install all *.yaml files in this\n> folder?\n>\n\nI would be suprised if meson allows usage of wildcards when listing\nfiles. In facts, from a very quick test, I get\n\n../src/ipa/rkisp1/data/meson.build:3:13: ERROR: File *.yaml does not exist.)\n\nIt's also specified in the FAQ\nhttps://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard\n\nAnd as suggested in the same webpage, if we really want to, we should\nadd a tiny scripts that lists all the .yaml file and call it from the\nmeson build file ? Is it worth it ?\n\n\n> On 03.07.24 06:52, Robert Mader wrote:\n> > We have all these neat tuning files. Unfortunately we forgot to install\n> > many of them.\n> >\n> > Signed-off-by: Robert Mader\n> > ---\n> > src/ipa/rkisp1/data/meson.build | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > index 7150e155..1e3522b2 100644\n> > --- a/src/ipa/rkisp1/data/meson.build\n> > +++ b/src/ipa/rkisp1/data/meson.build\n> > @@ -2,8 +2,12 @@\n> > conf_files = files([\n> > 'imx219.yaml',\n> > + 'imx258.yaml',\n> > + 'ov2685.yaml',\n> > 'ov4689.yaml',\n> > 'ov5640.yaml',\n> > + 'ov5695.yaml',\n> > + 'ov8858.yaml',\n> > 'uncalibrated.yaml',\n> > ])\n>\n> --\n> Robert Mader\n> Consultant Software Developer\n>\n> Collabora Ltd.\n> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK\n> Registered in England & Wales, no. 5513718","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10D68BD87C\n\tfor ;\n\tWed, 3 Jul 2024 07:58:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1A6A62E23;\n\tWed, 3 Jul 2024 09:58:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 972B7619C7\n\tfor ;\n\tWed, 3 Jul 2024 09:58:47 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FCD93E6;\n\tWed, 3 Jul 2024 09:58:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kZUDc001\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719993499;\n\tbh=Oqwr6L+dibxAzr2y/n4F74eFIzI+eN22BYezxC0UaTU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kZUDc001ume+tsMhn3m3rEwDm5PIh6K6xN3cJcmNS95qc2qeggF0uE4KBcjEW/Da2\n\tC44LiqkcwNUegKDZUqrB/1p8E8RosZllQS5KTG1PN50DCPgYpQIi3VLQvPGQ4rBUmq\n\thM6CvOZ0sMfLrVwisPGcXyn9UPQe5UiR/xhjpKTA=","Date":"Wed, 3 Jul 2024 09:58:44 +0200","From":"Jacopo Mondi ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","Message-ID":"<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>","References":"<20240703045324.70160-1-robert.mader@collabora.com>\n\t<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30243,"web_url":"https://patchwork.libcamera.org/comment/30243/","msgid":"<20240703080454.GC30367@pendragon.ideasonboard.com>","date":"2024-07-03T08:04:54","subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 09:58:44AM +0200, Jacopo Mondi wrote:\n> Hi Robert\n> \n> On Wed, Jul 03, 2024 at 09:13:45AM GMT, Robert Mader wrote:\n> > Or should we maybe just unconditionally install all *.yaml files in this\n> > folder?\n> \n> I would be suprised if meson allows usage of wildcards when listing\n> files. In facts, from a very quick test, I get\n> \n> ../src/ipa/rkisp1/data/meson.build:3:13: ERROR: File *.yaml does not exist.)\n> \n> It's also specified in the FAQ\n> https://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard\n> \n> And as suggested in the same webpage, if we really want to, we should\n> add a tiny scripts that lists all the .yaml file and call it from the\n> meson build file ? Is it worth it ?\n\nAnother option would be to extend checkstyle.py to catch this kind of\nissues. We already have a checker than warns if a header file is added\nto libcamera without a corresponding addition to meson.build.\n\n> > On 03.07.24 06:52, Robert Mader wrote:\n> > > We have all these neat tuning files. Unfortunately we forgot to install\n> > > many of them.\n> > >\n> > > Signed-off-by: Robert Mader\n> > > ---\n> > > src/ipa/rkisp1/data/meson.build | 4 ++++\n> > > 1 file changed, 4 insertions(+)\n> > >\n> > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > > index 7150e155..1e3522b2 100644\n> > > --- a/src/ipa/rkisp1/data/meson.build\n> > > +++ b/src/ipa/rkisp1/data/meson.build\n> > > @@ -2,8 +2,12 @@\n> > > conf_files = files([\n> > > 'imx219.yaml',\n> > > + 'imx258.yaml',\n> > > + 'ov2685.yaml',\n> > > 'ov4689.yaml',\n> > > 'ov5640.yaml',\n> > > + 'ov5695.yaml',\n> > > + 'ov8858.yaml',\n> > > 'uncalibrated.yaml',\n> > > ])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5FA8BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 08:05:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDF5D62E01;\n\tWed, 3 Jul 2024 10:05:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5DBB62C96\n\tfor ;\n\tWed, 3 Jul 2024 10:05:15 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7E8A6D6;\n\tWed, 3 Jul 2024 10:04:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bsIdtzf0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719993887;\n\tbh=4c8n4tM9aWi2Z9B45KGyYMSuYxNes13ZfTpA1n6v2hs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bsIdtzf0DYwWepts19JO98oWbpYGuvdllWOw2oOZgde4M4gJ6rWGlMmTcRDBuRZaZ\n\t9nM5wGocfdZfGurGVXv2XTO6TxQa1rAjVjJzjxEGZXmoqT0t2i/MTRi8s8GrpZT4gl\n\t8z6emig2iq/zLhH9xcRfhDuLdgRqIpcyFaLzPVRE=","Date":"Wed, 3 Jul 2024 11:04:54 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","Message-ID":"<20240703080454.GC30367@pendragon.ideasonboard.com>","References":"<20240703045324.70160-1-robert.mader@collabora.com>\n\t<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>\n\t<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30260,"web_url":"https://patchwork.libcamera.org/comment/30260/","msgid":"<172000965674.3353312.16578343727423485394@ping.linuxembedded.co.uk>","date":"2024-07-03T12:27:36","subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-07-03 09:04:54)\n> On Wed, Jul 03, 2024 at 09:58:44AM +0200, Jacopo Mondi wrote:\n> > Hi Robert\n> > \n> > On Wed, Jul 03, 2024 at 09:13:45AM GMT, Robert Mader wrote:\n> > > Or should we maybe just unconditionally install all *.yaml files in this\n> > > folder?\n> > \n> > I would be suprised if meson allows usage of wildcards when listing\n> > files. In facts, from a very quick test, I get\n> > \n> > ../src/ipa/rkisp1/data/meson.build:3:13: ERROR: File *.yaml does not exist.)\n> > \n> > It's also specified in the FAQ\n> > https://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard\n> > \n> > And as suggested in the same webpage, if we really want to, we should\n> > add a tiny scripts that lists all the .yaml file and call it from the\n> > meson build file ? Is it worth it ?\n> \n> Another option would be to extend checkstyle.py to catch this kind of\n> issues. We already have a checker than warns if a header file is added\n> to libcamera without a corresponding addition to meson.build.\n\nIndeed, but none of that changes the fact that we should probably\ninstall the files we currently 'have'. \n\nIn the future I wonder if the tuning files would be separated out to a\nseparate repository or platform specific packages - or ... otherwise -\nbut for now I think if we have these files as part of libcamera, they're\ninstallable...\n\n\nReviewed-by: Kieran Bingham \n\n> \n> > > On 03.07.24 06:52, Robert Mader wrote:\n> > > > We have all these neat tuning files. Unfortunately we forgot to install\n> > > > many of them.\n> > > >\n> > > > Signed-off-by: Robert Mader\n> > > > ---\n> > > > src/ipa/rkisp1/data/meson.build | 4 ++++\n> > > > 1 file changed, 4 insertions(+)\n> > > >\n> > > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > > > index 7150e155..1e3522b2 100644\n> > > > --- a/src/ipa/rkisp1/data/meson.build\n> > > > +++ b/src/ipa/rkisp1/data/meson.build\n> > > > @@ -2,8 +2,12 @@\n> > > > conf_files = files([\n> > > > 'imx219.yaml',\n> > > > + 'imx258.yaml',\n> > > > + 'ov2685.yaml',\n> > > > 'ov4689.yaml',\n> > > > 'ov5640.yaml',\n> > > > + 'ov5695.yaml',\n> > > > + 'ov8858.yaml',\n> > > > 'uncalibrated.yaml',\n> > > > ])\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08C56BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 12:27:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82E3362E23;\n\tWed, 3 Jul 2024 14:27:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B562862C95\n\tfor ;\n\tWed, 3 Jul 2024 14:27:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 592CF3E6;\n\tWed, 3 Jul 2024 14:27:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Alkg+EZD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720009631;\n\tbh=UTIqXxp1R3O5QDCJk1FNYmYp/Eiz3B9uOYSFgra2L9g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Alkg+EZDB7R+tf8GICKquIf5Vopyw/sSlJ0OvJ254NrNG8jneEo84cRWri+0eIfQ/\n\t3Qp1yw+5774TzI4mnVkz3RoAMIpAwZHVBLOVUjCqqpe59+66yTekf0591QkisBsKBl\n\tU0nfGdLsWn3/JGNnECbp1Mn51W3+YrPkPUTsLniI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240703080454.GC30367@pendragon.ideasonboard.com>","References":"<20240703045324.70160-1-robert.mader@collabora.com>\n\t<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>\n\t<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>\n\t<20240703080454.GC30367@pendragon.ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","From":"Kieran Bingham ","Cc":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","Date":"Wed, 03 Jul 2024 13:27:36 +0100","Message-ID":"<172000965674.3353312.16578343727423485394@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30262,"web_url":"https://patchwork.libcamera.org/comment/30262/","msgid":"<172000971192.3353312.11300052581890231761@ping.linuxembedded.co.uk>","date":"2024-07-03T12:28:31","subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2024-07-03 13:27:36)\n> Quoting Laurent Pinchart (2024-07-03 09:04:54)\n> > On Wed, Jul 03, 2024 at 09:58:44AM +0200, Jacopo Mondi wrote:\n> > > Hi Robert\n> > > \n> > > On Wed, Jul 03, 2024 at 09:13:45AM GMT, Robert Mader wrote:\n> > > > Or should we maybe just unconditionally install all *.yaml files in this\n> > > > folder?\n> > > \n> > > I would be suprised if meson allows usage of wildcards when listing\n> > > files. In facts, from a very quick test, I get\n> > > \n> > > ../src/ipa/rkisp1/data/meson.build:3:13: ERROR: File *.yaml does not exist.)\n> > > \n> > > It's also specified in the FAQ\n> > > https://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard\n> > > \n> > > And as suggested in the same webpage, if we really want to, we should\n> > > add a tiny scripts that lists all the .yaml file and call it from the\n> > > meson build file ? Is it worth it ?\n> > \n> > Another option would be to extend checkstyle.py to catch this kind of\n> > issues. We already have a checker than warns if a header file is added\n> > to libcamera without a corresponding addition to meson.build.\n> \n> Indeed, but none of that changes the fact that we should probably\n> install the files we currently 'have'. \n> \n> In the future I wonder if the tuning files would be separated out to a\n> separate repository or platform specific packages - or ... otherwise -\n> but for now I think if we have these files as part of libcamera, they're\n> installable...\n> \n\nIn the case of the IMX258 for instance, which is expected to be\nsupported on the PinePhone Pro - installing this means that device will\nnow have lens shading and black level correction enabled (once Stefan's\nseries is merged).\n\n\n\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > > > On 03.07.24 06:52, Robert Mader wrote:\n> > > > > We have all these neat tuning files. Unfortunately we forgot to install\n> > > > > many of them.\n> > > > >\n> > > > > Signed-off-by: Robert Mader\n> > > > > ---\n> > > > > src/ipa/rkisp1/data/meson.build | 4 ++++\n> > > > > 1 file changed, 4 insertions(+)\n> > > > >\n> > > > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > > > > index 7150e155..1e3522b2 100644\n> > > > > --- a/src/ipa/rkisp1/data/meson.build\n> > > > > +++ b/src/ipa/rkisp1/data/meson.build\n> > > > > @@ -2,8 +2,12 @@\n> > > > > conf_files = files([\n> > > > > 'imx219.yaml',\n> > > > > + 'imx258.yaml',\n> > > > > + 'ov2685.yaml',\n> > > > > 'ov4689.yaml',\n> > > > > 'ov5640.yaml',\n> > > > > + 'ov5695.yaml',\n> > > > > + 'ov8858.yaml',\n> > > > > 'uncalibrated.yaml',\n> > > > > ])\n> > \n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E63E1BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 12:28:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 839AA63331;\n\tWed, 3 Jul 2024 14:28:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEE2162E23\n\tfor ;\n\tWed, 3 Jul 2024 14:28:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6A9D3E6;\n\tWed, 3 Jul 2024 14:28:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QU+8fBwd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720009686;\n\tbh=GUwdIGvwyBt5HxmYxNjsVE+7ILR32vtu8H/Ltgc1aUA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=QU+8fBwdvfto13AtUxJ6W+BREopzwQ5b08nH0U6MauaZ9syqWKy9dQ91Qh+NvJl/r\n\tJvOKhWvL9mwSHbHAPEhEJLiMDmyJNkcnQEVY0jtieL9ErwFYjBk72UpN4om4LDxPtA\n\tO4KjUpBJ5ZILmDlD8qELAZRi5bnwO0j1HzqM29xw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<172000965674.3353312.16578343727423485394@ping.linuxembedded.co.uk>","References":"<20240703045324.70160-1-robert.mader@collabora.com>\n\t<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>\n\t<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>\n\t<20240703080454.GC30367@pendragon.ideasonboard.com>\n\t<172000965674.3353312.16578343727423485394@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","From":"Kieran Bingham ","Cc":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","Date":"Wed, 03 Jul 2024 13:28:31 +0100","Message-ID":"<172000971192.3353312.11300052581890231761@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30271,"web_url":"https://patchwork.libcamera.org/comment/30271/","msgid":"<20240703130149.GG27927@pendragon.ideasonboard.com>","date":"2024-07-03T13:01:49","subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 01:27:36PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-07-03 09:04:54)\n> > On Wed, Jul 03, 2024 at 09:58:44AM +0200, Jacopo Mondi wrote:\n> > > Hi Robert\n> > > \n> > > On Wed, Jul 03, 2024 at 09:13:45AM GMT, Robert Mader wrote:\n> > > > Or should we maybe just unconditionally install all *.yaml files in this\n> > > > folder?\n> > > \n> > > I would be suprised if meson allows usage of wildcards when listing\n> > > files. In facts, from a very quick test, I get\n> > > \n> > > ../src/ipa/rkisp1/data/meson.build:3:13: ERROR: File *.yaml does not exist.)\n> > > \n> > > It's also specified in the FAQ\n> > > https://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard\n> > > \n> > > And as suggested in the same webpage, if we really want to, we should\n> > > add a tiny scripts that lists all the .yaml file and call it from the\n> > > meson build file ? Is it worth it ?\n> > \n> > Another option would be to extend checkstyle.py to catch this kind of\n> > issues. We already have a checker than warns if a header file is added\n> > to libcamera without a corresponding addition to meson.build.\n> \n> Indeed, but none of that changes the fact that we should probably\n> install the files we currently 'have'. \n\nOh, absolutely. Sorry, I should have made that clearer:\n\nReviewed-by: Laurent Pinchart \n\n> In the future I wonder if the tuning files would be separated out to a\n> separate repository or platform specific packages - or ... otherwise -\n> but for now I think if we have these files as part of libcamera, they're\n> installable...\n> \n> Reviewed-by: Kieran Bingham \n> \n> > > > On 03.07.24 06:52, Robert Mader wrote:\n> > > > > We have all these neat tuning files. Unfortunately we forgot to install\n> > > > > many of them.\n> > > > >\n> > > > > Signed-off-by: Robert Mader\n> > > > > ---\n> > > > > src/ipa/rkisp1/data/meson.build | 4 ++++\n> > > > > 1 file changed, 4 insertions(+)\n> > > > >\n> > > > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > > > > index 7150e155..1e3522b2 100644\n> > > > > --- a/src/ipa/rkisp1/data/meson.build\n> > > > > +++ b/src/ipa/rkisp1/data/meson.build\n> > > > > @@ -2,8 +2,12 @@\n> > > > > conf_files = files([\n> > > > > 'imx219.yaml',\n> > > > > + 'imx258.yaml',\n> > > > > + 'ov2685.yaml',\n> > > > > 'ov4689.yaml',\n> > > > > 'ov5640.yaml',\n> > > > > + 'ov5695.yaml',\n> > > > > + 'ov8858.yaml',\n> > > > > 'uncalibrated.yaml',\n> > > > > ])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30828BD87C\n\tfor ;\n\tWed, 3 Jul 2024 13:02:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FFA762E22;\n\tWed, 3 Jul 2024 15:02:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B573162C95\n\tfor ;\n\tWed, 3 Jul 2024 15:02:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EB473D6;\n\tWed, 3 Jul 2024 15:01:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cHerkwU3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720011702;\n\tbh=U06KDspXfKTmqFg9zneGze3Pyk9gtDmzedfTLONi0jI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cHerkwU3hYVQqgBC56ZnPg8Bv+LTof+Y2IbalJKyw6bbJAnzo00L96wlWZ9NbI3Xu\n\tDqkDOmMB+pt5tw7Ta6JDEPjLSUYsQ1dLq9vK46wz0ZyKtFtYqe37PDUeM2EqO4Jqfs\n\tv/fbMIk6mvMzAlGQRmhepSOj73o3BQTcz2AlG0og=","Date":"Wed, 3 Jul 2024 16:01:49 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tRobert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rkisp1: Install all tuning files","Message-ID":"<20240703130149.GG27927@pendragon.ideasonboard.com>","References":"<20240703045324.70160-1-robert.mader@collabora.com>\n\t<7f8e40c0-9465-4b6a-b2f7-076f3b17dd2b@collabora.com>\n\t<7tfua3unnuoosgmwip5do4as7bpep6cbimv3dtqsj3g7knsfg3@pm3hhzbw723r>\n\t<20240703080454.GC30367@pendragon.ideasonboard.com>\n\t<172000965674.3353312.16578343727423485394@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172000965674.3353312.16578343727423485394@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]