[{"id":30173,"web_url":"https://patchwork.libcamera.org/comment/30173/","msgid":"<877ce57aav.fsf@redhat.com>","date":"2024-07-01T09:04:24","subject":"Re: [PATCH 4/4] libcamera: ipa: soft_simple: Drop ipa_interface.h\n\theader","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Umang Jain writes:\n\n> The ipa_interface.h header is already included in soft_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it from software-isp\n> IPA as deemed redundant.\n>\n> Signed-off-by: Umang Jain \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/simple/soft_simple.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index b7746ce0..3cc873a2 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -19,7 +19,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E4B9BEFBE\n\tfor ;\n\tMon, 1 Jul 2024 09:04:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEE3562C9D;\n\tMon, 1 Jul 2024 11:04:32 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F85362C98\n\tfor ;\n\tMon, 1 Jul 2024 11:04:31 +0200 (CEST)","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n\t[209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-692-W_r9rph5NJ6ZkB_BRB-53Q-1; Mon, 01 Jul 2024 05:04:28 -0400","by mail-ej1-f69.google.com with SMTP id\n\ta640c23a62f3a-a717af2eb94so197693566b.1\n\tfor ;\n\tMon, 01 Jul 2024 02:04:28 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a7525fb8387sm84254066b.94.2024.07.01.02.04.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Jul 2024 02:04:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"GMO5KEBz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719824670;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=sAqupNMkHylNpuh2QavKT7SkA5YvGlv9lDZ276bjMIU=;\n\tb=GMO5KEBzz7CSD3pagUnLAG9iEzAm8sDa8GmPbHYFYpBlYj89MytrFEiaM3qT9J3Vi6S88z\n\teFUvtI24zMTma+lt3RNyNfHSJu15LRVqWSUGCGRVTBWkhd9nt6oYXyYnUtpHSfFOtqSGtR\n\tgHzVvoJitZifuUKM9rb+jUiaRaZ/AH4=","X-MC-Unique":"W_r9rph5NJ6ZkB_BRB-53Q-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1719824666; x=1720429466;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=sAqupNMkHylNpuh2QavKT7SkA5YvGlv9lDZ276bjMIU=;\n\tb=qY90Mb5OaFZGyBnDgELDxqfGE5DbOqMaaBYUrWnK5yGsiPlWAvROU+Ze2w28bW/2BJ\n\tGtLfsxuHRWt30Q1I9j73q0dr6skyuffQl6/Cx6usYiknLQO1yYxwQgeAq/PfGtUtfl5S\n\tC9QbsenAmjKBrEBYjTBOqhLMFBKsYpbCqyccazRTqopcZGsELYsHkOn9f+GOj+cQ2YmS\n\tApp9TcO/o5VhGpnD8CBkNb4bGvp01AzlNRKhh10vnnCTHRu/T6dJ4/RwfTp08KDTzAZ7\n\tpHtxffmNWqPDM29bgQ+hSigdO59NbIhsJCgrfhTI/c7H+xUE64qwT30QqNNRtgEswTy3\n\t+5VA==","X-Gm-Message-State":"AOJu0Ywb/0++vnukYQp4nkNK/EOp1MMfqYbY5gjVS4Go6oftAZUohA0u\n\tbtzZ1gitfRMncLk7gxFayBDzZ60QlsKk0e77lCsrf/bONAZ4LpgJsmjACsUF0RuaI/qIL6ykdVc\n\tqfDJkEorfNUeYgkDSB8mrZIHOtX312A6UypbqnLhIBzoo4NZoBieltBtyWJMM+nhcZnsiNo+z/v\n\taaNp5KqCYoTUdlt+D7qiR8cBW1ocVTCPxaOaYhSAyCP/xtWG/W3WpbGEA=","X-Received":["by 2002:a17:907:7752:b0:a71:40d4:b1d7 with SMTP id\n\ta640c23a62f3a-a75144f5f27mr281844666b.56.1719824666020; \n\tMon, 01 Jul 2024 02:04:26 -0700 (PDT)","by 2002:a17:907:7752:b0:a71:40d4:b1d7 with SMTP id\n\ta640c23a62f3a-a75144f5f27mr281843566b.56.1719824665634; \n\tMon, 01 Jul 2024 02:04:25 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGs9YdH+jpBaRi9UBtElFQL2MMKlgyPfB3SWD9OLfcY+K713QuzJsYM2QzGah9fYA1B2iN9Qg==","From":"Milan Zamazal ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 4/4] libcamera: ipa: soft_simple: Drop ipa_interface.h\n\theader","In-Reply-To":"<20240701075720.46076-5-umang.jain@ideasonboard.com> (Umang\n\tJain's message of \"Mon, 1 Jul 2024 13:27:20 +0530\")","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-5-umang.jain@ideasonboard.com>","Date":"Mon, 01 Jul 2024 11:04:24 +0200","Message-ID":"<877ce57aav.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30178,"web_url":"https://patchwork.libcamera.org/comment/30178/","msgid":"<171982735887.392292.4537732599502497128@ping.linuxembedded.co.uk>","date":"2024-07-01T09:49:18","subject":"Re: [PATCH 4/4] libcamera: ipa: soft_simple: Drop ipa_interface.h\n\theader","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-07-01 08:57:20)\n> The ipa_interface.h header is already included in soft_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it from software-isp\n> IPA as deemed redundant.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/simple/soft_simple.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index b7746ce0..3cc873a2 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -19,7 +19,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n\n\nReviewed-by: Kieran Bingham \n\n> \n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3ECDCBEFBE\n\tfor ;\n\tMon, 1 Jul 2024 09:49:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD5DE62C9F;\n\tMon, 1 Jul 2024 11:49:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2ED6462C98\n\tfor ;\n\tMon, 1 Jul 2024 11:49:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91E02289;\n\tMon, 1 Jul 2024 11:48:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UW2zyomX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719827335;\n\tbh=gZlCI8dyTN7/2gnw2lh7r5Kes6ks0PNE5P7NYtXQGDo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=UW2zyomXsN1JeGT0AyTlpXNuCrWnoY7XZCOgDqqey+Qi/tXFb7hTVXEhJhPoWaAt4\n\tNMFI/+ASusaf8KSka5AtCiK6Fac8TFe+OXUmWU+zjGUIUGoyUgUiqYobZHWJNuW7hy\n\tSbiPU2wxy5SgvcJYB9ZvaT1TqhtwGGyu7QdaV908=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240701075720.46076-5-umang.jain@ideasonboard.com>","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-5-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 4/4] libcamera: ipa: soft_simple: Drop ipa_interface.h\n\theader","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 01 Jul 2024 10:49:18 +0100","Message-ID":"<171982735887.392292.4537732599502497128@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]