[{"id":30172,"web_url":"https://patchwork.libcamera.org/comment/30172/","msgid":"<87bk3h7ab9.fsf@redhat.com>","date":"2024-07-01T09:04:10","subject":"Re: [PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Umang Jain writes:\n\n> The ipa_interface.h header is already included in vimc_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA\n> and pipeline handler as deemed redundant.\n>\n> Signed-off-by: Umang Jain \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/vimc/vimc.cpp | 1 -\n> src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n> 2 files changed, 2 deletions(-)\n>\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index ebd63fa6..766e9c9c 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -16,7 +16,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> \n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 0ec9928e..838a9355 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -24,7 +24,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E513FBEFBE\n\tfor ;\n\tMon, 1 Jul 2024 09:04:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A182862C9D;\n\tMon, 1 Jul 2024 11:04:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACF9162C98\n\tfor ;\n\tMon, 1 Jul 2024 11:04:15 +0200 (CEST)","from mail-ej1-f70.google.com (mail-ej1-f70.google.com\n\t[209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-340-MTxbqb7iM-eijaCfViPSrw-1; Mon, 01 Jul 2024 05:04:13 -0400","by mail-ej1-f70.google.com with SMTP id\n\ta640c23a62f3a-a727d1e7e9aso188511166b.1\n\tfor ;\n\tMon, 01 Jul 2024 02:04:12 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a7400456582sm217051866b.153.2024.07.01.02.04.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Jul 2024 02:04:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"VGuUCMP+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719824654;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=yxjoKPpL1+G6Ar/sZ8xFQcIa2GtqH7FeJqV1LjcC864=;\n\tb=VGuUCMP+TCo358LA6yzoFYBRhsqdLPo5Ev5hzrE4vj3tHZkbDboDsvle+VqOwiyreozyVn\n\t9l1WSMjmXTIG7jO78x15+uQcjsL9Rv+HyGi+VS0kY58yZoY5gld//qTdaavQgCrLrKgXck\n\tNnKotvKPJJ0JEsunFE1kUwvTAzXmpAU=","X-MC-Unique":"MTxbqb7iM-eijaCfViPSrw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1719824651; x=1720429451;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=yxjoKPpL1+G6Ar/sZ8xFQcIa2GtqH7FeJqV1LjcC864=;\n\tb=QDetqdYJKA7pZY03X9IogcXKSnW/5dqBREHHpCRXWq4dQur+VZRh8ROOUNTY/8vIeD\n\tGL9JCBxJFEtaN1Ij/9vs4Qs0Rgs8d7UbfgogcvcNKk7vmpckYvZFMSHGoKLhZLDnQ72V\n\tiWKL5jXLNKwGit2AsiDP0jBZ4zE0ZNucXJvUVdu0iehPajCKeERwGPDEl3mqlIPdex7b\n\trjBMXSmnZmtfbSxvbzWMts4UtHclhnPpP1n+g95GlRqzJjKo4wI40DZD8j4LGqUCeSP1\n\t4Xauo0TT9IHv5L2TMGpCbcNe6RVgfoGVDNnd68FjZCufIfz9foc2cf0DJxDS8Dhz3SCi\n\tdmoQ==","X-Gm-Message-State":"AOJu0Yx4S7VkceyJ676igqvP+T7Uy3areisFqNuJ1iGAbcOxlbpPc3yC\n\txX9uDiVlAdo/ZwL2L7JH4QOlz8Mjvks4oYxTHRNAum9eLLAVY0FBjt+QU/dMztqXYs7hRNKC+C8\n\tIu6J5Y7fbJs972rZpA2hq3iz1/7j6QOKfEhk4v3+ujxCi/fitav+FW2J7HL5XbRT6ob4gCV9By1\n\tl3yJUm0VyF19USM+x0R0b1aWFk6QLX6+ijEyJ94D1oFwzRsKn2uZrvnZE=","X-Received":["by 2002:a17:906:aec4:b0:a72:7d32:ac91 with SMTP id\n\ta640c23a62f3a-a75144023ccmr275809266b.15.1719824651543; \n\tMon, 01 Jul 2024 02:04:11 -0700 (PDT)","by 2002:a17:906:aec4:b0:a72:7d32:ac91 with SMTP id\n\ta640c23a62f3a-a75144023ccmr275808166b.15.1719824651235; \n\tMon, 01 Jul 2024 02:04:11 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHn429enzG22N4WeCNid/sS9UPUA2lolR31nLH5+DYTqoOhhgG5E8iXZMDslM0I7ZBKiA5YBA==","From":"Milan Zamazal ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header","In-Reply-To":"<20240701075720.46076-4-umang.jain@ideasonboard.com> (Umang\n\tJain's message of \"Mon, 1 Jul 2024 13:27:19 +0530\")","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-4-umang.jain@ideasonboard.com>","Date":"Mon, 01 Jul 2024 11:04:10 +0200","Message-ID":"<87bk3h7ab9.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30177,"web_url":"https://patchwork.libcamera.org/comment/30177/","msgid":"<171982733115.392292.17501396274279226113@ping.linuxembedded.co.uk>","date":"2024-07-01T09:48:51","subject":"Re: [PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-07-01 08:57:19)\n> The ipa_interface.h header is already included in vimc_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA\n> and pipeline handler as deemed redundant.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/vimc/vimc.cpp | 1 -\n> src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index ebd63fa6..766e9c9c 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -16,7 +16,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n\nWhere's #include , and why isn't it\nhere?\n\n> \n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 0ec9928e..838a9355 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -24,7 +24,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n\n\nOtherwise,\n\nReviewed-by: Kieran Bingham \n\n\n> #include \n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5071FBEFBE\n\tfor ;\n\tMon, 1 Jul 2024 09:48:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DF9862C98;\n\tMon, 1 Jul 2024 11:48:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B69F562C95\n\tfor ;\n\tMon, 1 Jul 2024 11:48:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21A00289;\n\tMon, 1 Jul 2024 11:48:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SJZmyxqy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719827307;\n\tbh=r/SwIfSGMRtFB42fe8mr0MtoWYX95Ye5OKAIm4jJe8c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=SJZmyxqyR+/77r+oBnB8CP9ryNTcLXaB1kzZ/4jCwn1Ryq4Smp6x6RunHQuWq/aG4\n\tpFcAGa4SOKOzrsSitnn9tqp7i218H17q4ypl4P4KeP+Hoi2LMfUoEv2LXE2Y7xXvMo\n\t7D4qjLKzE83s4Xz1DHiXGLqcxv2WagEN29cHEHDY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240701075720.46076-4-umang.jain@ideasonboard.com>","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-4-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 01 Jul 2024 10:48:51 +0100","Message-ID":"<171982733115.392292.17501396274279226113@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30184,"web_url":"https://patchwork.libcamera.org/comment/30184/","msgid":"","date":"2024-07-01T13:08:30","subject":"Re: [PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 01/07/24 3:18 pm, Kieran Bingham wrote:\n> Quoting Umang Jain (2024-07-01 08:57:19)\n>> The ipa_interface.h header is already included in vimc_ipa_interface.h\n>> generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA\n>> and pipeline handler as deemed redundant.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/ipa/vimc/vimc.cpp | 1 -\n>> src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n>> 2 files changed, 2 deletions(-)\n>>\n>> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n>> index ebd63fa6..766e9c9c 100644\n>> --- a/src/ipa/vimc/vimc.cpp\n>> +++ b/src/ipa/vimc/vimc.cpp\n>> @@ -16,7 +16,6 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> #include \n> Where's #include , and why isn't it\n> here?\n\nIt is at the top of the file.\nhttps://git.libcamera.org/libcamera/libcamera.git/tree/src/ipa/vimc/vimc.cpp#n7\n\nShould be a candidate for indentation fix\n\n>> \n>> #include \"libcamera/internal/mapped_framebuffer.h\"\n>> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n>> index 0ec9928e..838a9355 100644\n>> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n>> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n>> @@ -24,7 +24,6 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> #include \n>> #include \n>\n> Otherwise,\n>\n> Reviewed-by: Kieran Bingham \n>\n>\n>> #include \n>> -- \n>> 2.44.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B124BEFBE\n\tfor ;\n\tMon, 1 Jul 2024 13:08:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4515662E23;\n\tMon, 1 Jul 2024 15:08:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E3A9604C1\n\tfor ;\n\tMon, 1 Jul 2024 15:08:35 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBA7F63D;\n\tMon, 1 Jul 2024 15:08:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vK9lfeWl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719839288;\n\tbh=F8OfWyJ5fNHhL6RyUMFKxy9XnEi6Rm0PFPb29ts6jHw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=vK9lfeWlpVdmSTrQtHLMkSdA1dWrQrX9Nj0ew2gGQogiQ0YIycMsMimz3XpiiAdZ5\n\tpZSphr01hgZaY0t8xZ+AccY5RyVhWXqhijA1/NQ5hTlPHfWrv2gDMpxnED2f5jL1kr\n\tGdzw3yTgbMnKvysnDzuVd6/hH8Xdvb3ZVBJajZ8c=","Message-ID":"","Date":"Mon, 1 Jul 2024 18:38:30 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-4-umang.jain@ideasonboard.com>\n\t<171982733115.392292.17501396274279226113@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<171982733115.392292.17501396274279226113@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]