[{"id":30171,"web_url":"https://patchwork.libcamera.org/comment/30171/","msgid":"<87frst7abk.fsf@redhat.com>","date":"2024-07-01T09:03:59","subject":"Re: [PATCH 2/4] libcamera: ipa: ipu3: Drop ipa_interface.h header","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Umang Jain writes:\n\n> The ipa_interface.h header is already included in ipu3_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.\n>\n> Signed-off-by: Umang Jain \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index cdcdf1fb..dca07970 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -24,7 +24,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8D63BEFBE\n\tfor ;\n\tMon, 1 Jul 2024 09:04:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D68062C99;\n\tMon, 1 Jul 2024 11:04:06 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE6F8619C9\n\tfor ;\n\tMon, 1 Jul 2024 11:04:04 +0200 (CEST)","from mail-ej1-f70.google.com (mail-ej1-f70.google.com\n\t[209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-625-PyxpN8dZM8SJHFzCOE8gDA-1; Mon, 01 Jul 2024 05:04:02 -0400","by mail-ej1-f70.google.com with SMTP id\n\ta640c23a62f3a-a751eb024abso42344966b.0\n\tfor ;\n\tMon, 01 Jul 2024 02:04:02 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-58614e45bcasm4113942a12.62.2024.07.01.02.03.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Jul 2024 02:04:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"F5xUgvKW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719824643;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Zg2ufLgmi856ZTjbSHZw7WdFI0Hv4PH9o2zIRNlDvkQ=;\n\tb=F5xUgvKWisYlXfBgauGztmQTzZklJH7fb0iNQXqOCLyTdaAqYSAY0nJ0oNLyCEF4o3GiM2\n\tAOzwy4SdpTRIXZxrlgbtTFVL4QJMwLy+5VFkoXLKAr5T67ya6pety/kxQZtxDeI9r865RL\n\tKr9quFpoq/gEmEGNjAWbT2D4dvAOfh8=","X-MC-Unique":"PyxpN8dZM8SJHFzCOE8gDA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1719824641; x=1720429441;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Zg2ufLgmi856ZTjbSHZw7WdFI0Hv4PH9o2zIRNlDvkQ=;\n\tb=iTqY9lkXucJT2wDI08Lqr6TkRofdQ2i/OfhFjxW7FndeR4/9/UsgGMC+cuqjbVlf1t\n\t9AEoLGc8S+pQyUkzwM448lPQFRc1fLURvpNpimfIRfSspQM0abst/LfdcIxCEKSJ5osy\n\tchJZpCdCIY2f+OVqLVRmFbP04PLTGAGTTzkj/ZGgPhoX68ktVg7yuunMfqVn/R1kVTlW\n\t5+9mO/wrmHhk5oq7A5eyS/Q7V3zG4Vj5z/UN/nTxuMss4O2ClYSYI/CCz49+0PW5UsCm\n\tYdwvPDCXMB+C6j45mg5LoE0b8N004dpK/KjXZ7WzTpRIZ2WpcOfGuPtyd48l7P13OXei\n\t2RGA==","X-Gm-Message-State":"AOJu0Yx6JIIvRMXCqoys4QmJ4rqROxTdC/wNH8/ACEwqvmVszQtg7zFO\n\tWyomUk6ULv5dRPowtQFkgAPCbNgpcQ10YP7S/8zoY7Xt738tRjOIV+kwtxCG+qmVVtwuvwaiXIs\n\trpN+aQiWXgeu4FpleNhLdDfwaW/GQhDdi3HOuG2kaVLj87EHo6vV5kxiEKoyFBoBbDn2qc9Ftsx\n\tiYMTnEwQQoybY5lTvmL0AMXtQ2nYw/nfoy8IB/w14OMHn18b+HnvMMJYc=","X-Received":["by 2002:a05:6402:11d1:b0:57c:71ca:f651 with SMTP id\n\t4fb4d7f45d1cf-5879f69b492mr4144989a12.20.1719824640832; \n\tMon, 01 Jul 2024 02:04:00 -0700 (PDT)","by 2002:a05:6402:11d1:b0:57c:71ca:f651 with SMTP id\n\t4fb4d7f45d1cf-5879f69b492mr4144974a12.20.1719824640516; \n\tMon, 01 Jul 2024 02:04:00 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGWVUK/mmzxHW7STQLwj6kVtlJxhEM2b1FMOQLTvpntarZcstuSAjqJUXGA0TwEPmrs1k1l+Q==","From":"Milan Zamazal ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/4] libcamera: ipa: ipu3: Drop ipa_interface.h header","In-Reply-To":"<20240701075720.46076-3-umang.jain@ideasonboard.com> (Umang\n\tJain's message of \"Mon, 1 Jul 2024 13:27:18 +0530\")","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-3-umang.jain@ideasonboard.com>","Date":"Mon, 01 Jul 2024 11:03:59 +0200","Message-ID":"<87frst7abk.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30176,"web_url":"https://patchwork.libcamera.org/comment/30176/","msgid":"<171982723882.392292.13885085510627558433@ping.linuxembedded.co.uk>","date":"2024-07-01T09:47:18","subject":"Re: [PATCH 2/4] libcamera: ipa: ipu3: Drop ipa_interface.h header","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-07-01 08:57:18)\n> The ipa_interface.h header is already included in ipu3_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/ipu3/ipu3.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index cdcdf1fb..dca07970 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -24,7 +24,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n\nIndeed, this is the interface!\n\n\nReviewed-by: Kieran Bingham \n\n> #include \n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3E81BEFBE\n\tfor ;\n\tMon, 1 Jul 2024 09:47:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89ACE62C9B;\n\tMon, 1 Jul 2024 11:47:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82F63619C9\n\tfor ;\n\tMon, 1 Jul 2024 11:47:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E405C289;\n\tMon, 1 Jul 2024 11:46:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tS9MUZCl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719827215;\n\tbh=EqrttAqIqPu0g4ojYyChKz/witSjw/ElSQX07Cpf02Q=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tS9MUZClH9Uv0K8QX6tGJpg24ZVxhVPAudyY1a6xJD66DIuIplVMDvpxzooEGGghl\n\tpj+uxLqiiWwaGeHN/AKOVJZ+iDeq2FCFsVn8pnhsYHjeWVwhdZSipPTcQKd6GPgZmF\n\tTY0TH9mAPoPIdQdFHz/tUcofOh3X+xcq8QZMEF/E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240701075720.46076-3-umang.jain@ideasonboard.com>","References":"<20240701075720.46076-1-umang.jain@ideasonboard.com>\n\t<20240701075720.46076-3-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 2/4] libcamera: ipa: ipu3: Drop ipa_interface.h header","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 01 Jul 2024 10:47:18 +0100","Message-ID":"<171982723882.392292.13885085510627558433@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]