[{"id":30163,"web_url":"https://patchwork.libcamera.org/comment/30163/","msgid":"","date":"2024-06-30T04:55:51","subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 29/06/24 3:05 am, Laurent Pinchart wrote:\n> The 16-bit padded raw 10 and raw 12 formats are stored in memory in\n> little endian order, regardless of the machine's endianness. Swap the\n> 16-bit values on big-endian machines when reading pixels from memory to\n> generate thumbnails.\n>\n> Signed-off-by: Laurent Pinchart \n\nLGTM,\n\nReviewed-by: Umang Jain \n> ---\n> src/apps/common/dng_writer.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> index 9241f23fb806..50db5eb33c83 100644\n> --- a/src/apps/common/dng_writer.cpp\n> +++ b/src/apps/common/dng_writer.cpp\n> @@ -8,6 +8,7 @@\n> #include \"dng_writer.h\"\n> \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -185,7 +186,8 @@ void thumbScanlineRaw(const FormatInfo &info, void *output, const void *input,\n> \n> \t/* Simple averaging that produces greyscale RGB values. */\n> \tfor (unsigned int x = 0; x < width; x++) {\n> -\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n> +\t\tuint16_t value = (le16toh(in[0]) + le16toh(in[1]) +\n> +\t\t\t\t le16toh(in2[0]) + le16toh(in2[1])) >> 2;\n> \t\tvalue = value >> shift;\n> \t\t*out++ = value;\n> \t\t*out++ = value;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A131BD87C\n\tfor ;\n\tSun, 30 Jun 2024 04:56:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5020362C97;\n\tSun, 30 Jun 2024 06:55:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD678619C4\n\tfor ;\n\tSun, 30 Jun 2024 06:55:56 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 662604B0;\n\tSun, 30 Jun 2024 06:55:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nMULHql8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719723331;\n\tbh=9ysn4n8C1XhI+OQ6Cf4XVTPvfnj1LjfBAKjEk0rWHQE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=nMULHql88et39XMSFPEFGUaaaiKC+rufzqwKd8VtJ3VTjwv6rDKAjRNQVpscRLE1D\n\tosLY1l8Alp6lZtSOT1wAgOdUM0ndeS1nWT57ffzfFnhb1SUWHJzJ54iVZ0HQcFADX1\n\tyHJBvlSdiFvIm/PyFs2BIEn0Vq90dVqDVn95r8mg=","Message-ID":"","Date":"Sun, 30 Jun 2024 10:25:51 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240628213535.6906-1-laurent.pinchart@ideasonboard.com>\n\t<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30166,"web_url":"https://patchwork.libcamera.org/comment/30166/","msgid":"","date":"2024-07-01T07:21:08","subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn Sat, Jun 29, 2024 at 12:35:34AM +0300, Laurent Pinchart wrote:\n> The 16-bit padded raw 10 and raw 12 formats are stored in memory in\n> little endian order, regardless of the machine's endianness. Swap the\n> 16-bit values on big-endian machines when reading pixels from memory to\n> generate thumbnails.\n> \n> Signed-off-by: Laurent Pinchart \n\nSigned-off-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> src/apps/common/dng_writer.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> index 9241f23fb806..50db5eb33c83 100644\n> --- a/src/apps/common/dng_writer.cpp\n> +++ b/src/apps/common/dng_writer.cpp\n> @@ -8,6 +8,7 @@\n> #include \"dng_writer.h\"\n> \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -185,7 +186,8 @@ void thumbScanlineRaw(const FormatInfo &info, void *output, const void *input,\n> \n> \t/* Simple averaging that produces greyscale RGB values. */\n> \tfor (unsigned int x = 0; x < width; x++) {\n> -\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n> +\t\tuint16_t value = (le16toh(in[0]) + le16toh(in[1]) +\n> +\t\t\t\t le16toh(in2[0]) + le16toh(in2[1])) >> 2;\n> \t\tvalue = value >> shift;\n> \t\t*out++ = value;\n> \t\t*out++ = value;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B3B0BEFBE\n\tfor ;\n\tMon, 1 Jul 2024 07:21:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5C9462C95;\n\tMon, 1 Jul 2024 09:21:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8F16619C9\n\tfor ;\n\tMon, 1 Jul 2024 09:21:11 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:89b2:f6c7:b29b:4e5c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3667F289;\n\tMon, 1 Jul 2024 09:20:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jlcumgf1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719818445;\n\tbh=VhxhhKIZ/ENDVOCRo9YA+QjGsIuryTjuzNr5jHyFkDI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jlcumgf1B3ZDNlFvDxrXvirFL234idvF8cujVE04UcG9WEALkBjrOIb7FGkLx35WD\n\til1A4k/sSw8QAnC0237x/rl3YXRI8JQBXDXKaoPz7NVbgxL5h2zallyWHomDP2NIZJ\n\t/UtVFz89YrD7DQW9q1znDUn51mA+UIkHMm2GqfxQ=","Date":"Mon, 1 Jul 2024 09:21:08 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","Message-ID":"","References":"<20240628213535.6906-1-laurent.pinchart@ideasonboard.com>\n\t<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30167,"web_url":"https://patchwork.libcamera.org/comment/30167/","msgid":"<20240701072906.GC15391@pendragon.ideasonboard.com>","date":"2024-07-01T07:29:06","subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jul 01, 2024 at 09:21:08AM +0200, Stefan Klug wrote:\n> Hi Laurent,\n> \n> Thanks for the patch.\n> \n> On Sat, Jun 29, 2024 at 12:35:34AM +0300, Laurent Pinchart wrote:\n> > The 16-bit padded raw 10 and raw 12 formats are stored in memory in\n> > little endian order, regardless of the machine's endianness. Swap the\n> > 16-bit values on big-endian machines when reading pixels from memory to\n> > generate thumbnails.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Signed-off-by: Stefan Klug \n\nDid you mean Reviewed-by ?\n\n> > ---\n> > src/apps/common/dng_writer.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> > index 9241f23fb806..50db5eb33c83 100644\n> > --- a/src/apps/common/dng_writer.cpp\n> > +++ b/src/apps/common/dng_writer.cpp\n> > @@ -8,6 +8,7 @@\n> > #include \"dng_writer.h\"\n> > \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > @@ -185,7 +186,8 @@ void thumbScanlineRaw(const FormatInfo &info, void *output, const void *input,\n> > \n> > \t/* Simple averaging that produces greyscale RGB values. */\n> > \tfor (unsigned int x = 0; x < width; x++) {\n> > -\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n> > +\t\tuint16_t value = (le16toh(in[0]) + le16toh(in[1]) +\n> > +\t\t\t\t le16toh(in2[0]) + le16toh(in2[1])) >> 2;\n> > \t\tvalue = value >> shift;\n> > \t\t*out++ = value;\n> > \t\t*out++ = value;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF34ABD87C\n\tfor ;\n\tMon, 1 Jul 2024 07:29:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FBE362C95;\n\tMon, 1 Jul 2024 09:29:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDAE7619C9\n\tfor ;\n\tMon, 1 Jul 2024 09:29:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D959289;\n\tMon, 1 Jul 2024 09:29:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YPifaFNC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719818941;\n\tbh=fBlW8HKTh2oLcwGXger3OxUT17Eu7GMtnLTxRNnXvL8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YPifaFNCDjHB7ErCUAMn4fIyjs9l9PPDKh/Qu/QLHylwykxlJqlWTiiFhCwz0qpf0\n\tZ8yuMDisROH2DWjZmh9fcq25KQIX/oKr3JqGqvjEyQ+4NzOe1QLxNJxmtYRvZMdkch\n\tyEF909Keq5TCWy/QnicNexCEhU+rafCUPBpdB+Dg=","Date":"Mon, 1 Jul 2024 10:29:06 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","Message-ID":"<20240701072906.GC15391@pendragon.ideasonboard.com>","References":"<20240628213535.6906-1-laurent.pinchart@ideasonboard.com>\n\t<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30169,"web_url":"https://patchwork.libcamera.org/comment/30169/","msgid":"","date":"2024-07-01T08:35:21","subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"On Mon, Jul 01, 2024 at 10:29:06AM +0300, Laurent Pinchart wrote:\n> On Mon, Jul 01, 2024 at 09:21:08AM +0200, Stefan Klug wrote:\n> > Hi Laurent,\n> > \n> > Thanks for the patch.\n> > \n> > On Sat, Jun 29, 2024 at 12:35:34AM +0300, Laurent Pinchart wrote:\n> > > The 16-bit padded raw 10 and raw 12 formats are stored in memory in\n> > > little endian order, regardless of the machine's endianness. Swap the\n> > > 16-bit values on big-endian machines when reading pixels from memory to\n> > > generate thumbnails.\n> > > \n> > > Signed-off-by: Laurent Pinchart \n> > \n> > Signed-off-by: Stefan Klug \n> \n> Did you mean Reviewed-by ?\n\nOh, monday morning... yes, that was meant to be\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> \n> > > ---\n> > > src/apps/common/dng_writer.cpp | 4 +++-\n> > > 1 file changed, 3 insertions(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> > > index 9241f23fb806..50db5eb33c83 100644\n> > > --- a/src/apps/common/dng_writer.cpp\n> > > +++ b/src/apps/common/dng_writer.cpp\n> > > @@ -8,6 +8,7 @@\n> > > #include \"dng_writer.h\"\n> > > \n> > > #include \n> > > +#include \n> > > #include \n> > > #include \n> > > \n> > > @@ -185,7 +186,8 @@ void thumbScanlineRaw(const FormatInfo &info, void *output, const void *input,\n> > > \n> > > \t/* Simple averaging that produces greyscale RGB values. */\n> > > \tfor (unsigned int x = 0; x < width; x++) {\n> > > -\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n> > > +\t\tuint16_t value = (le16toh(in[0]) + le16toh(in[1]) +\n> > > +\t\t\t\t le16toh(in2[0]) + le16toh(in2[1])) >> 2;\n> > > \t\tvalue = value >> shift;\n> > > \t\t*out++ = value;\n> > > \t\t*out++ = value;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DD7CBEFBE\n\tfor ;\n\tMon, 1 Jul 2024 08:35:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17CC162C99;\n\tMon, 1 Jul 2024 10:35:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 253EF619C9\n\tfor ;\n\tMon, 1 Jul 2024 10:35:24 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:89b2:f6c7:b29b:4e5c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41F5763D;\n\tMon, 1 Jul 2024 10:34:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mtyW9mFr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719822897;\n\tbh=L00CQBejDI2B/0WerM3mqRTqUp5fLwmrNvPrK4z2ITc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mtyW9mFrjEODVc53SLCUtX5dHT9+4vemPC2ReduGugjnlLTXBskijslsfKhle9iAt\n\tPg+GxfL58yWhZFySo8xrmtyXLZPkxWzuZI4GBDRwcvN6SqwTVUJG4JNTpvlBNc90dT\n\tvdjhGVPDw+rc4zajfz1+QaM0Zo1clKcV+G9X7BCs=","Date":"Mon, 1 Jul 2024 10:35:21 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] apps: common: dng_writer: Fix thumbnail generation\n\ton BE machines","Message-ID":"","References":"<20240628213535.6906-1-laurent.pinchart@ideasonboard.com>\n\t<20240628213535.6906-2-laurent.pinchart@ideasonboard.com>\n\t\n\t<20240701072906.GC15391@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240701072906.GC15391@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]