[{"id":30149,"web_url":"https://patchwork.libcamera.org/comment/30149/","msgid":"<20240629011248.GW30900@pendragon.ideasonboard.com>","date":"2024-06-29T01:12:48","subject":"Re: [PATCH v2 25/25] libtuning: agc: rkisp1: Increase y-target","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:18PM +0200, Stefan Klug wrote:\n> With the addition of gamma out correction the relative luminance target\n> was set too low. As brightness is a bit subjective it is difficult to\n> come up with the \"correct\" value. With 0.5 the patch 22 on the mac beth\n> chart (neutral grey, 18% reflectance) ended up a bit below 50% grey,\n> which seems reasonable.\n> \n> Signed-off-by: Stefan Klug \n\nLet's start with that, we'll improve it later.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> index 19a5555b6111..7147028a774a 100644\n> --- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n> +++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> @@ -64,7 +64,7 @@ class AGCRkISP1(AGC):\n> return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}\n> \n> def _generate_y_target(self) -> list:\n> - return 0.16\n> + return 0.5\n> \n> def process(self, config: dict, images: list, outputs: dict) -> dict:\n> output = {}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4242CBD87C\n\tfor ;\n\tSat, 29 Jun 2024 01:13:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FCBC62C9A;\n\tSat, 29 Jun 2024 03:13:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66CC162C95\n\tfor ;\n\tSat, 29 Jun 2024 03:13:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18932720;\n\tSat, 29 Jun 2024 03:12:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SzeQ1nGU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719623564;\n\tbh=qoQ++GlkS7jnvR82nzimnh9M8NxeoZCP0altH0axIVY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SzeQ1nGUSFCfqbGDLuNXrw9N7lErnw6Jbod3WP0CO/G0OK9GnQrfTWuOR3dZazew0\n\tFb7QFGT5/nMley1gXTpD9G7Bo24I0LW0yKKZBB54G7D0MdkcgVzRXmHeI6YMVMFoG7\n\tBtq4ffQQIqUM7eAwFMOMGgrfR8DYNF8Az66GbLqk=","Date":"Sat, 29 Jun 2024 04:12:48 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 25/25] libtuning: agc: rkisp1: Increase y-target","Message-ID":"<20240629011248.GW30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-26-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-26-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]