[{"id":30146,"web_url":"https://patchwork.libcamera.org/comment/30146/","msgid":"<20240629002518.GT30900@pendragon.ideasonboard.com>","date":"2024-06-29T00:25:18","subject":"Re: [PATCH v2 22/25] libtuning: lsc: Prevent negative values","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:15PM +0200, Stefan Klug wrote:\n> In cases where the calibration image contains super dark areas, or when\n> an invalid blacklevel was supplied, the grid might get close to zero or\n> negative. This would have bad effects on the 1/grid later. So clamp the\n> values to a small positive number.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> utils/tuning/libtuning/modules/lsc/lsc.py | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/libtuning/modules/lsc/lsc.py b/utils/tuning/libtuning/modules/lsc/lsc.py\n> index 344a07a3d443..b6a24cf42874 100644\n> --- a/utils/tuning/libtuning/modules/lsc/lsc.py\n> +++ b/utils/tuning/libtuning/modules/lsc/lsc.py\n> @@ -59,7 +59,8 @@ class LSC(Module):\n> def _lsc_single_channel(self, channel: np.array,\n> image: lt.Image, green_grid: np.array = None):\n> grid = self._get_grid(channel, image.w, image.h)\n> - grid -= image.blacklevel_16\n> + grid = np.maximum(grid - image.blacklevel_16, 0.1)\n\nI think a comment would be useful.\n\nReviewed-by: Laurent Pinchart \n\nShould we detect during tuning if an image is too dark, and report a\nwarning or error out ?\n\n> +\n> if green_grid is None:\n> table = np.reshape(1 / grid, self.sector_shape[::-1])\n> else:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CCF5BD87C\n\tfor ;\n\tSat, 29 Jun 2024 00:25:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 844B162C9B;\n\tSat, 29 Jun 2024 02:25:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 467D662C95\n\tfor ;\n\tSat, 29 Jun 2024 02:25:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 126FB63B;\n\tSat, 29 Jun 2024 02:25:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pBV/8Z4r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719620715;\n\tbh=fME+ueh2gwSd/JTu88//eq8H72+9Gvu+I2VUFR+Jfz8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pBV/8Z4rpw870gLPL7DsOtCwTqp9LfNyczOeaAGly816w288t6cXNRtceJzQLj89c\n\tGQ3PmYSGpxEyckIMO/SRIK61Z3ztV/LFwM9FnX2N5MRrj/Gr0TdXPF+E9hlAlN1o6C\n\toXpy1u5XwYUSA2jO7l8mmD/hUCHubHt5oOgPeJBk=","Date":"Sat, 29 Jun 2024 03:25:18 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 22/25] libtuning: lsc: Prevent negative values","Message-ID":"<20240629002518.GT30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-23-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-23-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]