[{"id":30144,"web_url":"https://patchwork.libcamera.org/comment/30144/","msgid":"<20240629000812.GR30900@pendragon.ideasonboard.com>","date":"2024-06-29T00:08:12","subject":"Re: [PATCH v2 20/25] tuning: rkisp1: Add some static modules","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:13PM +0200, Stefan Klug wrote:\n> Add awb, gamma, cproc and filter by default to the tuning file. These\n> don't need any configuration.\n> \n> While at it, sort the modules alphabetically.\n\nIs alphabetical order right ? The CCM, for instance, should eventually\ndepend on LSC, and I would expect AWB to possibly depend on LSC too. Can\nwe already prepare for that ? Or should we add a mechanism in the future\nfor modules to declare dependencies ?\n\n> Signed-off-by: Stefan Klug \n> ---\n> utils/tuning/rkisp1.py | 18 ++++++++++++++----\n> 1 file changed, 14 insertions(+), 4 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index fae35783c656..c5036c65557b 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -15,11 +15,22 @@ from libtuning.generators import YamlOutput\n> from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> from libtuning.modules.ccm import CCMRkISP1\n> -\n> +from libtuning.modules.static import StaticModule\n> \n> coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> \n> +awb = StaticModule('Awb')\n> +color_processing = StaticModule('ColorProcessing')\n> +filter = StaticModule('Filter')\n> +gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n> +\n> tuner = lt.Tuner('RkISP1')\n> +tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n> +tuner.add(awb)\n> +tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n> +tuner.add(color_processing)\n> +tuner.add(filter)\n> +tuner.add(gamma_out)\n> tuner.add(LSCRkISP1(\n> debug=[lt.Debug.Plot],\n> # This is for the actual LSC tuning, and is part of the base LSC\n> @@ -39,11 +50,10 @@ tuner.add(LSCRkISP1(\n> # values. This can also be a custom function.\n> smoothing_function=lt.smoothing.MedianBlur(3),\n> ))\n> -tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n> -tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n> +\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> -tuner.set_output_order([AGCRkISP1, CCMRkISP1, LSCRkISP1])\n> +tuner.set_output_order([AGCRkISP1, awb, CCMRkISP1, color_processing, filter, gamma_out, LSCRkISP1])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3254CBD87C\n\tfor ;\n\tSat, 29 Jun 2024 00:08:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 038A662C9B;\n\tSat, 29 Jun 2024 02:08:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EB3E62C95\n\tfor ;\n\tSat, 29 Jun 2024 02:08:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6699E63B;\n\tSat, 29 Jun 2024 02:08:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QaNPkeMG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719619688;\n\tbh=YPFgctFfII6Bn903aZ116gLsPjBCNfZmOLk2cB7hk78=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QaNPkeMGgP0P2ietSPl/07cGMJN+aWmuTsYlQM2JHrYzl8MBeXzlMVYTvRSMTaoMK\n\tq2IPyu/lMrGICm9wlMKJexWmI2MMJxm1PCTFYHhbA6kfIzwGDGua+GEB6zsGCA4heO\n\tD8l2uNtp2fv6uEn+DvOv3R+cwSlRHb9Mcsl4GwiY=","Date":"Sat, 29 Jun 2024 03:08:12 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 20/25] tuning: rkisp1: Add some static modules","Message-ID":"<20240629000812.GR30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-21-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-21-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30202,"web_url":"https://patchwork.libcamera.org/comment/30202/","msgid":"","date":"2024-07-02T10:08:35","subject":"Re: [PATCH v2 20/25] tuning: rkisp1: Add some static modules","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sat, Jun 29, 2024 at 03:08:12AM +0300, Laurent Pinchart wrote:\n> Hi Stefan,\n> \n> Thank you for the patch.\n> \n> On Fri, Jun 28, 2024 at 12:47:13PM +0200, Stefan Klug wrote:\n> > Add awb, gamma, cproc and filter by default to the tuning file. These\n> > don't need any configuration.\n> > \n> > While at it, sort the modules alphabetically.\n> \n> Is alphabetical order right ? The CCM, for instance, should eventually\n> depend on LSC, and I would expect AWB to possibly depend on LSC too. Can\n> we already prepare for that ? Or should we add a mechanism in the future\n> for modules to declare dependencies ?\n\nI'd like to keep it sorted for now. We don't have dependencies at the\nmoment. As soon as we add the first dependency (ccm -> lsc) the issue\nwill pop up and needs to be solved (and I'd like to introduce some kind\nof dependency mechanism instead of a knowing the order beforehand)\n\nBest regards,\nStefan\n\n> \n> > Signed-off-by: Stefan Klug \n> > ---\n> > utils/tuning/rkisp1.py | 18 ++++++++++++++----\n> > 1 file changed, 14 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> > index fae35783c656..c5036c65557b 100755\n> > --- a/utils/tuning/rkisp1.py\n> > +++ b/utils/tuning/rkisp1.py\n> > @@ -15,11 +15,22 @@ from libtuning.generators import YamlOutput\n> > from libtuning.modules.lsc import LSCRkISP1\n> > from libtuning.modules.agc import AGCRkISP1\n> > from libtuning.modules.ccm import CCMRkISP1\n> > -\n> > +from libtuning.modules.static import StaticModule\n> > \n> > coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> > \n> > +awb = StaticModule('Awb')\n> > +color_processing = StaticModule('ColorProcessing')\n> > +filter = StaticModule('Filter')\n> > +gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n> > +\n> > tuner = lt.Tuner('RkISP1')\n> > +tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n> > +tuner.add(awb)\n> > +tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n> > +tuner.add(color_processing)\n> > +tuner.add(filter)\n> > +tuner.add(gamma_out)\n> > tuner.add(LSCRkISP1(\n> > debug=[lt.Debug.Plot],\n> > # This is for the actual LSC tuning, and is part of the base LSC\n> > @@ -39,11 +50,10 @@ tuner.add(LSCRkISP1(\n> > # values. This can also be a custom function.\n> > smoothing_function=lt.smoothing.MedianBlur(3),\n> > ))\n> > -tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n> > -tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n> > +\n> > tuner.set_input_parser(YamlParser())\n> > tuner.set_output_formatter(YamlOutput())\n> > -tuner.set_output_order([AGCRkISP1, CCMRkISP1, LSCRkISP1])\n> > +tuner.set_output_order([AGCRkISP1, awb, CCMRkISP1, color_processing, filter, gamma_out, LSCRkISP1])\n> > \n> > if __name__ == '__main__':\n> > sys.exit(tuner.run(sys.argv))\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19AC4BEFBE\n\tfor ;\n\tTue, 2 Jul 2024 10:08:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A6D462C96;\n\tTue, 2 Jul 2024 12:08:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AD58619CC\n\tfor ;\n\tTue, 2 Jul 2024 12:08:38 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:15de:d83a:d962:e44])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FD505A4;\n\tTue, 2 Jul 2024 12:08:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i4yCHbqU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719914891;\n\tbh=yaQCqNFT+Gy5U9L3ScQZEjCW9FRpuHasc/8yXc/S6I0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i4yCHbqUm3o4AatuaJvci2akKWFnE/pjVEopbUY7o6nI/1aAv8uuQV2MSHZ4KLjob\n\t/J3iQDI2iXoeFlCxhs46mG/aG5kP9ryRvUZCx9pJjZRUnVgAJpm4ynzFNZgNJGf8eN\n\t66Vd4QFXLSeb/W2emhU3Ng3WXzEPfVE6xhC5Z3YA=","Date":"Tue, 2 Jul 2024 12:08:35 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 20/25] tuning: rkisp1: Add some static modules","Message-ID":"","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-21-stefan.klug@ideasonboard.com>\n\t<20240629000812.GR30900@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240629000812.GR30900@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]