[{"id":30142,"web_url":"https://patchwork.libcamera.org/comment/30142/","msgid":"<20240629000226.GP30900@pendragon.ideasonboard.com>","date":"2024-06-29T00:02:26","subject":"Re: [PATCH v2 18/25] libtuning: agc: Fix kwargs handling","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:11PM +0200, Stefan Klug wrote:\n\nThis needs a commit message.\n\n> Signed-off-by: Stefan Klug \n> \n> ---\n> utils/tuning/libtuning/modules/agc/agc.py | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/modules/agc/agc.py b/utils/tuning/libtuning/modules/agc/agc.py\n> index 9c8899badc79..3631540844bc 100644\n> --- a/utils/tuning/libtuning/modules/agc/agc.py\n> +++ b/utils/tuning/libtuning/modules/agc/agc.py\n> @@ -14,8 +14,7 @@ class AGC(Module):\n> out_name = 'GenericAGC'\n> \n> # \\todo Add sector shapes and stuff just like lsc\n> - def __init__(self, *,\n> - debug: list):\n> + def __init__(self, debug: list):\n> super().__init__()\n> \n> self.debug = debug","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5DC3BDB1D\n\tfor ;\n\tSat, 29 Jun 2024 00:02:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7294C62C9B;\n\tSat, 29 Jun 2024 02:02:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 173E662C95\n\tfor ;\n\tSat, 29 Jun 2024 02:02:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1631163B;\n\tSat, 29 Jun 2024 02:02:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H4Dbfdac\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719619342;\n\tbh=1tUkosbFTp7G7hgUIyeyRlc7r1ODim0ZY2ramxQh+Ig=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H4DbfdacSlfBkXMyMQPge2fWGRLrOOvvlVkXETWVd+FWU0nU/dFA3YDNWABoGB9pK\n\tNA6sXX7ENB6GgtFW9PSYxvOY6i7cXMuZr02K6Qnd+u77D2JsSVGTLIFAKYJceK4swX\n\t3tzfKBmu2KWqG8yyaeI2OUEjJQNLNLVhjuHuPq2I=","Date":"Sat, 29 Jun 2024 03:02:26 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 18/25] libtuning: agc: Fix kwargs handling","Message-ID":"<20240629000226.GP30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-19-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-19-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]