[{"id":30140,"web_url":"https://patchwork.libcamera.org/comment/30140/","msgid":"<20240628235154.GN30900@pendragon.ideasonboard.com>","date":"2024-06-28T23:51:54","subject":"Re: [PATCH v2 16/25] libtuning: Handle cases, where no lsc tuning\n\timages are present","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:09PM +0200, Stefan Klug wrote:\n> Make it clear that no lsc calibration was done by returning None instead\n> of a incomplete configuration.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n> index 074f3b272dbf..5874f10c936f 100644\n> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py\n> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n> @@ -107,6 +107,9 @@ class LSCRkISP1(LSC):\n> \n> output['sets'] = self._do_all_lsc(images)\n> \n> + if len(output['sets']) == 0:\n> + return None\n> +\n> # \\todo Validate images from greyscale camera and force grescale mode\n> # \\todo Debug functionality\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4946BD87C\n\tfor ;\n\tFri, 28 Jun 2024 23:52:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EC6B62C9B;\n\tSat, 29 Jun 2024 01:52:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD6362C95\n\tfor ;\n\tSat, 29 Jun 2024 01:52:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DA2A63B;\n\tSat, 29 Jun 2024 01:51:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S/nD2nZP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719618710;\n\tbh=f7RYMAzWwcR0JaGCmWyytq6/it/9sBcjlbGiVwKPxBo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=S/nD2nZPP44Xyrnah6ZANlCDsm4WLAgxYis+U3hZcPC1J1EAl2vXWtMagd6v8+cMR\n\tKvB6L3rvbOMiREn2UFlS0bNBMVXX3jhatctSa/UySijvSqt+926kVxXHe4Zc+i6i9h\n\tL/qXDxYbceM/higdtPrQAcrO2fWwOjlF9ZPOR96k=","Date":"Sat, 29 Jun 2024 02:51:54 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 16/25] libtuning: Handle cases, where no lsc tuning\n\timages are present","Message-ID":"<20240628235154.GN30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-17-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-17-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]