{"id":20475,"url":"https://patchwork.libcamera.org/api/patches/20475/?format=json","web_url":"https://patchwork.libcamera.org/patch/20475/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240628104828.2928109-17-stefan.klug@ideasonboard.com>","date":"2024-06-28T10:47:09","name":"[v2,16/25] libtuning: Handle cases, where no lsc tuning images are present","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9b361da399bcd7f47d0f77bc025ffe08a6393ec4","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20475/mbox/","series":[{"id":4430,"url":"https://patchwork.libcamera.org/api/series/4430/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4430","date":"2024-06-28T10:46:53","name":"Add ccm calibration to libtuning","version":2,"mbox":"https://patchwork.libcamera.org/series/4430/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20475/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20475/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B03CBD87C\n\tfor ;\n\tFri, 28 Jun 2024 10:49:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1769B63354;\n\tFri, 28 Jun 2024 12:49:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 505B762E24\n\tfor ;\n\tFri, 28 Jun 2024 12:49:25 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7D57BEB;\n\tFri, 28 Jun 2024 12:49:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IYDjGSxR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571740;\n\tbh=vMMywYb3VDUDCewQQhr5KT8msxDt1ghhMBYeyy7zrIU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IYDjGSxRgKgwSUfQjtkNlq2ruBz2ubPMFqCu9T22FadcIKpkznJDyNZoj4f4UBSYt\n\tAzpwg9SadCvxGFjnlPY+zTs0cezpYO718BrJ7234+h6aEptuFoi/k3Y3IYEgQhB42c\n\tr/NNIj3yXnyzdjXPYT7qBawQ0cUZeUuynBDXP/aE=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 16/25] libtuning: Handle cases,\n\twhere no lsc tuning images are present","Date":"Fri, 28 Jun 2024 12:47:09 +0200","Message-ID":"<20240628104828.2928109-17-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make it clear that no lsc calibration was done by returning None instead\nof a incomplete configuration.\n\nSigned-off-by: Stefan Klug \n---\n utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py\nindex 074f3b272dbf..5874f10c936f 100644\n--- a/utils/tuning/libtuning/modules/lsc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n@@ -107,6 +107,9 @@ class LSCRkISP1(LSC):\n \n output['sets'] = self._do_all_lsc(images)\n \n+ if len(output['sets']) == 0:\n+ return None\n+\n # \\todo Validate images from greyscale camera and force grescale mode\n # \\todo Debug functionality\n \n","prefixes":["v2","16/25"]}