[{"id":30138,"web_url":"https://patchwork.libcamera.org/comment/30138/","msgid":"<20240628232710.GL30900@pendragon.ideasonboard.com>","date":"2024-06-28T23:27:10","subject":"Re: [PATCH v2 14/25] libtuning: Remove need for Cam object from ccm","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:07PM +0200, Stefan Klug wrote:\n> Remove the need for the Cam object, as we don't want to port\n> it from raspberry pi.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tuning/libtuning/ctt_ccm.py | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/ctt_ccm.py b/utils/tuning/libtuning/ctt_ccm.py\n> index 086ef8a2580b..2e87a6679f20 100644\n> --- a/utils/tuning/libtuning/ctt_ccm.py\n> +++ b/utils/tuning/libtuning/ctt_ccm.py\n> @@ -62,9 +62,8 @@ FInds colour correction matrices for list of images\n> \"\"\"\n> \n> \n> -def ccm(Cam, cal_cr_list, cal_cb_list):\n> +def ccm(imgs, cal_cr_list, cal_cb_list):\n> global matrix_selection_types, typenum\n> - imgs = Cam.imgs\n> \"\"\"\n> standard macbeth chart colour values\n> \"\"\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E89D9BDB1D\n\tfor ;\n\tFri, 28 Jun 2024 23:27:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54916619E8;\n\tSat, 29 Jun 2024 01:27:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C92B619E8\n\tfor ;\n\tSat, 29 Jun 2024 01:27:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D4A463B;\n\tSat, 29 Jun 2024 01:27:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iRUYZEkp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719617226;\n\tbh=fZgsWOriRg0S04qoZcrFiOTbVC/esGhrbDfofZag2aM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iRUYZEkpXdIGNE/OjJpsn0Rr0CzNGD5dU1/kEa9xoFiSip+JYCp0U1wy2NpBQqQEH\n\tqaVpBDqax/GCJlEmSCK1T+wLoFs+5U824ZiIvFPVhw9qAwI+G4vbcEtelqpHaQGjD8\n\tIkhwS4cfl2xU8whFftQgzlp/777bmICzBpqDsX4w=","Date":"Sat, 29 Jun 2024 02:27:10 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 14/25] libtuning: Remove need for Cam object from ccm","Message-ID":"<20240628232710.GL30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-15-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-15-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]