[{"id":30132,"web_url":"https://patchwork.libcamera.org/comment/30132/","msgid":"<20240628224953.GF30900@pendragon.ideasonboard.com>","date":"2024-06-28T22:49:53","subject":"Re: [PATCH v2 08/25] libtuning: Fix visualize_macbeth_chart()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:47:01PM +0200, Stefan Klug wrote:\n> The old function uses PIL to save the image, which is not in the\n> requirements file. As we are already requiring opencv, use that to save\n> images instead of an additional dependency\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Paul Elder \n> ---\n> utils/tuning/libtuning/utils.py | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py\n> index 872341407b7b..178c6957c581 100644\n> --- a/utils/tuning/libtuning/utils.py\n> +++ b/utils/tuning/libtuning/utils.py\n> @@ -7,6 +7,7 @@\n> \n> import decimal\n> import math\n> +import cv2\n\nAlphabetic order.\n\n> import numpy as np\n> import os\n> from pathlib import Path\n> @@ -162,6 +163,6 @@ def visualise_macbeth_chart(macbeth_rgb, original_rgb, new_rgb, output_filename)\n> for g in range(100):\n> image[xlocation + i, ylocation + g] = new_rgb[colorindex]\n> \n> - img = Image.fromarray(image, 'RGB')\n> - img.save(str(output_filename) + 'Generated Macbeth Chart.png')\n> + im_bgr = cv2.cvtColor(image, cv2.COLOR_RGB2BGR)\n> + cv2.imwrite(f'{output_filename} Generated Macbeth Chart.png', im_bgr)\n> \n\nAt some point we should create a better Image class that will handle all\nof this. At some point :-)\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFE96BDB1D\n\tfor ;\n\tFri, 28 Jun 2024 22:50:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC1CC62C9C;\n\tSat, 29 Jun 2024 00:50:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCA6E62C97\n\tfor ;\n\tSat, 29 Jun 2024 00:50:14 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4DA3471;\n\tSat, 29 Jun 2024 00:49:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fOWtjl7o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719614989;\n\tbh=xnTRixkJeftgYh3sMVHSdQESnbR8h1VAY4ncH3xkMFU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fOWtjl7oE3Bt9i/ljvoj1DU5kaFqX5eXLSsoFgfjTmHma69eFxBPVDrLtzyisab2+\n\tUzPwwqU3040et68Ak3X5m6z7ZqsmJ6KxAGSrKJnSeFv600B1Zy5wLys/qvrQKvRtKx\n\tDee4E+T9Gvw1IljwgS1xX1dDE9MmHfbnJzTj5RU4=","Date":"Sat, 29 Jun 2024 01:49:53 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ","Subject":"Re: [PATCH v2 08/25] libtuning: Fix visualize_macbeth_chart()","Message-ID":"<20240628224953.GF30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-9-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-9-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]