[{"id":30129,"web_url":"https://patchwork.libcamera.org/comment/30129/","msgid":"<20240628223522.GC30900@pendragon.ideasonboard.com>","date":"2024-06-28T22:35:22","subject":"Re: [PATCH v2 05/25] utils: tuning: Add requirements file and update\n\treadme","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Jun 28, 2024 at 12:46:58PM +0200, Stefan Klug wrote:\n> Add a requirements file to ease the installation and use of the tuning\n> scripts. Document that in the readme. No debian packages are provided as\n> rawpi is not packaged as deb. So pip has to be used anyways.\n\ns/rawpi/rawpy/\n\nLooks like Gentoo doesn't provide a package either :-(\n\n> Also add pyyaml which was missing in the dependencies.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> utils/tuning/README.rst | 23 ++++++++++++++++-------\n> utils/tuning/requirements.txt | 5 +++++\n> 2 files changed, 21 insertions(+), 7 deletions(-)\n> create mode 100644 utils/tuning/requirements.txt\n> \n> diff --git a/utils/tuning/README.rst b/utils/tuning/README.rst\n> index ef3e6ad76f1b..ef6dbe28f676 100644\n> --- a/utils/tuning/README.rst\n> +++ b/utils/tuning/README.rst\n> @@ -1,11 +1,20 @@\n> .. SPDX-License-Identifier: CC-BY-SA-4.0\n> \n> -.. TODO: Write an overview of libtuning\n> +Libcamera tuning tools\n\ns/Libcamera/libcamera/\n\nReviewed-by: Laurent Pinchart \n\n> +======================\n> \n> -Dependencies\n> -------------\n> +.. Note:: The tuning tool are still very much work in progress. If in doubt, \n> + please ask on the mailing list.\n> +\n> +.. todo::\n> + Write documentation\n> +\n> +Installation of dependencies\n> +----------------------------\n> +\n> +::\n> + # Using a venv\n> + python3 -m venv venv\n> + . ./venv/bin/activate\n> + pip3 install -r requirements.txt\n> \n> -- numpy\n> -- opencv-python\n> -- py3exiv2\n> -- rawpy\n> diff --git a/utils/tuning/requirements.txt b/utils/tuning/requirements.txt\n> new file mode 100644\n> index 000000000000..d1dc589d0329\n> --- /dev/null\n> +++ b/utils/tuning/requirements.txt\n> @@ -0,0 +1,5 @@\n> +numpy\n> +opencv-python\n> +py3exiv2\n> +pyyaml\n> +rawpy","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 712E9BD87C\n\tfor ;\n\tFri, 28 Jun 2024 22:35:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A525462C99;\n\tSat, 29 Jun 2024 00:35:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DE44619E8\n\tfor ;\n\tSat, 29 Jun 2024 00:35:43 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06D80471;\n\tSat, 29 Jun 2024 00:35:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LjKerf16\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719614118;\n\tbh=0SHIpBofXN75QEbY8GdGG1WKCkns6oPH5PHoVb+P7hk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LjKerf16jqRQJWQR4Aj+cviSOIfkxN4b1ftQstsiLfgEoWZ3MJ5nbae51aFpFc6YG\n\tm7+6ubnqGeDR33U+fAwMNq4Pcr3LWx5VflKrqjaaXgLY3rV80lEzzT1miASSD08Y1p\n\tFHpLg8AWHt6q/2uIw7r5KNh8Kek08LfYMPGnNUX8=","Date":"Sat, 29 Jun 2024 01:35:22 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 05/25] utils: tuning: Add requirements file and update\n\treadme","Message-ID":"<20240628223522.GC30900@pendragon.ideasonboard.com>","References":"<20240628104828.2928109-1-stefan.klug@ideasonboard.com>\n\t<20240628104828.2928109-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240628104828.2928109-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]