[{"id":30124,"web_url":"https://patchwork.libcamera.org/comment/30124/","msgid":"<7eb10856-f6b4-4b73-839f-2a3d15af6285@ideasonboard.com>","date":"2024-06-28T12:12:27","subject":"Re: [PATCH v2 1/3] apps: common: dng_writer: Rename packing\n\tfunctions","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 28/06/2024 11:01, Stefan Klug wrote:\n> The old names lead to confusions. Rename to better express the intent.\n>\n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n\n\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n\n>   src/apps/common/dng_writer.cpp | 74 +++++++++++++++++-----------------\n>   1 file changed, 37 insertions(+), 37 deletions(-)\n>\n> diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> index d37b0d627cd1..3b17dadc427f 100644\n> --- a/src/apps/common/dng_writer.cpp\n> +++ b/src/apps/common/dng_writer.cpp\n> @@ -128,7 +128,7 @@ struct Matrix3d {\n>   \n>   namespace {\n>   \n> -void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw8(void *output, const void *input, unsigned int width)\n>   {\n>   \tconst uint8_t *in = static_cast<const uint8_t *>(input);\n>   \tuint8_t *out = static_cast<uint8_t *>(output);\n> @@ -136,7 +136,7 @@ void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n>   \tstd::copy(in, in + width, out);\n>   }\n>   \n> -void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw16(void *output, const void *input, unsigned int width)\n>   {\n>   \tconst uint16_t *in = static_cast<const uint16_t *>(input);\n>   \tuint16_t *out = static_cast<uint16_t *>(output);\n> @@ -144,7 +144,7 @@ void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n>   \tstd::copy(in, in + width, out);\n>   }\n>   \n> -void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw10_CSI2P(void *output, const void *input, unsigned int width)\n>   {\n>   \tconst uint8_t *in = static_cast<const uint8_t *>(input);\n>   \tuint8_t *out = static_cast<uint8_t *>(output);\n> @@ -160,7 +160,7 @@ void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n>   \t}\n>   }\n>   \n> -void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw12_CSI2P(void *output, const void *input, unsigned int width)\n>   {\n>   \tconst uint8_t *in = static_cast<const uint8_t *>(input);\n>   \tuint8_t *out = static_cast<uint8_t *>(output);\n> @@ -174,7 +174,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n>   \t}\n>   }\n>   \n> -void thumbScanlineSBGGRxxP(const FormatInfo &info, void *output,\n> +void thumbScanlineRaw_CSI2P(const FormatInfo &info, void *output,\n>   \t\t\t   const void *input, unsigned int width,\n>   \t\t\t   unsigned int stride)\n>   {\n> @@ -296,98 +296,98 @@ const std::map<PixelFormat, FormatInfo> formatInfo = {\n>   \t{ formats::SBGGR8, {\n>   \t\t.bitsPerSample = 8,\n>   \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> -\t\t.packScanline = packScanlineSBGGR8,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw8,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGBRG8, {\n>   \t\t.bitsPerSample = 8,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR8,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw8,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGRBG8, {\n>   \t\t.bitsPerSample = 8,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR8,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw8,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SRGGB8, {\n>   \t\t.bitsPerSample = 8,\n>   \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> -\t\t.packScanline = packScanlineSBGGR8,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw8,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SBGGR16, {\n>   \t\t.bitsPerSample = 16,\n>   \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> -\t\t.packScanline = packScanlineSBGGR16,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw16,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGBRG16, {\n>   \t\t.bitsPerSample = 16,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR16,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw16,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGRBG16, {\n>   \t\t.bitsPerSample = 16,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR16,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw16,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SRGGB16, {\n>   \t\t.bitsPerSample = 16,\n>   \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> -\t\t.packScanline = packScanlineSBGGR16,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw16,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SBGGR10_CSI2P, {\n>   \t\t.bitsPerSample = 10,\n>   \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> -\t\t.packScanline = packScanlineSBGGR10P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw10_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGBRG10_CSI2P, {\n>   \t\t.bitsPerSample = 10,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR10P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw10_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGRBG10_CSI2P, {\n>   \t\t.bitsPerSample = 10,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR10P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw10_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SRGGB10_CSI2P, {\n>   \t\t.bitsPerSample = 10,\n>   \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> -\t\t.packScanline = packScanlineSBGGR10P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw10_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SBGGR12_CSI2P, {\n>   \t\t.bitsPerSample = 12,\n>   \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> -\t\t.packScanline = packScanlineSBGGR12P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw12_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGBRG12_CSI2P, {\n>   \t\t.bitsPerSample = 12,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR12P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw12_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SGRBG12_CSI2P, {\n>   \t\t.bitsPerSample = 12,\n>   \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> -\t\t.packScanline = packScanlineSBGGR12P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw12_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SRGGB12_CSI2P, {\n>   \t\t.bitsPerSample = 12,\n>   \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> -\t\t.packScanline = packScanlineSBGGR12P,\n> -\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> +\t\t.packScanline = packScanlineRaw12_CSI2P,\n> +\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n>   \t} },\n>   \t{ formats::SBGGR10_IPU3, {\n>   \t\t.bitsPerSample = 16,","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 292EFBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 12:12:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F99462C99;\n\tFri, 28 Jun 2024 14:12:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1B8D619E5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 14:12:34 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B34E4735\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 14:12:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cy3aqKxr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719576730;\n\tbh=bpxwFlUm6kLvxjwAM/K5HXKxjMDtSpzHr6266Iun/QI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Cy3aqKxrcYQc2YiIZY95rZNbl4z4kp2hBMDJeH2RIBbBmAQnHjJixI5jBRx65fAIn\n\tJmtekh5KCiLroj9MrmrFohqnKTMKWqE80bLWnhvoN1+6fJXKmAvEMN6/RpNAuEKqgE\n\t4/5a7cLI/E6MjOO0N3Y1uTJ9hWO9x3bO7Sypn248=","Message-ID":"<7eb10856-f6b4-4b73-839f-2a3d15af6285@ideasonboard.com>","Date":"Fri, 28 Jun 2024 13:12:27 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/3] apps: common: dng_writer: Rename packing\n\tfunctions","To":"libcamera-devel@lists.libcamera.org","References":"<20240628100227.2910842-1-stefan.klug@ideasonboard.com>\n\t<20240628100227.2910842-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally <dan.scally@ideasonboard.com>","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240628100227.2910842-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]