[{"id":30180,"web_url":"https://patchwork.libcamera.org/comment/30180/","msgid":"<171983025702.392292.2811597846431166557@ping.linuxembedded.co.uk>","date":"2024-07-01T10:37:37","subject":"Re: [PATCH 2/2] libcamera: simple: Log a missing sensor in a better\n\tway","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-06-27 18:33:05)\n> SimplePipelineHandler::match may be called several times for different\n> pipeline configurations. Not all of these calls must succeed. For\n> example, for TI AM69 board with a single camera attached, the following\n> error is reported in the log even when libcamera works fine:\n> \n> ERROR SimplePipeline simple.cpp:1558 No sensor found\n> \n> This is because a sensor is found for /dev/media0 but not for\n> /dev/media1. The error is harmless in such a case and only confuses\n> users who may think no camera is detected at all. Let's change the\n> error to info and add the device node to the message to indicate the\n> error is specific to the given media only. It's up to the callers to\n> report a fatal error condition if libcamera cannot work due to no\n> matching pipeline configuration.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index eb36578e..be0bb677 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1548,9 +1548,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> /* Locate the sensors. */\n> std::vector sensors = locateSensors();\n> if (sensors.empty()) {\n> - LOG(SimplePipeline, Error) << \"No sensor found\";\n> + LOG(SimplePipeline, Info) << \"No sensor found for \" << media_->deviceNode();\n> return false;\n> }\n> + LOG(SimplePipeline, Debug) << \"Sensor found for \" << media_->deviceNode();\n\nThese I like.\n\nReviewed-by: Kieran Bingham \n\n\nIs logPrefix defined for simple pipeline handler yet?\nmedia_->deviceNode() could be part of that perhaps (unless it's too\nlong) to make it clear /which/ media device is in use.\n\n> \n> /*\n> * Create one camera data instance for each sensor and gather all\n> -- \n> 2.44.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5087BD87C\n\tfor ;\n\tMon, 1 Jul 2024 10:37:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64D8C62C98;\n\tMon, 1 Jul 2024 12:37:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01F8D619C9\n\tfor ;\n\tMon, 1 Jul 2024 12:37:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 420CE63D;\n\tMon, 1 Jul 2024 12:37:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nb1o/p2C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719830233;\n\tbh=fLhrPARPytUlzFOxaszzFieiFSO9cWJvW9Vv2URq+UY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Nb1o/p2CEMdCY7JYZEa8A1+JCyUrUPp6Th/ezDllfk0LVcNOuOOg6Um7mo1Tj6d2V\n\ti4h9kEIgJmVW+j49b9MMgbD0shsRUqFbtcYNfddRqB80mfsprGrlfPpGNA/dIlXVpb\n\tbbkqwkRpK6aeUFMakChel0H1pghuymPwmJxy8Sug=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240627173305.1477718-3-mzamazal@redhat.com>","References":"<20240627173305.1477718-1-mzamazal@redhat.com>\n\t<20240627173305.1477718-3-mzamazal@redhat.com>","Subject":"Re: [PATCH 2/2] libcamera: simple: Log a missing sensor in a better\n\tway","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Mon, 01 Jul 2024 11:37:37 +0100","Message-ID":"<171983025702.392292.2811597846431166557@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30181,"web_url":"https://patchwork.libcamera.org/comment/30181/","msgid":"<87tth95lqe.fsf@redhat.com>","date":"2024-07-01T12:40:25","subject":"Re: [PATCH 2/2] libcamera: simple: Log a missing sensor in a better\n\tway","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Kieran,\n\nthank you for review.\n\nKieran Bingham writes:\n\n> Quoting Milan Zamazal (2024-06-27 18:33:05)\n>> SimplePipelineHandler::match may be called several times for different\n>> pipeline configurations. Not all of these calls must succeed. For\n>\n>> example, for TI AM69 board with a single camera attached, the following\n>> error is reported in the log even when libcamera works fine:\n>> \n>> ERROR SimplePipeline simple.cpp:1558 No sensor found\n>> \n>> This is because a sensor is found for /dev/media0 but not for\n>> /dev/media1. The error is harmless in such a case and only confuses\n>> users who may think no camera is detected at all. Let's change the\n>> error to info and add the device node to the message to indicate the\n>> error is specific to the given media only. It's up to the callers to\n>> report a fatal error condition if libcamera cannot work due to no\n>> matching pipeline configuration.\n>> \n>> Signed-off-by: Milan Zamazal \n>> ---\n>> src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>> \n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index eb36578e..be0bb677 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -1548,9 +1548,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n>> /* Locate the sensors. */\n>> std::vector sensors = locateSensors();\n>> if (sensors.empty()) {\n>> - LOG(SimplePipeline, Error) << \"No sensor found\";\n>> + LOG(SimplePipeline, Info) << \"No sensor found for \" << media_->deviceNode();\n>> return false;\n>> }\n>> + LOG(SimplePipeline, Debug) << \"Sensor found for \" << media_->deviceNode();\n>\n> These I like.\n>\n> Reviewed-by: Kieran Bingham \n>\n>\n> Is logPrefix defined for simple pipeline handler yet?\n\nNo, it is defined only in the algorithm-based software ISP refactoring\npatches.\n\n> media_->deviceNode() could be part of that perhaps (unless it's too\n> long) to make it clear /which/ media device is in use.\n\nA good idea, I'll consider it in the next iteration of the refactoring\npatches.\n\n>> /*\n>> * Create one camera data instance for each sensor and gather all\n>> -- \n>> 2.44.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F07FCBD87C\n\tfor ;\n\tMon, 1 Jul 2024 12:40:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D163962E22;\n\tMon, 1 Jul 2024 14:40:34 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A960F604C1\n\tfor ;\n\tMon, 1 Jul 2024 14:40:32 +0200 (CEST)","from mail-lj1-f199.google.com (mail-lj1-f199.google.com\n\t[209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-117-asGBW7bcO3SOOVMMyzw2Qw-1; Mon, 01 Jul 2024 08:40:29 -0400","by mail-lj1-f199.google.com with SMTP id\n\t38308e7fff4ca-2ec4efbbb7aso26568551fa.2\n\tfor ;\n\tMon, 01 Jul 2024 05:40:29 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a72aaf60458sm329797866b.63.2024.07.01.05.40.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Jul 2024 05:40:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hYW2oorY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719837631;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=WTndagovqruvV2zJN48ApZTdqWqhlxlx/MvqfH4OMuc=;\n\tb=hYW2oorYT06/2+HsCdAfWx6+kd+RmIX1rR7FiD+tCETKP4l7vvQRXpU2E6q9YgTa5mRJhK\n\tu0VspR91Rc/3snab2mofNJXR+PsaPjYPOqwaZcou5xPvb80LE0ux0a6+7BYKkQhm0XRPuV\n\tVynk0uXp2HmhK1FYZsoyv0HDY1v8oCY=","X-MC-Unique":"asGBW7bcO3SOOVMMyzw2Qw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1719837627; x=1720442427;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=WTndagovqruvV2zJN48ApZTdqWqhlxlx/MvqfH4OMuc=;\n\tb=CiluFlRw1rKCAx/JArt43OY0/Gd2831qkBzsgxnyf4uAGZPL6RJTW9sSmlBsqqtSTr\n\toa8zKhuONyifx47fgU608rgPBQGaeZoW0qI8kCqKhiY0HgJ3mzKJYB9joaJsdQvGtTJd\n\tugNcqWaTNko/71Ae8tsUru5Z5DKhXAi7sFFnrmI1Ha79UHucYUyoQJylCHHx0ICBbMH1\n\tx+bRh8ICJ3XTeAxr3zu+p7RhhyNPjHxlEfqg0E42go7eo2P5mfhu+M/AeajeY4U81fpQ\n\tApS/HcCe1hayHBhWWyvqgKxgCe0LGXGVBM6W3vsoBisp3F/KdkgY8svXLDpHxRF1Kf4s\n\tC2oQ==","X-Gm-Message-State":"AOJu0YxQU/PL6bTPGyJ1wNDby266kDDvtJZurvLozMzmaUrWJNImfxbi\n\tHGCn0+0XGGsmpRRKEkuiVHQFHBncGZVniUxB+d7NDgsz0xVeQlvlLS3g+56LNnBruA7U/940mTx\n\tm/QzLENdtM/eAJVw1WbN5QisIsA+parGQk/uyc2t7Wh1Kl1YqVVCwuLrgX7FtNVQ7cN8WW8GstC\n\tvxYTOdHzOO1hSbR0BqXPMiR+P7COqRZpUlj6m0j1tAn86qdMyrUjaBbsA=","X-Received":["by 2002:a05:651c:10a3:b0:2ec:5258:e889 with SMTP id\n\t38308e7fff4ca-2ee5e707b1fmr40234261fa.46.1719837627706; \n\tMon, 01 Jul 2024 05:40:27 -0700 (PDT)","by 2002:a05:651c:10a3:b0:2ec:5258:e889 with SMTP id\n\t38308e7fff4ca-2ee5e707b1fmr40234111fa.46.1719837627185; \n\tMon, 01 Jul 2024 05:40:27 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFsjiXJNlhurmF2BgFMICzHqZPNfiJLuS7Pc/NTZQZjxhr3k/zT+NKJHGeRzLRYbCJ6NS8FfA==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: simple: Log a missing sensor in a better\n\tway","In-Reply-To":"<171983025702.392292.2811597846431166557@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Mon, 01 Jul 2024 11:37:37 +0100\")","References":"<20240627173305.1477718-1-mzamazal@redhat.com>\n\t<20240627173305.1477718-3-mzamazal@redhat.com>\n\t<171983025702.392292.2811597846431166557@ping.linuxembedded.co.uk>","Date":"Mon, 01 Jul 2024 14:40:25 +0200","Message-ID":"<87tth95lqe.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30183,"web_url":"https://patchwork.libcamera.org/comment/30183/","msgid":"<20240701125823.GD15391@pendragon.ideasonboard.com>","date":"2024-07-01T12:58:23","subject":"Re: [PATCH 2/2] libcamera: simple: Log a missing sensor in a better\n\tway","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jul 01, 2024 at 11:37:37AM +0100, Kieran Bingham wrote:\n> Quoting Milan Zamazal (2024-06-27 18:33:05)\n> > SimplePipelineHandler::match may be called several times for different\n> > pipeline configurations. Not all of these calls must succeed. For\n> > example, for TI AM69 board with a single camera attached, the following\n> > error is reported in the log even when libcamera works fine:\n> > \n> > ERROR SimplePipeline simple.cpp:1558 No sensor found\n> > \n> > This is because a sensor is found for /dev/media0 but not for\n> > /dev/media1. The error is harmless in such a case and only confuses\n> > users who may think no camera is detected at all. Let's change the\n> > error to info and add the device node to the message to indicate the\n> > error is specific to the given media only. It's up to the callers to\n> > report a fatal error condition if libcamera cannot work due to no\n> > matching pipeline configuration.\n> > \n> > Signed-off-by: Milan Zamazal \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index eb36578e..be0bb677 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -1548,9 +1548,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> > /* Locate the sensors. */\n> > std::vector sensors = locateSensors();\n> > if (sensors.empty()) {\n> > - LOG(SimplePipeline, Error) << \"No sensor found\";\n> > + LOG(SimplePipeline, Info) << \"No sensor found for \" << media_->deviceNode();\n\n\t\tLOG(SimplePipeline, Info)\n\t\t\t<< \"No sensor found for \" << media_->deviceNode();\n\n> > return false;\n> > }\n\nAdd a blank line.\n\n> > + LOG(SimplePipeline, Debug) << \"Sensor found for \" << media_->deviceNode();\n> \n> These I like.\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> Is logPrefix defined for simple pipeline handler yet?\n> media_->deviceNode() could be part of that perhaps (unless it's too\n> long) to make it clear /which/ media device is in use.\n\nWe don't use logPrefix in any pipeline handler.\n\n> > \n> > /*\n> > * Create one camera data instance for each sensor and gather all","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAB83BD87C\n\tfor ;\n\tMon, 1 Jul 2024 12:58:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D58E6604C1;\n\tMon, 1 Jul 2024 14:58:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62F8B604C1\n\tfor ;\n\tMon, 1 Jul 2024 14:58:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70C71289;\n\tMon, 1 Jul 2024 14:58:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CZXCgLIP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719838698;\n\tbh=N+H9UyL94zMUHljFDMH3zG2KKUqUKvu2wPLvD135MGY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CZXCgLIPTvuatYLIilTCW+gnvucNrPoVHfnKDEQnFR7fIwCDNQhzc9GagQ+z3+R+E\n\tRyj84og1oFC4/2DTJRUD76hOAVQTZsXDAfj87+laL/TBpXs2Vn/04+UR+3XaJTxyM9\n\tLpQTNyAOP7w1IhDVZM7pYvEstAYRT+wEbMGBaK8s=","Date":"Mon, 1 Jul 2024 15:58:23 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: simple: Log a missing sensor in a better\n\tway","Message-ID":"<20240701125823.GD15391@pendragon.ideasonboard.com>","References":"<20240627173305.1477718-1-mzamazal@redhat.com>\n\t<20240627173305.1477718-3-mzamazal@redhat.com>\n\t<171983025702.392292.2811597846431166557@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171983025702.392292.2811597846431166557@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]