[{"id":30221,"web_url":"https://patchwork.libcamera.org/comment/30221/","msgid":"","date":"2024-07-02T13:23:27","subject":"Re: [PATCH v4 4/5] libcamera: converter: Add DW100 converter class","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jun 27, 2024 at 07:16:55PM +0530, Umang Jain wrote:\n> DW100 Dewarp engine is present on i.MX8MP SoC. This patch\n> provides a converter class (inherited from V4L2M2MConverter).\n> \n> The DW100 converter will be used for scaling capabilites hence, has\n> a helper to set scaler crop rectangles. Plumbing in the RkISP1\n> pipeline-handler is done in the subsequent patch.\n> \n> The ConverterDW100 class can be extended later (as additional\n> development) to support the dewarping by setting a dewarp vertex map.\n> \n> Signed-off-by: Umang Jain \n> ---\n> .../internal/converter/converter_dw100.h | 26 ++++++++\n> .../libcamera/internal/converter/meson.build | 1 +\n> src/libcamera/converter/converter_dw100.cpp | 64 +++++++++++++++++++\n> src/libcamera/converter/meson.build | 1 +\n> 4 files changed, 92 insertions(+)\n> create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n> create mode 100644 src/libcamera/converter/converter_dw100.cpp\n> \n> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> new file mode 100644\n> index 00000000..dbd39e08\n> --- /dev/null\n> +++ b/include/libcamera/internal/converter/converter_dw100.h\n> @@ -0,0 +1,26 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2024, Ideas On Board Oy\n> + *\n> + * i.MX8MP Dewarp Engine integration\n> + */\n> +\n> +#pragma once\n> +\n> +#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> +\n> +namespace libcamera {\n> +\n> +class MediaDevice;\n> +class Rectangle;\n> +class Stream;\n> +\n> +class ConverterDW100 : public V4L2M2MConverter\n> +{\n> +public:\n> +\tConverterDW100(std::shared_ptr media);\n> +\n> +\tint setScalerCrop(const Stream *stream, Rectangle *rect);\n> +};\n> +\n> +} /* namespace libcamera */\n> diff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\n> index 891e79e7..85007a4b 100644\n> --- a/include/libcamera/internal/converter/meson.build\n> +++ b/include/libcamera/internal/converter/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_internal_headers += files([\n> + 'converter_dw100.h',\n> 'converter_v4l2_m2m.h',\n> ])\n> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> new file mode 100644\n> index 00000000..78802615\n> --- /dev/null\n> +++ b/src/libcamera/converter/converter_dw100.cpp\n> @@ -0,0 +1,64 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2024, Ideas On Board Oy\n> + *\n> + * i.MX8MP Dewarp Engine integration\n> + */\n> +\n> +#include \"libcamera/internal/converter/converter_dw100.h\"\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/media_device.h\"\n> +#include \"libcamera/internal/v4l2_videodevice.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(Converter)\n> +\n> +/**\n> + * \\class libcamera::ConverterDW100\n> + * \\brief The i.MX8MP dewarp converter implements the converter interface based\n> + * on V4L2 M2M device.\n> +*/\n> +\n> +/**\n> + * \\fn ConverterDW100::ConverterDW100\n> + * \\brief Construct a ConverterDW100 instance\n> + * \\param[in] media The media device implementing the converter\n> + */\n> +ConverterDW100::ConverterDW100(std::shared_ptr media)\n> +\t: V4L2M2MConverter(media.get(), Feature::Crop)\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Set the scaler crop rectangle \\a rect on \\a stream\n> + * \\param[in] stream Pointer to output stream\n> + * \\param[inout] rect The selection rectangle to be applied\n\nrect doesn't seem to be used as an output parameter?\n\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int ConverterDW100::setScalerCrop(const Stream *stream, Rectangle *rect)\n> +{\n> +\tRectangle apply = *rect;\n\nThis dereference scares me but I see you want to use it as an output\nparameter (I assume to report the rectangle that was actually set).\n\n> +\tint ret;\n> +\n> +\tret = setCrop(stream, &apply);\n> +\tif (ret < 0)\n> +\t\tLOG(Converter, Error) << \"Failed to set scaler crop \"\n> +\t\t\t\t << apply.toString() << \" on dewarper \"\n> +\t\t\t\t << strerror(-ret);\n\nCan't we just return here?\n\n> +\n> +\tif (*rect != apply) {\n> +\t\t/* \\todo This case needs proper after handling. */\n\nI think it's ok to just return the scaler crop that was able to be set.\n\n\nPaul\n\n> +\t\tLOG(Converter, Warning) << \"Applied rectangle \" << apply.toString()\n> +\t\t\t\t\t<< \" differs from requested \" << rect->toString();\n> +\t}\n> +\n> +\treturn ret;\n> +}\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\n> index 2aa72fe4..175581b8 100644\n> --- a/src/libcamera/converter/meson.build\n> +++ b/src/libcamera/converter/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_sources += files([\n> + 'converter_dw100.cpp',\n> 'converter_v4l2_m2m.cpp'\n> ])\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5AA4BEFBE\n\tfor ;\n\tTue, 2 Jul 2024 13:23:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AC9162E23;\n\tTue, 2 Jul 2024 15:23:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88B5062C96\n\tfor ;\n\tTue, 2 Jul 2024 15:23:33 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 309D6664;\n\tTue, 2 Jul 2024 15:23:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mVXwlXAm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719926586;\n\tbh=a6dv1ZF8THBQ+OaNkcQ5YeAHMjCBGkpf1aSkcySXu3s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mVXwlXAmxaT1Zo75TecAcZ/cbq7UzoR6J4bpdFuZfmGsHWx2bzYZfKEK+hQEfSw9X\n\t0TCk58iWG7lq+qIMv6tQiasnCq6zlFqz4qBfAuz/tmui5VeDHnoVFF8LmkswC5K2gb\n\to5j6Nzjzv7wOK1D1cRTPpTHcdPK9LPU4Lf/xhoZs=","Date":"Tue, 2 Jul 2024 22:23:27 +0900","From":"Paul Elder ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 4/5] libcamera: converter: Add DW100 converter class","Message-ID":"","References":"<20240627134656.582462-1-umang.jain@ideasonboard.com>\n\t<20240627134656.582462-5-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240627134656.582462-5-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30232,"web_url":"https://patchwork.libcamera.org/comment/30232/","msgid":"","date":"2024-07-03T03:32:56","subject":"Re: [PATCH v4 4/5] libcamera: converter: Add DW100 converter class","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul\n\nOn 02/07/24 6:53 pm, Paul Elder wrote:\n> On Thu, Jun 27, 2024 at 07:16:55PM +0530, Umang Jain wrote:\n>> DW100 Dewarp engine is present on i.MX8MP SoC. This patch\n>> provides a converter class (inherited from V4L2M2MConverter).\n>>\n>> The DW100 converter will be used for scaling capabilites hence, has\n>> a helper to set scaler crop rectangles. Plumbing in the RkISP1\n>> pipeline-handler is done in the subsequent patch.\n>>\n>> The ConverterDW100 class can be extended later (as additional\n>> development) to support the dewarping by setting a dewarp vertex map.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> .../internal/converter/converter_dw100.h | 26 ++++++++\n>> .../libcamera/internal/converter/meson.build | 1 +\n>> src/libcamera/converter/converter_dw100.cpp | 64 +++++++++++++++++++\n>> src/libcamera/converter/meson.build | 1 +\n>> 4 files changed, 92 insertions(+)\n>> create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n>> create mode 100644 src/libcamera/converter/converter_dw100.cpp\n>>\n>> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n>> new file mode 100644\n>> index 00000000..dbd39e08\n>> --- /dev/null\n>> +++ b/include/libcamera/internal/converter/converter_dw100.h\n>> @@ -0,0 +1,26 @@\n>> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n>> +/*\n>> + * Copyright (C) 2024, Ideas On Board Oy\n>> + *\n>> + * i.MX8MP Dewarp Engine integration\n>> + */\n>> +\n>> +#pragma once\n>> +\n>> +#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n>> +\n>> +namespace libcamera {\n>> +\n>> +class MediaDevice;\n>> +class Rectangle;\n>> +class Stream;\n>> +\n>> +class ConverterDW100 : public V4L2M2MConverter\n>> +{\n>> +public:\n>> +\tConverterDW100(std::shared_ptr media);\n>> +\n>> +\tint setScalerCrop(const Stream *stream, Rectangle *rect);\n>> +};\n>> +\n>> +} /* namespace libcamera */\n>> diff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\n>> index 891e79e7..85007a4b 100644\n>> --- a/include/libcamera/internal/converter/meson.build\n>> +++ b/include/libcamera/internal/converter/meson.build\n>> @@ -1,5 +1,6 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>> \n>> libcamera_internal_headers += files([\n>> + 'converter_dw100.h',\n>> 'converter_v4l2_m2m.h',\n>> ])\n>> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n>> new file mode 100644\n>> index 00000000..78802615\n>> --- /dev/null\n>> +++ b/src/libcamera/converter/converter_dw100.cpp\n>> @@ -0,0 +1,64 @@\n>> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n>> +/*\n>> + * Copyright (C) 2024, Ideas On Board Oy\n>> + *\n>> + * i.MX8MP Dewarp Engine integration\n>> + */\n>> +\n>> +#include \"libcamera/internal/converter/converter_dw100.h\"\n>> +\n>> +#include \n>> +\n>> +#include \n>> +\n>> +#include \"libcamera/internal/media_device.h\"\n>> +#include \"libcamera/internal/v4l2_videodevice.h\"\n>> +\n>> +namespace libcamera {\n>> +\n>> +LOG_DECLARE_CATEGORY(Converter)\n>> +\n>> +/**\n>> + * \\class libcamera::ConverterDW100\n>> + * \\brief The i.MX8MP dewarp converter implements the converter interface based\n>> + * on V4L2 M2M device.\n>> +*/\n>> +\n>> +/**\n>> + * \\fn ConverterDW100::ConverterDW100\n>> + * \\brief Construct a ConverterDW100 instance\n>> + * \\param[in] media The media device implementing the converter\n>> + */\n>> +ConverterDW100::ConverterDW100(std::shared_ptr media)\n>> +\t: V4L2M2MConverter(media.get(), Feature::Crop)\n>> +{\n>> +}\n>> +\n>> +/**\n>> + * \\brief Set the scaler crop rectangle \\a rect on \\a stream\n>> + * \\param[in] stream Pointer to output stream\n>> + * \\param[inout] rect The selection rectangle to be applied\n> rect doesn't seem to be used as an output parameter?\n>\n>> + *\n>> + * \\return 0 on success or a negative error code otherwise\n>> + */\n>> +int ConverterDW100::setScalerCrop(const Stream *stream, Rectangle *rect)\n>> +{\n>> +\tRectangle apply = *rect;\n> This dereference scares me but I see you want to use it as an output\n> parameter (I assume to report the rectangle that was actually set).\n\nThis setScalerCrop()  something can be dropped, to directly call \nsetCrop() of the converter by the consumer.\n\nBut first, I want to just check what should be the handling of the below \n\\todo w.r.t to applied rectangles, hence I kept a additional wrapper \naround setCrop() for now.\n\n>\n>> +\tint ret;\n>> +\n>> +\tret = setCrop(stream, &apply);\n>> +\tif (ret < 0)\n>> +\t\tLOG(Converter, Error) << \"Failed to set scaler crop \"\n>> +\t\t\t\t << apply.toString() << \" on dewarper \"\n>> +\t\t\t\t << strerror(-ret);\n> Can't we just return here?\n>\n>> +\n>> +\tif (*rect != apply) {\n>> +\t\t/* \\todo This case needs proper after handling. */\n> I think it's ok to just return the scaler crop that was able to be set.\n\nI think that too and report that as metadata.\n>\n>\n> Paul\n>\n>> +\t\tLOG(Converter, Warning) << \"Applied rectangle \" << apply.toString()\n>> +\t\t\t\t\t<< \" differs from requested \" << rect->toString();\n>> +\t}\n>> +\n>> +\treturn ret;\n>> +}\n>> +\n>> +} /* namespace libcamera */\n>> diff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\n>> index 2aa72fe4..175581b8 100644\n>> --- a/src/libcamera/converter/meson.build\n>> +++ b/src/libcamera/converter/meson.build\n>> @@ -1,5 +1,6 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>> \n>> libcamera_sources += files([\n>> + 'converter_dw100.cpp',\n>> 'converter_v4l2_m2m.cpp'\n>> ])\n>> -- \n>> 2.44.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93CABBD87C\n\tfor ;\n\tWed, 3 Jul 2024 03:33:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CB5C62E01;\n\tWed, 3 Jul 2024 05:33:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B0C4619C0\n\tfor ;\n\tWed, 3 Jul 2024 05:33:01 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82D385A4;\n\tWed, 3 Jul 2024 05:32:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"leE7B6Cj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719977553;\n\tbh=5eGKxpwNXqKbKLMTrBVD/AJH676g6AIVerYU4Z+Yp5g=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=leE7B6CjEP+KxAQCI20T6OOsTLhw/1+WOm/vJMebWTE2/cQ70+c2xvJyQCrhh6y94\n\tF+p15t272kiQFgAB9nQ8+nJoidakyMcCVSka9E2OAi5t9TmATK7RjdlyPJP06NcgAr\n\tYjjfHfBc5ZaqNEHHzkF+wnNBMX472Zfx3cuCMd1c=","Message-ID":"","Date":"Wed, 3 Jul 2024 09:02:56 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 4/5] libcamera: converter: Add DW100 converter class","Content-Language":"en-US","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20240627134656.582462-1-umang.jain@ideasonboard.com>\n\t<20240627134656.582462-5-umang.jain@ideasonboard.com>\n\t","From":"Umang Jain ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30237,"web_url":"https://patchwork.libcamera.org/comment/30237/","msgid":"","date":"2024-07-03T07:38:09","subject":"Re: [PATCH v4 4/5] libcamera: converter: Add DW100 converter class","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 03, 2024 at 09:02:56AM +0530, Umang Jain wrote:\n> Hi Paul\n> \n> On 02/07/24 6:53 pm, Paul Elder wrote:\n> > On Thu, Jun 27, 2024 at 07:16:55PM +0530, Umang Jain wrote:\n> > > DW100 Dewarp engine is present on i.MX8MP SoC. This patch\n> > > provides a converter class (inherited from V4L2M2MConverter).\n> > > \n> > > The DW100 converter will be used for scaling capabilites hence, has\n> > > a helper to set scaler crop rectangles. Plumbing in the RkISP1\n> > > pipeline-handler is done in the subsequent patch.\n> > > \n> > > The ConverterDW100 class can be extended later (as additional\n> > > development) to support the dewarping by setting a dewarp vertex map.\n> > > \n> > > Signed-off-by: Umang Jain \n> > > ---\n> > > .../internal/converter/converter_dw100.h | 26 ++++++++\n> > > .../libcamera/internal/converter/meson.build | 1 +\n> > > src/libcamera/converter/converter_dw100.cpp | 64 +++++++++++++++++++\n> > > src/libcamera/converter/meson.build | 1 +\n> > > 4 files changed, 92 insertions(+)\n> > > create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n> > > create mode 100644 src/libcamera/converter/converter_dw100.cpp\n> > > \n> > > diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> > > new file mode 100644\n> > > index 00000000..dbd39e08\n> > > --- /dev/null\n> > > +++ b/include/libcamera/internal/converter/converter_dw100.h\n> > > @@ -0,0 +1,26 @@\n> > > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > > +/*\n> > > + * Copyright (C) 2024, Ideas On Board Oy\n> > > + *\n> > > + * i.MX8MP Dewarp Engine integration\n> > > + */\n> > > +\n> > > +#pragma once\n> > > +\n> > > +#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> > > +\n> > > +namespace libcamera {\n> > > +\n> > > +class MediaDevice;\n> > > +class Rectangle;\n> > > +class Stream;\n> > > +\n> > > +class ConverterDW100 : public V4L2M2MConverter\n> > > +{\n> > > +public:\n> > > +\tConverterDW100(std::shared_ptr media);\n> > > +\n> > > +\tint setScalerCrop(const Stream *stream, Rectangle *rect);\n> > > +};\n> > > +\n> > > +} /* namespace libcamera */\n> > > diff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\n> > > index 891e79e7..85007a4b 100644\n> > > --- a/include/libcamera/internal/converter/meson.build\n> > > +++ b/include/libcamera/internal/converter/meson.build\n> > > @@ -1,5 +1,6 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > libcamera_internal_headers += files([\n> > > + 'converter_dw100.h',\n> > > 'converter_v4l2_m2m.h',\n> > > ])\n> > > diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> > > new file mode 100644\n> > > index 00000000..78802615\n> > > --- /dev/null\n> > > +++ b/src/libcamera/converter/converter_dw100.cpp\n> > > @@ -0,0 +1,64 @@\n> > > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > > +/*\n> > > + * Copyright (C) 2024, Ideas On Board Oy\n> > > + *\n> > > + * i.MX8MP Dewarp Engine integration\n> > > + */\n> > > +\n> > > +#include \"libcamera/internal/converter/converter_dw100.h\"\n> > > +\n> > > +#include \n> > > +\n> > > +#include \n> > > +\n> > > +#include \"libcamera/internal/media_device.h\"\n> > > +#include \"libcamera/internal/v4l2_videodevice.h\"\n> > > +\n> > > +namespace libcamera {\n> > > +\n> > > +LOG_DECLARE_CATEGORY(Converter)\n> > > +\n> > > +/**\n> > > + * \\class libcamera::ConverterDW100\n> > > + * \\brief The i.MX8MP dewarp converter implements the converter interface based\n> > > + * on V4L2 M2M device.\n> > > +*/\n> > > +\n> > > +/**\n> > > + * \\fn ConverterDW100::ConverterDW100\n> > > + * \\brief Construct a ConverterDW100 instance\n> > > + * \\param[in] media The media device implementing the converter\n> > > + */\n> > > +ConverterDW100::ConverterDW100(std::shared_ptr media)\n> > > +\t: V4L2M2MConverter(media.get(), Feature::Crop)\n> > > +{\n> > > +}\n> > > +\n> > > +/**\n> > > + * \\brief Set the scaler crop rectangle \\a rect on \\a stream\n> > > + * \\param[in] stream Pointer to output stream\n> > > + * \\param[inout] rect The selection rectangle to be applied\n> > rect doesn't seem to be used as an output parameter?\n> > \n> > > + *\n> > > + * \\return 0 on success or a negative error code otherwise\n> > > + */\n> > > +int ConverterDW100::setScalerCrop(const Stream *stream, Rectangle *rect)\n> > > +{\n> > > +\tRectangle apply = *rect;\n> > This dereference scares me but I see you want to use it as an output\n> > parameter (I assume to report the rectangle that was actually set).\n> \n> This setScalerCrop()  something can be dropped, to directly call setCrop()\n> of the converter by the consumer.\n\nOh right yeah that's true. The caller would be responsible for checking\nthe capability.\n\n\nPaul\n\n> \n> But first, I want to just check what should be the handling of the below\n> \\todo w.r.t to applied rectangles, hence I kept a additional wrapper around\n> setCrop() for now.\n> \n> > \n> > > +\tint ret;\n> > > +\n> > > +\tret = setCrop(stream, &apply);\n> > > +\tif (ret < 0)\n> > > +\t\tLOG(Converter, Error) << \"Failed to set scaler crop \"\n> > > +\t\t\t\t << apply.toString() << \" on dewarper \"\n> > > +\t\t\t\t << strerror(-ret);\n> > Can't we just return here?\n> > \n> > > +\n> > > +\tif (*rect != apply) {\n> > > +\t\t/* \\todo This case needs proper after handling. */\n> > I think it's ok to just return the scaler crop that was able to be set.\n> \n> I think that too and report that as metadata.\n> > \n> > \n> > Paul\n> > \n> > > +\t\tLOG(Converter, Warning) << \"Applied rectangle \" << apply.toString()\n> > > +\t\t\t\t\t<< \" differs from requested \" << rect->toString();\n> > > +\t}\n> > > +\n> > > +\treturn ret;\n> > > +}\n> > > +\n> > > +} /* namespace libcamera */\n> > > diff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\n> > > index 2aa72fe4..175581b8 100644\n> > > --- a/src/libcamera/converter/meson.build\n> > > +++ b/src/libcamera/converter/meson.build\n> > > @@ -1,5 +1,6 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > libcamera_sources += files([\n> > > + 'converter_dw100.cpp',\n> > > 'converter_v4l2_m2m.cpp'\n> > > ])\n> > > -- \n> > > 2.44.0\n> > > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFC92BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 07:38:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8E5262E23;\n\tWed, 3 Jul 2024 09:38:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C35F3619C7\n\tfor ;\n\tWed, 3 Jul 2024 09:38:17 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA29D5A4;\n\tWed, 3 Jul 2024 09:37:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ifwjbYV8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719992269;\n\tbh=qbnVhaPh+rb5dI/K+ALZBSwuF/fbwEppDSGRhkruQeM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ifwjbYV8/Hz0dwopIh7u2oaVohvbYeJNbpLTRqdz6SRB8lq3Op/jcBodgWxpfJl4E\n\tcJs3uEicJ0nzFuWya/winNHvA0ycdxgOUOMl7QtykWjjDkVfwjlp5pOQ89D/AGfaWR\n\tUC51Ble93rBiqh5Xd/hKv1lHW6++z5/C5+IyN9rI=","Date":"Wed, 3 Jul 2024 16:38:09 +0900","From":"Paul Elder ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 4/5] libcamera: converter: Add DW100 converter class","Message-ID":"","References":"<20240627134656.582462-1-umang.jain@ideasonboard.com>\n\t<20240627134656.582462-5-umang.jain@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]