{"id":20434,"url":"https://patchwork.libcamera.org/api/patches/20434/?format=json","web_url":"https://patchwork.libcamera.org/patch/20434/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627134656.582462-5-umang.jain@ideasonboard.com>","date":"2024-06-27T13:46:55","name":"[v4,4/5] libcamera: converter: Add DW100 converter class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1911d3046074f2776d977dd8d6f245238f0f1461","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20434/mbox/","series":[{"id":4425,"url":"https://patchwork.libcamera.org/api/series/4425/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4425","date":"2024-06-27T13:46:51","name":"libcamera: rkisp1: Plumb the ConverterDW100 converter","version":4,"mbox":"https://patchwork.libcamera.org/series/4425/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20434/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20434/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4201BDB1D\n\tfor ;\n\tThu, 27 Jun 2024 13:47:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A04562E24;\n\tThu, 27 Jun 2024 15:47:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A35A62E21\n\tfor ;\n\tThu, 27 Jun 2024 15:47:08 +0200 (CEST)","from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:c173:4b:4a04:3a21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62BF1E22;\n\tThu, 27 Jun 2024 15:46:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"juxIVLUF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719496004;\n\tbh=rtc+XKK2E9dpQ3FsmYfg0icv2NuEtEcKOmw2drO1eUQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=juxIVLUFbZb+KpAIBZ38IWEzWwyrJgD0eHRBPZAZDrD5ayUmYSoiUwvSWUkDX9KUa\n\tWmsHszaEvjTr+5kosxBzZx5VD/NeyCJ2pHP0ciawEkKODiR/qiGCxQmP33enzoXFGF\n\tzsYgD78s0Pbj3eOxR0XGpIkvdGZ6LYj2Btw5pwTU=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v4 4/5] libcamera: converter: Add DW100 converter class","Date":"Thu, 27 Jun 2024 19:16:55 +0530","Message-ID":"<20240627134656.582462-5-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.44.0","In-Reply-To":"<20240627134656.582462-1-umang.jain@ideasonboard.com>","References":"<20240627134656.582462-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"DW100 Dewarp engine is present on i.MX8MP SoC. This patch\nprovides a converter class (inherited from V4L2M2MConverter).\n\nThe DW100 converter will be used for scaling capabilites hence, has\na helper to set scaler crop rectangles. Plumbing in the RkISP1\npipeline-handler is done in the subsequent patch.\n\nThe ConverterDW100 class can be extended later (as additional\ndevelopment) to support the dewarping by setting a dewarp vertex map.\n\nSigned-off-by: Umang Jain \n---\n .../internal/converter/converter_dw100.h | 26 ++++++++\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter/converter_dw100.cpp | 64 +++++++++++++++++++\n src/libcamera/converter/meson.build | 1 +\n 4 files changed, 92 insertions(+)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp","diff":"diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nnew file mode 100644\nindex 00000000..dbd39e08\n--- /dev/null\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -0,0 +1,26 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#pragma once\n+\n+#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+\n+namespace libcamera {\n+\n+class MediaDevice;\n+class Rectangle;\n+class Stream;\n+\n+class ConverterDW100 : public V4L2M2MConverter\n+{\n+public:\n+\tConverterDW100(std::shared_ptr media);\n+\n+\tint setScalerCrop(const Stream *stream, Rectangle *rect);\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\nindex 891e79e7..85007a4b 100644\n--- a/include/libcamera/internal/converter/meson.build\n+++ b/include/libcamera/internal/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_headers += files([\n+ 'converter_dw100.h',\n 'converter_v4l2_m2m.h',\n ])\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nnew file mode 100644\nindex 00000000..78802615\n--- /dev/null\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -0,0 +1,64 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#include \"libcamera/internal/converter/converter_dw100.h\"\n+\n+#include \n+\n+#include \n+\n+#include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Converter)\n+\n+/**\n+ * \\class libcamera::ConverterDW100\n+ * \\brief The i.MX8MP dewarp converter implements the converter interface based\n+ * on V4L2 M2M device.\n+*/\n+\n+/**\n+ * \\fn ConverterDW100::ConverterDW100\n+ * \\brief Construct a ConverterDW100 instance\n+ * \\param[in] media The media device implementing the converter\n+ */\n+ConverterDW100::ConverterDW100(std::shared_ptr media)\n+\t: V4L2M2MConverter(media.get(), Feature::Crop)\n+{\n+}\n+\n+/**\n+ * \\brief Set the scaler crop rectangle \\a rect on \\a stream\n+ * \\param[in] stream Pointer to output stream\n+ * \\param[inout] rect The selection rectangle to be applied\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+int ConverterDW100::setScalerCrop(const Stream *stream, Rectangle *rect)\n+{\n+\tRectangle apply = *rect;\n+\tint ret;\n+\n+\tret = setCrop(stream, &apply);\n+\tif (ret < 0)\n+\t\tLOG(Converter, Error) << \"Failed to set scaler crop \"\n+\t\t\t\t << apply.toString() << \" on dewarper \"\n+\t\t\t\t << strerror(-ret);\n+\n+\tif (*rect != apply) {\n+\t\t/* \\todo This case needs proper after handling. */\n+\t\tLOG(Converter, Warning) << \"Applied rectangle \" << apply.toString()\n+\t\t\t\t\t<< \" differs from requested \" << rect->toString();\n+\t}\n+\n+\treturn ret;\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\nindex 2aa72fe4..175581b8 100644\n--- a/src/libcamera/converter/meson.build\n+++ b/src/libcamera/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_sources += files([\n+ 'converter_dw100.cpp',\n 'converter_v4l2_m2m.cpp'\n ])\n","prefixes":["v4","4/5"]}