[{"id":30211,"web_url":"https://patchwork.libcamera.org/comment/30211/","msgid":"","date":"2024-07-02T12:13:10","subject":"Re: [PATCH v4 1/5] libcamera: converter: Add interface for feature\n\tflags","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jun 27, 2024 at 07:16:52PM +0530, Umang Jain wrote:\n> This patch intends to extend the converter interface to have feature\n> flags, which enables each converter to expose the set of features\n> it supports.\n> \n> Signed-off-by: Umang Jain \n> ---\n> include/libcamera/internal/converter.h | 13 ++++++++++-\n> .../internal/converter/converter_v4l2_m2m.h | 2 +-\n> src/libcamera/converter.cpp | 22 ++++++++++++++++++-\n> .../converter/converter_v4l2_m2m.cpp | 5 +++--\n> 4 files changed, 37 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\n> index b51563d7..15bc7dca 100644\n> --- a/include/libcamera/internal/converter.h\n> +++ b/include/libcamera/internal/converter.h\n> @@ -17,6 +17,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> #include \n> @@ -32,7 +33,13 @@ struct StreamConfiguration;\n> class Converter\n> {\n> public:\n> -\tConverter(MediaDevice *media);\n> +\tenum class Feature {\n> +\t\tNone = (1 << 0),\n\nI would've expected 0 (the lack of any flags) to indicate that \"no\nfeature is supported\".\n\n\nPaul\n\n> +\t};\n> +\n> +\tusing Features = Flags;\n> +\n> +\tConverter(MediaDevice *media, Features features = Feature::None);\n> \tvirtual ~Converter();\n> \n> \tvirtual int loadConfiguration(const std::string &filename) = 0;\n> @@ -61,8 +68,12 @@ public:\n> \n> \tconst std::string &deviceNode() const { return deviceNode_; }\n> \n> +\tFeatures getFeatures() const { return features_; }\n> +\n> private:\n> \tstd::string deviceNode_;\n> +\n> +\tFeatures features_;\n> };\n> \n> class ConverterFactoryBase\n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index b9e59899..91701dbe 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -35,7 +35,7 @@ class V4L2M2MDevice;\n> class V4L2M2MConverter : public Converter\n> {\n> public:\n> -\tV4L2M2MConverter(MediaDevice *media);\n> +\tV4L2M2MConverter(MediaDevice *media, Features features = Feature::None);\n> \n> \tint loadConfiguration([[maybe_unused]] const std::string &filename) { return 0; }\n> \tbool isValid() const { return m2m_ != nullptr; }\n> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> index c5e38937..2dc7d984 100644\n> --- a/src/libcamera/converter.cpp\n> +++ b/src/libcamera/converter.cpp\n> @@ -34,14 +34,27 @@ LOG_DEFINE_CATEGORY(Converter)\n> * parameters from the same input stream.\n> */\n> \n> +/**\n> + * \\enum Converter::Feature\n> + * \\brief Specify the features supported by the converter\n> + * \\var Converter::Feature::None\n> + * \\brief No extra features supported by the converter\n> + */\n> +\n> +/**\n> + * \\typedef Converter::Features\n> + * \\brief A bitwise combination of features supported by the converter\n> + */\n> +\n> /**\n> * \\brief Construct a Converter instance\n> * \\param[in] media The media device implementing the converter\n> + * \\param[in] features Features flags representing supported features\n> *\n> * This searches for the entity implementing the data streaming function in the\n> * media graph entities and use its device node as the converter device node.\n> */\n> -Converter::Converter(MediaDevice *media)\n> +Converter::Converter(MediaDevice *media, Features features)\n> {\n> \tconst std::vector &entities = media->entities();\n> \tauto it = std::find_if(entities.begin(), entities.end(),\n> @@ -56,6 +69,7 @@ Converter::Converter(MediaDevice *media)\n> \t}\n> \n> \tdeviceNode_ = (*it)->deviceNode();\n> +\tfeatures_ = features;\n> }\n> \n> Converter::~Converter()\n> @@ -163,6 +177,12 @@ Converter::~Converter()\n> * \\return The converter device node string\n> */\n> \n> +/**\n> + * \\fn Converter::getFeatures()\n> + * \\brief Gets the supported features by the converter\n> + * \\return The converter Features flag\n> + */\n> +\n> /**\n> * \\class ConverterFactoryBase\n> * \\brief Base class for converter factories\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2e77872e..4aeb7dd9 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -191,10 +191,11 @@ void V4L2M2MConverter::V4L2M2MStream::captureBufferReady(FrameBuffer *buffer)\n> * \\fn V4L2M2MConverter::V4L2M2MConverter\n> * \\brief Construct a V4L2M2MConverter instance\n> * \\param[in] media The media device implementing the converter\n> + * \\param[in] features Features flags representing supported features\n> */\n> \n> -V4L2M2MConverter::V4L2M2MConverter(MediaDevice *media)\n> -\t: Converter(media)\n> +V4L2M2MConverter::V4L2M2MConverter(MediaDevice *media, Features features)\n> +\t: Converter(media, features)\n> {\n> \tif (deviceNode().empty())\n> \t\treturn;\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B84A3BD87C\n\tfor ;\n\tTue, 2 Jul 2024 12:13:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0941662C96;\n\tTue, 2 Jul 2024 14:13:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE27B619CC\n\tfor ;\n\tTue, 2 Jul 2024 14:13:17 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BF375A4;\n\tTue, 2 Jul 2024 14:12:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cxhLn5iA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719922370;\n\tbh=9iR3VD1RyoG++ip685e4H9nEM/WGdvJEkFYGDOXhvPM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cxhLn5iA3g1IWAgRPyZG27oarB3fdu8JcEvFx/b6OMDlRyhIEFyy10LL1hNJ9Nxxj\n\trwp22X9siIWtKtggi5idg0F1lKw2yw1prGxiUl/nUkmckDeMfNGuqvDrk1LnxA8YwG\n\tBx1ttLTh8GCyP0HPFO5MSfJeKtjQ3YTSoO6rSKcM=","Date":"Tue, 2 Jul 2024 21:13:10 +0900","From":"Paul Elder ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 1/5] libcamera: converter: Add interface for feature\n\tflags","Message-ID":"","References":"<20240627134656.582462-1-umang.jain@ideasonboard.com>\n\t<20240627134656.582462-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240627134656.582462-2-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]