[{"id":30095,"web_url":"https://patchwork.libcamera.org/comment/30095/","msgid":"<171949398879.3790642.16032748515224075886@ping.linuxembedded.co.uk>","date":"2024-06-27T13:13:08","subject":"Re: [PATCH 3/3] apps: common: dng_writer: Support RAW10 and RAW12\n\tformat","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-06-27 13:51:11)\n> Add support for RAW10 and RAW12 to the dng_writer. This is needed on\n> imx8mp to produce tuning images. Both formats were tested on a debix\n> som with a imx335.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/apps/common/dng_writer.cpp | 76 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 76 insertions(+)\n> \n> diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> index 2cb320ff327b..162c41a84011 100644\n> --- a/src/apps/common/dng_writer.cpp\n> +++ b/src/apps/common/dng_writer.cpp\n> @@ -136,6 +136,34 @@ void packScanlineRaw8(void *output, const void *input, unsigned int width)\n> std::copy(in, in + width, out);\n> }\n> \n> +void packScanlineRaw10(void *output, const void *input, unsigned int width)\n> +{\n> + const uint16_t *in = static_cast(input);\n> + uint8_t *out = static_cast(output);\n> +\n> + for (unsigned int i = 0; i < width; i += 4) {\n> + *out++ = (in[0] & 0x3fc) >> 2;\n> + *out++ = (in[0] & 0x003) << 6 | (in[1] & 0x3f0) >> 4;\n> + *out++ = (in[1] & 0x00f) << 4 | (in[2] & 0x3c0) >> 6;\n> + *out++ = (in[2] & 0x03f) << 2 | (in[3] & 0x300) >> 8;\n> + *out++ = (in[3] & 0x0ff);\n> + in += 4;\n> + }\n> +}\n> +\n> +void packScanlineRaw12(void *output, const void *input, unsigned int width)\n> +{\n> + const uint16_t *in = static_cast(input);\n> + uint8_t *out = static_cast(output);\n> +\n> + for (unsigned int i = 0; i < width; i += 2) {\n> + *out++ = (in[0] & 0xff0) >> 4;\n> + *out++ = (in[0] & 0x00f) << 4 | (in[1] & 0xf00) >> 8;\n> + *out++ = (in[1] & 0x0ff);\n> + in += 2;\n> + }\n> +}\n> +\n> void packScanlineRaw16(void *output, const void *input, unsigned int width)\n> {\n> const uint16_t *in = static_cast(input);\n> @@ -341,6 +369,54 @@ const std::map formatInfo = {\n> .packScanline = packScanlineRaw8,\n> .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> + { formats::SBGGR10, {\n> + .bitsPerSample = 10,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n\n\tBlue, Green, Green, Red ?\n\n> + .packScanline = packScanlineRaw10,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SGBRG10, {\n> + .bitsPerSample = 10,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n\n\tGreen, Blue, Red, Green ?\n\nSame for the others ... ?\n\n> + .packScanline = packScanlineRaw10,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SGRBG10, {\n> + .bitsPerSample = 10,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> + .packScanline = packScanlineRaw10,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SRGGB10, {\n> + .bitsPerSample = 10,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> + .packScanline = packScanlineRaw10,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SBGGR12, {\n> + .bitsPerSample = 12,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> + .packScanline = packScanlineSBGGR12,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SGBRG12, {\n> + .bitsPerSample = 12,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> + .packScanline = packScanlineSBGGR12,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SGRBG12, {\n> + .bitsPerSample = 12,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> + .packScanline = packScanlineSBGGR12,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> + { formats::SRGGB12, {\n> + .bitsPerSample = 12,\n> + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> + .packScanline = packScanlineSBGGR12,\n> + .thumbScanline = thumbScanlineRawXX,\n> + } },\n> { formats::SBGGR16, {\n> .bitsPerSample = 16,\n> .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53C1ABDB1D\n\tfor ;\n\tThu, 27 Jun 2024 13:13:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9548862C98;\n\tThu, 27 Jun 2024 15:13:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E145E62C98\n\tfor ;\n\tThu, 27 Jun 2024 15:13:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E65BA593;\n\tThu, 27 Jun 2024 15:12:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"viWRs6WR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719493968;\n\tbh=O9lSk4MQcVuLyxqjX7jxEEH68HlNrjNjDqfT9P+UKVM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=viWRs6WR0G+5CLHbWgdq1N/v1JXJib0rdz628cFTSfhQvdeB/dG0lWKazNzbe8+jC\n\tTRjWVqRihzecVckUmU62oAVJWfOjpHRMCFzefqN3x5W7/IxzWBNlJnb7TKHTGftCFr\n\tsQ3zVofrWcOaUfqHGWKPvoJ1hB2LDtxjee2ksx/E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240627125310.2533622-4-stefan.klug@ideasonboard.com>","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>\n\t<20240627125310.2533622-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 3/3] apps: common: dng_writer: Support RAW10 and RAW12\n\tformat","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 27 Jun 2024 14:13:08 +0100","Message-ID":"<171949398879.3790642.16032748515224075886@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30100,"web_url":"https://patchwork.libcamera.org/comment/30100/","msgid":"","date":"2024-06-27T13:51:31","subject":"Re: [PATCH 3/3] apps: common: dng_writer: Support RAW10 and RAW12\n\tformat","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"On Thu, Jun 27, 2024 at 02:13:08PM +0100, Kieran Bingham wrote:\n> Quoting Stefan Klug (2024-06-27 13:51:11)\n> > Add support for RAW10 and RAW12 to the dng_writer. This is needed on\n> > imx8mp to produce tuning images. Both formats were tested on a debix\n> > som with a imx335.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/apps/common/dng_writer.cpp | 76 ++++++++++++++++++++++++++++++++++\n> > 1 file changed, 76 insertions(+)\n> > \n> > diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> > index 2cb320ff327b..162c41a84011 100644\n> > --- a/src/apps/common/dng_writer.cpp\n> > +++ b/src/apps/common/dng_writer.cpp\n> > @@ -136,6 +136,34 @@ void packScanlineRaw8(void *output, const void *input, unsigned int width)\n> > std::copy(in, in + width, out);\n> > }\n> > \n> > +void packScanlineRaw10(void *output, const void *input, unsigned int width)\n> > +{\n> > + const uint16_t *in = static_cast(input);\n> > + uint8_t *out = static_cast(output);\n> > +\n> > + for (unsigned int i = 0; i < width; i += 4) {\n> > + *out++ = (in[0] & 0x3fc) >> 2;\n> > + *out++ = (in[0] & 0x003) << 6 | (in[1] & 0x3f0) >> 4;\n> > + *out++ = (in[1] & 0x00f) << 4 | (in[2] & 0x3c0) >> 6;\n> > + *out++ = (in[2] & 0x03f) << 2 | (in[3] & 0x300) >> 8;\n> > + *out++ = (in[3] & 0x0ff);\n> > + in += 4;\n> > + }\n> > +}\n> > +\n> > +void packScanlineRaw12(void *output, const void *input, unsigned int width)\n> > +{\n> > + const uint16_t *in = static_cast(input);\n> > + uint8_t *out = static_cast(output);\n> > +\n> > + for (unsigned int i = 0; i < width; i += 2) {\n> > + *out++ = (in[0] & 0xff0) >> 4;\n> > + *out++ = (in[0] & 0x00f) << 4 | (in[1] & 0xf00) >> 8;\n> > + *out++ = (in[1] & 0x0ff);\n> > + in += 2;\n> > + }\n> > +}\n> > +\n> > void packScanlineRaw16(void *output, const void *input, unsigned int width)\n> > {\n> > const uint16_t *in = static_cast(input);\n> > @@ -341,6 +369,54 @@ const std::map formatInfo = {\n> > .packScanline = packScanlineRaw8,\n> > .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > + { formats::SBGGR10, {\n> > + .bitsPerSample = 10,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> \n> \tBlue, Green, Green, Red ?\n\nOuch, you are so right.\n\nWill fix.\n\nCheers,\nStefan\n\n> \n> > + .packScanline = packScanlineRaw10,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SGBRG10, {\n> > + .bitsPerSample = 10,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> \n> \tGreen, Blue, Red, Green ?\n> \n> Same for the others ... ?\n> \n> > + .packScanline = packScanlineRaw10,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SGRBG10, {\n> > + .bitsPerSample = 10,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > + .packScanline = packScanlineRaw10,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SRGGB10, {\n> > + .bitsPerSample = 10,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > + .packScanline = packScanlineRaw10,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SBGGR12, {\n> > + .bitsPerSample = 12,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > + .packScanline = packScanlineSBGGR12,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SGBRG12, {\n> > + .bitsPerSample = 12,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > + .packScanline = packScanlineSBGGR12,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SGRBG12, {\n> > + .bitsPerSample = 12,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > + .packScanline = packScanlineSBGGR12,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > + { formats::SRGGB12, {\n> > + .bitsPerSample = 12,\n> > + .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > + .packScanline = packScanlineSBGGR12,\n> > + .thumbScanline = thumbScanlineRawXX,\n> > + } },\n> > { formats::SBGGR16, {\n> > .bitsPerSample = 16,\n> > .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9B99BD87C\n\tfor ;\n\tThu, 27 Jun 2024 13:51:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A89962C9B;\n\tThu, 27 Jun 2024 15:51:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1941062C95\n\tfor ;\n\tThu, 27 Jun 2024 15:51:34 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6248:8b4b:42bc:2b84])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A2B4593;\n\tThu, 27 Jun 2024 15:51:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ggJczUDn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719496270;\n\tbh=PaFPX6jIWiHSQoWy/3bU9MGkNhCXCLo+OmmnUU7IEsw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ggJczUDnH9MQB7GO5jiGP0QecbEymi31VuvAwhyjVQJ8U/I1CyVOL+XDRkj2nlJnL\n\tA/oGfbNQfEoGvHOhggMRygAwq3w+YeoeGLEIEo9+O5zWcZJbYKJjFI/ZyGyYoq0PLu\n\t34S1xfTTYQAoRJ0LAyqVYv+3i5H17xEruHMP42L8=","Date":"Thu, 27 Jun 2024 15:51:31 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] apps: common: dng_writer: Support RAW10 and RAW12\n\tformat","Message-ID":"","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>\n\t<20240627125310.2533622-4-stefan.klug@ideasonboard.com>\n\t<171949398879.3790642.16032748515224075886@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171949398879.3790642.16032748515224075886@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]