{"id":20428,"url":"https://patchwork.libcamera.org/api/patches/20428/?format=json","web_url":"https://patchwork.libcamera.org/patch/20428/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627125310.2533622-4-stefan.klug@ideasonboard.com>","date":"2024-06-27T12:51:11","name":"[3/3] apps: common: dng_writer: Support RAW10 and RAW12 format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8b2c466bc6371faaf90b7a6f03d5d40f9155527a","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20428/mbox/","series":[{"id":4423,"url":"https://patchwork.libcamera.org/api/series/4423/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4423","date":"2024-06-27T12:51:08","name":"dng_writer: Add support for RAW10 and RAW 12","version":1,"mbox":"https://patchwork.libcamera.org/series/4423/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20428/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20428/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 771C5BD87C\n\tfor ;\n\tThu, 27 Jun 2024 12:53:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32AFF62E18;\n\tThu, 27 Jun 2024 14:53:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C8F662C98\n\tfor ;\n\tThu, 27 Jun 2024 14:53:46 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6248:8b4b:42bc:2b84])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 858DC7E0;\n\tThu, 27 Jun 2024 14:53:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KRy0hpG3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719492802;\n\tbh=1/I4QbsQrEw/6g98aqGt8GE/jaKXSVL6AvIWKLKjNZg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KRy0hpG3AE5x8EB5ghdOSWcrqWhGB7Xg5zXoeTPvSxebF/H72VYINPQuAjaweAAb8\n\ttrmKCkzO6z46fxp/VT02Gz1iPo+ip2Tr4DZuXAu5a02RcA8ydsdZpwO7SizO6bfker\n\tBSverjxHslYit7LG5mgKw6pIkCkiyIuTft22tunQ=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 3/3] apps: common: dng_writer: Support RAW10 and RAW12 format","Date":"Thu, 27 Jun 2024 14:51:11 +0200","Message-ID":"<20240627125310.2533622-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add support for RAW10 and RAW12 to the dng_writer. This is needed on\nimx8mp to produce tuning images. Both formats were tested on a debix\nsom with a imx335.\n\nSigned-off-by: Stefan Klug \n---\n src/apps/common/dng_writer.cpp | 76 ++++++++++++++++++++++++++++++++++\n 1 file changed, 76 insertions(+)","diff":"diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex 2cb320ff327b..162c41a84011 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -136,6 +136,34 @@ void packScanlineRaw8(void *output, const void *input, unsigned int width)\n \tstd::copy(in, in + width, out);\n }\n \n+void packScanlineRaw10(void *output, const void *input, unsigned int width)\n+{\n+\tconst uint16_t *in = static_cast(input);\n+\tuint8_t *out = static_cast(output);\n+\n+\tfor (unsigned int i = 0; i < width; i += 4) {\n+\t\t*out++ = (in[0] & 0x3fc) >> 2;\n+\t\t*out++ = (in[0] & 0x003) << 6 | (in[1] & 0x3f0) >> 4;\n+\t\t*out++ = (in[1] & 0x00f) << 4 | (in[2] & 0x3c0) >> 6;\n+\t\t*out++ = (in[2] & 0x03f) << 2 | (in[3] & 0x300) >> 8;\n+\t\t*out++ = (in[3] & 0x0ff);\n+\t\tin += 4;\n+\t}\n+}\n+\n+void packScanlineRaw12(void *output, const void *input, unsigned int width)\n+{\n+\tconst uint16_t *in = static_cast(input);\n+\tuint8_t *out = static_cast(output);\n+\n+\tfor (unsigned int i = 0; i < width; i += 2) {\n+\t\t*out++ = (in[0] & 0xff0) >> 4;\n+\t\t*out++ = (in[0] & 0x00f) << 4 | (in[1] & 0xf00) >> 8;\n+\t\t*out++ = (in[1] & 0x0ff);\n+\t\tin += 2;\n+\t}\n+}\n+\n void packScanlineRaw16(void *output, const void *input, unsigned int width)\n {\n \tconst uint16_t *in = static_cast(input);\n@@ -341,6 +369,54 @@ const std::map formatInfo = {\n \t\t.packScanline = packScanlineRaw8,\n \t\t.thumbScanline = thumbScanlineRawXX_CSI2P,\n \t} },\n+\t{ formats::SBGGR10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SGBRG10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SGRBG10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SRGGB10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SBGGR12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineSBGGR12,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SGBRG12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineSBGGR12,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SGRBG12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineSBGGR12,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n+\t{ formats::SRGGB12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineSBGGR12,\n+\t\t.thumbScanline = thumbScanlineRawXX,\n+\t} },\n \t{ formats::SBGGR16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n","prefixes":["3/3"]}