[{"id":30092,"web_url":"https://patchwork.libcamera.org/comment/30092/","msgid":"<171949310956.3790642.9366760393640968215@ping.linuxembedded.co.uk>","date":"2024-06-27T12:58:29","subject":"Re: [PATCH 1/3] apps: common: dng_writer: Rename packing functions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-06-27 13:51:09)\n> The old names lead to confusions. Rename to better express the intent.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/apps/common/dng_writer.cpp | 74 +++++++++++++++++-----------------\n> 1 file changed, 37 insertions(+), 37 deletions(-)\n> \n> diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> index d37b0d627cd1..88b225d3e099 100644\n> --- a/src/apps/common/dng_writer.cpp\n> +++ b/src/apps/common/dng_writer.cpp\n> @@ -128,7 +128,7 @@ struct Matrix3d {\n> \n> namespace {\n> \n> -void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw8(void *output, const void *input, unsigned int width)\n> {\n> const uint8_t *in = static_cast(input);\n> uint8_t *out = static_cast(output);\n> @@ -136,7 +136,7 @@ void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n> std::copy(in, in + width, out);\n> }\n> \n> -void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw16(void *output, const void *input, unsigned int width)\n> {\n> const uint16_t *in = static_cast(input);\n> uint16_t *out = static_cast(output);\n> @@ -144,7 +144,7 @@ void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n> std::copy(in, in + width, out);\n> }\n> \n> -void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw10_CSI2P(void *output, const void *input, unsigned int width)\n> {\n> const uint8_t *in = static_cast(input);\n> uint8_t *out = static_cast(output);\n> @@ -160,7 +160,7 @@ void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> }\n> }\n> \n> -void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n> +void packScanlineRaw12_CSI2P(void *output, const void *input, unsigned int width)\n> {\n> const uint8_t *in = static_cast(input);\n> uint8_t *out = static_cast(output);\n> @@ -174,7 +174,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n> }\n> }\n> \n> -void thumbScanlineSBGGRxxP(const FormatInfo &info, void *output,\n> +void thumbScanlineRawXX_CSI2P(const FormatInfo &info, void *output,\n\nDoes the XX add value here? I'd be tempted to drop this to thumbScanlineRaw_CSI2P\n\nBut eitherway\n\n\nReviewed-by: Kieran Bingham \n\n\n\n\n> const void *input, unsigned int width,\n> unsigned int stride)\n> {\n> @@ -296,98 +296,98 @@ const std::map formatInfo = {\n> { formats::SBGGR8, {\n> .bitsPerSample = 8,\n> .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> - .packScanline = packScanlineSBGGR8,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw8,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGBRG8, {\n> .bitsPerSample = 8,\n> .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR8,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw8,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGRBG8, {\n> .bitsPerSample = 8,\n> .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR8,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw8,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SRGGB8, {\n> .bitsPerSample = 8,\n> .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> - .packScanline = packScanlineSBGGR8,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw8,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SBGGR16, {\n> .bitsPerSample = 16,\n> .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> - .packScanline = packScanlineSBGGR16,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw16,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGBRG16, {\n> .bitsPerSample = 16,\n> .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR16,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw16,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGRBG16, {\n> .bitsPerSample = 16,\n> .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR16,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw16,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SRGGB16, {\n> .bitsPerSample = 16,\n> .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> - .packScanline = packScanlineSBGGR16,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw16,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SBGGR10_CSI2P, {\n> .bitsPerSample = 10,\n> .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> - .packScanline = packScanlineSBGGR10P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw10_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGBRG10_CSI2P, {\n> .bitsPerSample = 10,\n> .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR10P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw10_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGRBG10_CSI2P, {\n> .bitsPerSample = 10,\n> .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR10P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw10_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SRGGB10_CSI2P, {\n> .bitsPerSample = 10,\n> .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> - .packScanline = packScanlineSBGGR10P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw10_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SBGGR12_CSI2P, {\n> .bitsPerSample = 12,\n> .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> - .packScanline = packScanlineSBGGR12P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw12_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGBRG12_CSI2P, {\n> .bitsPerSample = 12,\n> .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR12P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw12_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SGRBG12_CSI2P, {\n> .bitsPerSample = 12,\n> .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> - .packScanline = packScanlineSBGGR12P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw12_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SRGGB12_CSI2P, {\n> .bitsPerSample = 12,\n> .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> - .packScanline = packScanlineSBGGR12P,\n> - .thumbScanline = thumbScanlineSBGGRxxP,\n> + .packScanline = packScanlineRaw12_CSI2P,\n> + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> } },\n> { formats::SBGGR10_IPU3, {\n> .bitsPerSample = 16,\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A871BDB1D\n\tfor ;\n\tThu, 27 Jun 2024 12:58:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5216362C99;\n\tThu, 27 Jun 2024 14:58:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA059619E8\n\tfor ;\n\tThu, 27 Jun 2024 14:58:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BAEDD2E0;\n\tThu, 27 Jun 2024 14:58:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uIxhY6tf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719493088;\n\tbh=xo54oTsITqEKJ3bGnkQtBaPXZGurQjIOMWQA8KugxtQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uIxhY6tfwFYe0VSrAl0Q4vlXFe5MYQx//j0zicLzVnDCYDwUeGEk1eQ2VwRohcFyy\n\tS0yswZKzCSG/QpfBeJmoEnAf/RSTs8XjblljrG6TjshtPd2SCWJyj9JEBcpuqbnBE+\n\t64oBPvHy+UdiiwxdIe9aU6cO3iRGu+rokoW3v3RY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240627125310.2533622-2-stefan.klug@ideasonboard.com>","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>\n\t<20240627125310.2533622-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 1/3] apps: common: dng_writer: Rename packing functions","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 27 Jun 2024 13:58:29 +0100","Message-ID":"<171949310956.3790642.9366760393640968215@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30093,"web_url":"https://patchwork.libcamera.org/comment/30093/","msgid":"<20240627130734.GA15017@pendragon.ideasonboard.com>","date":"2024-06-27T13:07:34","subject":"Re: [PATCH 1/3] apps: common: dng_writer: Rename packing functions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 27, 2024 at 01:58:29PM +0100, Kieran Bingham wrote:\n> Quoting Stefan Klug (2024-06-27 13:51:09)\n> > The old names lead to confusions. Rename to better express the intent.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/apps/common/dng_writer.cpp | 74 +++++++++++++++++-----------------\n> > 1 file changed, 37 insertions(+), 37 deletions(-)\n> > \n> > diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\n> > index d37b0d627cd1..88b225d3e099 100644\n> > --- a/src/apps/common/dng_writer.cpp\n> > +++ b/src/apps/common/dng_writer.cpp\n> > @@ -128,7 +128,7 @@ struct Matrix3d {\n> > \n> > namespace {\n> > \n> > -void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n> > +void packScanlineRaw8(void *output, const void *input, unsigned int width)\n> > {\n> > const uint8_t *in = static_cast(input);\n> > uint8_t *out = static_cast(output);\n> > @@ -136,7 +136,7 @@ void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n> > std::copy(in, in + width, out);\n> > }\n> > \n> > -void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n> > +void packScanlineRaw16(void *output, const void *input, unsigned int width)\n> > {\n> > const uint16_t *in = static_cast(input);\n> > uint16_t *out = static_cast(output);\n> > @@ -144,7 +144,7 @@ void packScanlineSBGGR16(void *output, const void *input, unsigned int width)\n> > std::copy(in, in + width, out);\n> > }\n> > \n> > -void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> > +void packScanlineRaw10_CSI2P(void *output, const void *input, unsigned int width)\n> > {\n> > const uint8_t *in = static_cast(input);\n> > uint8_t *out = static_cast(output);\n> > @@ -160,7 +160,7 @@ void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> > }\n> > }\n> > \n> > -void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n> > +void packScanlineRaw12_CSI2P(void *output, const void *input, unsigned int width)\n> > {\n> > const uint8_t *in = static_cast(input);\n> > uint8_t *out = static_cast(output);\n> > @@ -174,7 +174,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n> > }\n> > }\n> > \n> > -void thumbScanlineSBGGRxxP(const FormatInfo &info, void *output,\n> > +void thumbScanlineRawXX_CSI2P(const FormatInfo &info, void *output,\n> \n> Does the XX add value here? I'd be tempted to drop this to thumbScanlineRaw_CSI2P\n> \n> But eitherway\n> \n> \n> Reviewed-by: Kieran Bingham \n\nI think I have a slight preference for s/XX//, but either way,\n\nReviewed-by: Laurent Pinchart \n\n> > const void *input, unsigned int width,\n> > unsigned int stride)\n> > {\n> > @@ -296,98 +296,98 @@ const std::map formatInfo = {\n> > { formats::SBGGR8, {\n> > .bitsPerSample = 8,\n> > .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > - .packScanline = packScanlineSBGGR8,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw8,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGBRG8, {\n> > .bitsPerSample = 8,\n> > .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR8,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw8,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGRBG8, {\n> > .bitsPerSample = 8,\n> > .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR8,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw8,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SRGGB8, {\n> > .bitsPerSample = 8,\n> > .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > - .packScanline = packScanlineSBGGR8,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw8,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SBGGR16, {\n> > .bitsPerSample = 16,\n> > .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > - .packScanline = packScanlineSBGGR16,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw16,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGBRG16, {\n> > .bitsPerSample = 16,\n> > .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR16,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw16,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGRBG16, {\n> > .bitsPerSample = 16,\n> > .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR16,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw16,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SRGGB16, {\n> > .bitsPerSample = 16,\n> > .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > - .packScanline = packScanlineSBGGR16,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw16,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SBGGR10_CSI2P, {\n> > .bitsPerSample = 10,\n> > .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > - .packScanline = packScanlineSBGGR10P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw10_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGBRG10_CSI2P, {\n> > .bitsPerSample = 10,\n> > .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR10P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw10_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGRBG10_CSI2P, {\n> > .bitsPerSample = 10,\n> > .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR10P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw10_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SRGGB10_CSI2P, {\n> > .bitsPerSample = 10,\n> > .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > - .packScanline = packScanlineSBGGR10P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw10_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SBGGR12_CSI2P, {\n> > .bitsPerSample = 12,\n> > .pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > - .packScanline = packScanlineSBGGR12P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw12_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGBRG12_CSI2P, {\n> > .bitsPerSample = 12,\n> > .pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR12P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw12_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SGRBG12_CSI2P, {\n> > .bitsPerSample = 12,\n> > .pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> > - .packScanline = packScanlineSBGGR12P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw12_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SRGGB12_CSI2P, {\n> > .bitsPerSample = 12,\n> > .pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > - .packScanline = packScanlineSBGGR12P,\n> > - .thumbScanline = thumbScanlineSBGGRxxP,\n> > + .packScanline = packScanlineRaw12_CSI2P,\n> > + .thumbScanline = thumbScanlineRawXX_CSI2P,\n> > } },\n> > { formats::SBGGR10_IPU3, {\n> > .bitsPerSample = 16,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5250EBD87C\n\tfor ;\n\tThu, 27 Jun 2024 13:07:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BCA162C9A;\n\tThu, 27 Jun 2024 15:07:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49BD3619E8\n\tfor ;\n\tThu, 27 Jun 2024 15:07:56 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [193.209.96.36])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AFA1593;\n\tThu, 27 Jun 2024 15:07:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YPlvD7Rk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719493652;\n\tbh=AqsgfY9bn91JCIjvl9dIILtwan6lLmuXJh4jknYSZ6M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YPlvD7RkTpJ7jrRenlDXQdgZAeBQLg5g5qObH05dbk4aICcke2wzq1yClujFmotg1\n\t2ywYQ0NhjwWJ4Q6PJx8u1lnFslAXRCPa7GyiHQb/XbrKoJ6/zrN2bUDtLwTNQBMUYa\n\tLYAL1zMLSuTx+sBIsLlCJrDyjH0ziZ/alZPGdCUI=","Date":"Thu, 27 Jun 2024 16:07:34 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] apps: common: dng_writer: Rename packing functions","Message-ID":"<20240627130734.GA15017@pendragon.ideasonboard.com>","References":"<20240627125310.2533622-1-stefan.klug@ideasonboard.com>\n\t<20240627125310.2533622-2-stefan.klug@ideasonboard.com>\n\t<171949310956.3790642.9366760393640968215@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171949310956.3790642.9366760393640968215@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]