[{"id":30160,"web_url":"https://patchwork.libcamera.org/comment/30160/","msgid":"<7e471a0a-d91e-4a52-b491-4e5daf05ad24@ideasonboard.com>","date":"2024-06-29T06:57:39","subject":"Re: [PATCH v3 8/9] libcamera: v4l2-subdevice: Add Mali C55 media bus\n\tformats","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch\n\nOn 26/06/24 7:33 pm, Jacopo Mondi wrote:\n> Add support in the mediaBusFormatInfo map in the v4l2-subdevice.c file\n> support for the media bus formats used by the Mali C55 ISP.\n\ns/support//\n>\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/v4l2_subdevice.cpp | 42 ++++++++++++++++++++++++++++++++\n> 1 file changed, 42 insertions(+)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 82824433726f..6f154caf5b0e 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -189,6 +189,20 @@ const std::map mediaBusFormatInfo{\n> \t\t.bitsPerPixel = 24,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t} },\n> +\t{ MEDIA_BUS_FMT_RGB121212_1X36, {\n> +\t\t.name = \"RGB121212_1X36\",\n> +\t\t.code = MEDIA_BUS_FMT_RGB121212_1X36,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 36,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_RGB202020_1X60, {\n> +\t\t.name = \"RGB202020_1X60\",\n> +\t\t.code = MEDIA_BUS_FMT_RGB202020_1X60,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 60,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t} },\n> \t{ MEDIA_BUS_FMT_ARGB8888_1X32, {\n> \t\t.name = \"ARGB8888_1X32\",\n> \t\t.code = MEDIA_BUS_FMT_ARGB8888_1X32,\n> @@ -679,6 +693,34 @@ const std::map mediaBusFormatInfo{\n> \t\t.bitsPerPixel = 16,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> \t} },\n> +\t{ MEDIA_BUS_FMT_SBGGR20_1X20, {\n> +\t\t.name = \"SBGGR20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SBGGR20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGBRG20_1X20, {\n> +\t\t.name = \"SGBRG20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SGBRG20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGRBG20_1X20, {\n> +\t\t.name = \"SGRBG20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SGRBG20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SRGGB20_1X20, {\n> +\t\t.name = \"SRGGB20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SRGGB20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> \t/* \\todo Clarify colour encoding for HSV formats */\n> \t{ MEDIA_BUS_FMT_AHSV8888_1X32, {\n> \t\t.name = \"AHSV8888_1X32\",","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B084BDB1D\n\tfor ;\n\tSat, 29 Jun 2024 06:57:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18CB562C9A;\n\tSat, 29 Jun 2024 08:57:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 048E562C95\n\tfor ;\n\tSat, 29 Jun 2024 08:57:41 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 570274B0;\n\tSat, 29 Jun 2024 08:57:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Roj6Vi25\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719644235;\n\tbh=noz807vry5zcdtZStHSFTREHdONGl2js3HpNQmbWIrc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Roj6Vi25r2VMmdekjMcYVbRBWxAKozheG8+LA4aDzDHn8ntlIdVCfZWR0yooEGoyu\n\tXDSLjG3DdRwwEUYrNOJaQT5YzLAVwLMjvUi9urRdDB+cwi0Bt2BJa54CPszU7SbYlP\n\t2xOAXA5x3NEw0bzxi/gGB9ILQN/mGGZ9golQ2+PQ=","Message-ID":"<7e471a0a-d91e-4a52-b491-4e5daf05ad24@ideasonboard.com>","Date":"Sat, 29 Jun 2024 12:27:39 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 8/9] libcamera: v4l2-subdevice: Add Mali C55 media bus\n\tformats","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-9-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240626140309.50052-9-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30376,"web_url":"https://patchwork.libcamera.org/comment/30376/","msgid":"","date":"2024-07-08T11:09:55","subject":"Re: [PATCH v3 8/9] libcamera: v4l2-subdevice: Add Mali C55 media bus\n\tformats","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 26/06/2024 15:03, Jacopo Mondi wrote:\n> Add support in the mediaBusFormatInfo map in the v4l2-subdevice.c file\n> support for the media bus formats used by the Mali C55 ISP.\n>\n> Signed-off-by: Jacopo Mondi \n> ---\nReviewed-by: Daniel Scally \n> src/libcamera/v4l2_subdevice.cpp | 42 ++++++++++++++++++++++++++++++++\n> 1 file changed, 42 insertions(+)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 82824433726f..6f154caf5b0e 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -189,6 +189,20 @@ const std::map mediaBusFormatInfo{\n> \t\t.bitsPerPixel = 24,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t} },\n> +\t{ MEDIA_BUS_FMT_RGB121212_1X36, {\n> +\t\t.name = \"RGB121212_1X36\",\n> +\t\t.code = MEDIA_BUS_FMT_RGB121212_1X36,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 36,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_RGB202020_1X60, {\n> +\t\t.name = \"RGB202020_1X60\",\n> +\t\t.code = MEDIA_BUS_FMT_RGB202020_1X60,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 60,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t} },\n> \t{ MEDIA_BUS_FMT_ARGB8888_1X32, {\n> \t\t.name = \"ARGB8888_1X32\",\n> \t\t.code = MEDIA_BUS_FMT_ARGB8888_1X32,\n> @@ -679,6 +693,34 @@ const std::map mediaBusFormatInfo{\n> \t\t.bitsPerPixel = 16,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> \t} },\n> +\t{ MEDIA_BUS_FMT_SBGGR20_1X20, {\n> +\t\t.name = \"SBGGR20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SBGGR20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGBRG20_1X20, {\n> +\t\t.name = \"SGBRG20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SGBRG20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGRBG20_1X20, {\n> +\t\t.name = \"SGRBG20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SGRBG20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SRGGB20_1X20, {\n> +\t\t.name = \"SRGGB20_1X20\",\n> +\t\t.code = MEDIA_BUS_FMT_SRGGB20_1X20,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 20,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> \t/* \\todo Clarify colour encoding for HSV formats */\n> \t{ MEDIA_BUS_FMT_AHSV8888_1X32, {\n> \t\t.name = \"AHSV8888_1X32\",","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23ABCBD87C\n\tfor ;\n\tMon, 8 Jul 2024 11:10:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB9F663361;\n\tMon, 8 Jul 2024 13:09:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 083A2619BB\n\tfor ;\n\tMon, 8 Jul 2024 13:09:58 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E531D01\n\tfor ;\n\tMon, 8 Jul 2024 13:09:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ByHutQoD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720436966;\n\tbh=jK4ZIYNzFYfZNh8LpkjVkFRIbJjJ/wtCvZ9nVmzbi1U=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ByHutQoDJq0DJB0HX1lS/HAHIvlzNn8vqALurHp/YGO4Gjo2vkvronIryrbn1w4Xr\n\t8mINTZ3rCTF/Fy4gBw4c/A4cWmbNpYKAl9vDlWqKOVQ/lCd1bNooTUFkiO3UYXFQ/e\n\tTFV0bdw8G1/WPSgmJZ+sE2zQjPJrJy6J/1+6CFwU=","Message-ID":"","Date":"Mon, 8 Jul 2024 12:09:55 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 8/9] libcamera: v4l2-subdevice: Add Mali C55 media bus\n\tformats","To":"libcamera-devel@lists.libcamera.org","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-9-jacopo.mondi@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240626140309.50052-9-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]