{"id":20421,"url":"https://patchwork.libcamera.org/api/patches/20421/?format=json","web_url":"https://patchwork.libcamera.org/patch/20421/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240626140309.50052-10-jacopo.mondi@ideasonboard.com>","date":"2024-06-26T14:03:05","name":"[v3,9/9] libcamera: mali-c55: Propagate CSI-2 format to ISP","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7b5b02f085acde7933ac317a1cef7eb6eabfda79","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20421/mbox/","series":[{"id":4420,"url":"https://patchwork.libcamera.org/api/series/4420/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4420","date":"2024-06-26T14:02:56","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":3,"mbox":"https://patchwork.libcamera.org/series/4420/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20421/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20421/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D8F0BDB1D\n\tfor ;\n\tWed, 26 Jun 2024 14:03:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D84862B6A;\n\tWed, 26 Jun 2024 16:03:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9212A62B6C\n\tfor ;\n\tWed, 26 Jun 2024 16:03:25 +0200 (CEST)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47D7FFD6;\n\tWed, 26 Jun 2024 16:03:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W9rVQ0TD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719410582;\n\tbh=X6gJynBagqREg3jCj3k+tgV+GY8axntkmX7HpkzqXvc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W9rVQ0TDEjwxuD9+PUWG6HlpZxDNMwpK3lWM+GoT+zAvQyzk22l+QNeBEYowRwnRC\n\tOU5iCjUHnJPBQWvTRMZVokYBLNzFRO/5X0BOSQtyFLlpBsEl1Ldqkz9h6tqOJJkEaY\n\t+rUp+XJqzTZC/abUNV8J8KjVXjQCScWM3/Ml0PNU=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[PATCH v3 9/9] libcamera: mali-c55: Propagate CSI-2 format to ISP","Date":"Wed, 26 Jun 2024 16:03:05 +0200","Message-ID":"<20240626140309.50052-10-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The latest version of the Mali C55 driver has changed the format\naccepted by the ISP sink pad to be the 20-bit wide.\n\nThe CSI-2 receiver handles the format expansion internally by\npropagating the sensor produced format from its sink to the 20-bit\nexpanded version on its source pad.\n\nInstead of re-applying the sensor format to the CSI-2 receiver source\npad (which is now an invalid operation) read from there the format\npropagated by the driver internally and further propagate it to the ISP\nsubdevice.\n\nSigned-off-by: Jacopo Mondi \n\n---\nLatest version of the Mali C55 support\nhttps://lore.kernel.org/linux-media/20240529152858.183799-1-dan.scally@ideasonboard.com/\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 28ad0172658c..156560c1d9bf 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -768,7 +768,7 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\tret = data->csi_->setFormat(1, &subdevFormat);\n+\t\tret = data->csi_->getFormat(1, &subdevFormat);\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n","prefixes":["v3","9/9"]}