[{"id":30159,"web_url":"https://patchwork.libcamera.org/comment/30159/","msgid":"<16d78766-2c8b-4893-aeb7-a21414c0ada3@ideasonboard.com>","date":"2024-06-29T06:55:55","subject":"Re: [PATCH v3 7/9] include: media-bus-formats: Add Mali-C55 mbus\n\tcodes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn 26/06/24 7:33 pm, Jacopo Mondi wrote:\n> Add media bus codes introduced by the Mali C55 ISP support to describe\n> the 20-bit input formats supported by the ISP.\n>\n> Add the following formats\n>\n> - MEDIA_BUS_FMT_RGB202020_1X60\n>\n> for processed input formats\n> https://lore.kernel.org/linux-media/20240529152858.183799-2-dan.scally@ideasonboard.com/\n>\n> - MEDIA_BUS_FMT_SBGGR20_1X20\n> MEDIA_BUS_FMT_SGBRG20_1X20\n> MEDIA_BUS_FMT_SGRBG20_1X20\n> MEDIA_BUS_FMT_SRGGB20_1X20\n>\n> for the RAW bayer input format\n> https://lore.kernel.org/linux-media/20240529152858.183799-3-dan.scally@ideasonboard.com/\n>\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Umang Jain \n> ---\n> include/linux/media-bus-format.h | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h\n> index d4c1d991014b..b6acf8c8e383 100644\n> --- a/include/linux/media-bus-format.h\n> +++ b/include/linux/media-bus-format.h\n> @@ -34,7 +34,7 @@\n> \n> #define MEDIA_BUS_FMT_FIXED\t\t\t0x0001\n> \n> -/* RGB - next is\t0x1026 */\n> +/* RGB - next is\t0x1027 */\n> #define MEDIA_BUS_FMT_RGB444_1X12\t\t0x1016\n> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE\t0x1001\n> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE\t0x1002\n> @@ -72,6 +72,7 @@\n> #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO\t0x1021\n> #define MEDIA_BUS_FMT_RGB121212_1X36\t\t0x1019\n> #define MEDIA_BUS_FMT_RGB161616_1X48\t\t0x101a\n> +#define MEDIA_BUS_FMT_RGB202020_1X60\t\t0x1026\n> \n> /* YUV (including grey) - next is\t0x202f */\n> #define MEDIA_BUS_FMT_Y8_1X8\t\t\t0x2001\n> @@ -121,7 +122,7 @@\n> #define MEDIA_BUS_FMT_YUV16_1X48\t\t0x202a\n> #define MEDIA_BUS_FMT_UYYVYY16_0_5X48\t\t0x202b\n> \n> -/* Bayer - next is\t0x3021 */\n> +/* Bayer - next is\t0x3025 */\n> #define MEDIA_BUS_FMT_SBGGR8_1X8\t\t0x3001\n> #define MEDIA_BUS_FMT_SGBRG8_1X8\t\t0x3013\n> #define MEDIA_BUS_FMT_SGRBG8_1X8\t\t0x3002\n> @@ -154,6 +155,10 @@\n> #define MEDIA_BUS_FMT_SGBRG16_1X16\t\t0x301e\n> #define MEDIA_BUS_FMT_SGRBG16_1X16\t\t0x301f\n> #define MEDIA_BUS_FMT_SRGGB16_1X16\t\t0x3020\n> +#define MEDIA_BUS_FMT_SBGGR20_1X20\t\t0x3021\n> +#define MEDIA_BUS_FMT_SGBRG20_1X20\t\t0x3022\n> +#define MEDIA_BUS_FMT_SGRBG20_1X20\t\t0x3023\n> +#define MEDIA_BUS_FMT_SRGGB20_1X20\t\t0x3024\n> \n> /* JPEG compressed formats - next is\t0x4002 */\n> #define MEDIA_BUS_FMT_JPEG_1X8\t\t\t0x4001","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16A94BDB1D\n\tfor ;\n\tSat, 29 Jun 2024 06:56:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7521662C9A;\n\tSat, 29 Jun 2024 08:56:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A7AF62C95\n\tfor ;\n\tSat, 29 Jun 2024 08:56:00 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88A304B0;\n\tSat, 29 Jun 2024 08:55:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R1DnixM0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719644135;\n\tbh=uxN+mrdFhFtWvk3KcBseKjJTLBCOjiH/XYKR/6u1cGo=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=R1DnixM038AJK8y3S4jfBm4UkIT+lOe4UP6/oePgPNej/zTrxbwu+z1GZ1dOYFS36\n\tdJNKqoX1SotJJ8Utb9NIh/KnCLzmvab1EetVCAetfDjsClGAIKijoXKcDjMl7pda6z\n\t2Lg35VWxbrQErR7FifjYAejC/u1HBHzZ0srIWqgM=","Message-ID":"<16d78766-2c8b-4893-aeb7-a21414c0ada3@ideasonboard.com>","Date":"Sat, 29 Jun 2024 12:25:55 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 7/9] include: media-bus-formats: Add Mali-C55 mbus\n\tcodes","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-8-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240626140309.50052-8-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30374,"web_url":"https://patchwork.libcamera.org/comment/30374/","msgid":"","date":"2024-07-08T10:56:13","subject":"Re: [PATCH v3 7/9] include: media-bus-formats: Add Mali-C55 mbus\n\tcodes","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Jacopo - thanks for the patch\n\nOn 26/06/2024 15:03, Jacopo Mondi wrote:\n> Add media bus codes introduced by the Mali C55 ISP support to describe\n> the 20-bit input formats supported by the ISP.\n>\n> Add the following formats\n>\n> - MEDIA_BUS_FMT_RGB202020_1X60\n>\n> for processed input formats\n> https://lore.kernel.org/linux-media/20240529152858.183799-2-dan.scally@ideasonboard.com/\n>\n> - MEDIA_BUS_FMT_SBGGR20_1X20\n> MEDIA_BUS_FMT_SGBRG20_1X20\n> MEDIA_BUS_FMT_SGRBG20_1X20\n> MEDIA_BUS_FMT_SRGGB20_1X20\n>\n> for the RAW bayer input format\n> https://lore.kernel.org/linux-media/20240529152858.183799-3-dan.scally@ideasonboard.com/\n>\n> Signed-off-by: Jacopo Mondi \n> ---\nReviewed-by: Daniel Scally \n> include/linux/media-bus-format.h | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h\n> index d4c1d991014b..b6acf8c8e383 100644\n> --- a/include/linux/media-bus-format.h\n> +++ b/include/linux/media-bus-format.h\n> @@ -34,7 +34,7 @@\n> \n> #define MEDIA_BUS_FMT_FIXED\t\t\t0x0001\n> \n> -/* RGB - next is\t0x1026 */\n> +/* RGB - next is\t0x1027 */\n> #define MEDIA_BUS_FMT_RGB444_1X12\t\t0x1016\n> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE\t0x1001\n> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE\t0x1002\n> @@ -72,6 +72,7 @@\n> #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO\t0x1021\n> #define MEDIA_BUS_FMT_RGB121212_1X36\t\t0x1019\n> #define MEDIA_BUS_FMT_RGB161616_1X48\t\t0x101a\n> +#define MEDIA_BUS_FMT_RGB202020_1X60\t\t0x1026\n> \n> /* YUV (including grey) - next is\t0x202f */\n> #define MEDIA_BUS_FMT_Y8_1X8\t\t\t0x2001\n> @@ -121,7 +122,7 @@\n> #define MEDIA_BUS_FMT_YUV16_1X48\t\t0x202a\n> #define MEDIA_BUS_FMT_UYYVYY16_0_5X48\t\t0x202b\n> \n> -/* Bayer - next is\t0x3021 */\n> +/* Bayer - next is\t0x3025 */\n> #define MEDIA_BUS_FMT_SBGGR8_1X8\t\t0x3001\n> #define MEDIA_BUS_FMT_SGBRG8_1X8\t\t0x3013\n> #define MEDIA_BUS_FMT_SGRBG8_1X8\t\t0x3002\n> @@ -154,6 +155,10 @@\n> #define MEDIA_BUS_FMT_SGBRG16_1X16\t\t0x301e\n> #define MEDIA_BUS_FMT_SGRBG16_1X16\t\t0x301f\n> #define MEDIA_BUS_FMT_SRGGB16_1X16\t\t0x3020\n> +#define MEDIA_BUS_FMT_SBGGR20_1X20\t\t0x3021\n> +#define MEDIA_BUS_FMT_SGBRG20_1X20\t\t0x3022\n> +#define MEDIA_BUS_FMT_SGRBG20_1X20\t\t0x3023\n> +#define MEDIA_BUS_FMT_SRGGB20_1X20\t\t0x3024\n> \n> /* JPEG compressed formats - next is\t0x4002 */\n> #define MEDIA_BUS_FMT_JPEG_1X8\t\t\t0x4001","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 672DEBD87C\n\tfor ;\n\tMon, 8 Jul 2024 10:56:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6EE26333F;\n\tMon, 8 Jul 2024 12:56:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6D9C619BB\n\tfor ;\n\tMon, 8 Jul 2024 12:56:16 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EA604C9\n\tfor ;\n\tMon, 8 Jul 2024 12:55:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eX18m7MM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720436145;\n\tbh=KMUtlZYCy0mYH2sbEK1YuSxL6/US43DOFCRHs1px6jo=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=eX18m7MM1A/tvKACKPtPLOtmFDAMkABHT5qPI3fOoHU64AEr5HwBu5/gu1u4AbSlN\n\tRAo25CGoD8HhY54X1JKFlBsPATgDEZDetuFWcn9srbMvh5sBHLOUsN86xhDoONeafJ\n\t6XMT7KOKqXPGE3XJnSX3oSkJrjUG5ujMGdpDe8X0=","Message-ID":"","Date":"Mon, 8 Jul 2024 11:56:13 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 7/9] include: media-bus-formats: Add Mali-C55 mbus\n\tcodes","To":"libcamera-devel@lists.libcamera.org","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-8-jacopo.mondi@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240626140309.50052-8-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]