[{"id":30162,"web_url":"https://patchwork.libcamera.org/comment/30162/","msgid":"<2e50076c-aee8-4db0-bac8-f2bebf5276b8@ideasonboard.com>","date":"2024-06-29T09:58:16","subject":"Re: [PATCH v3 6/9] libcamera: mali-c55: Add stride and size to\n\trawConfig","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo, Dan\n\nOn 26/06/24 7:33 pm, Jacopo Mondi wrote:\n> From: Daniel Scally \n>\n> Complete the RAW StreamConfiguration by populating the frame stride and\n> the frame size.\n>\n> Set the minimum required alignment to 4 bytes as the Mali C55 ISP output\n> expands RAW output to 16 bits and a RAW Bayer macro-pixel requires\n> two samples to be complete.\n>\n> Signed-off-by: Daniel Scally \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 877a156ccb84..28ad0172658c 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -367,6 +367,10 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \n> \t\tmaxSize = rawSize;\n> \n> +\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n> +\t\trawConfig->stride = info.stride(rawConfig->size.width, 0, 4);\n> +\t\trawConfig->frameSize = info.frameSize(rawConfig->size, 4);\n> +\n> \t\trawConfig->setStream(const_cast(&data_->frStream_));\n> \t\tfrPipeAvailable = false;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8715EBDB1D\n\tfor ;\n\tSat, 29 Jun 2024 09:58:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24C2D62C99;\n\tSat, 29 Jun 2024 11:58:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44072619D5\n\tfor ;\n\tSat, 29 Jun 2024 11:58:23 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0D624B0;\n\tSat, 29 Jun 2024 11:57:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SV05pZ/X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719655077;\n\tbh=Eh81LAnxa0SfsyscchNrUWBjFUbHRyH0qILEJrjrr8A=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=SV05pZ/XJxfN5qTvQg9t4mIZGrblqOTbdMN0mZd28TptQLQzQ2owM+5FysSKhpZhM\n\t9LELjOwPvQNEd8cKqkP/r3PH596IDQ6OigcKJDWadp8G+07Yd9B6Q5uJJ3B/sKGlxD\n\tCjcIYAARhkYAwEUUuEpDp0Cw7zITbDBQcQ8BF0F0=","Message-ID":"<2e50076c-aee8-4db0-bac8-f2bebf5276b8@ideasonboard.com>","Date":"Sat, 29 Jun 2024 15:28:16 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 6/9] libcamera: mali-c55: Add stride and size to\n\trawConfig","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tKieran Bingham ","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-7-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240626140309.50052-7-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]