[{"id":30158,"web_url":"https://patchwork.libcamera.org/comment/30158/","msgid":"","date":"2024-06-29T06:45:24","subject":"Re: [PATCH v3 3/9] libcamera: mali-c55: Init camera properties","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Dan and Jacopo,\n\nOn 26/06/24 7:32 pm, Jacopo Mondi wrote:\n> From: Daniel Scally \n>\n> Initialise the camera properties using the CameraSensor properties.\n>\n> Signed-off-by: Daniel Scally \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Kieran Bingham \n\nLGTM,\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index d1ae1a61d5a9..bffd842c2af1 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -965,7 +965,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n> \t\tif (data->init())\n> \t\t\treturn false;\n> \n> -\t\t/* \\todo: Init properties and controls. */\n> +\t\tdata->properties_ = data->sensor_->properties();\n> \n> \t\tregisterMaliCamera(std::move(data), sensor->name());\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A116BD87C\n\tfor ;\n\tSat, 29 Jun 2024 06:45:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C7F762C9B;\n\tSat, 29 Jun 2024 08:45:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DDEF62C95\n\tfor ;\n\tSat, 29 Jun 2024 08:45:26 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B6554B0;\n\tSat, 29 Jun 2024 08:45:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c/7sqjYW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719643501;\n\tbh=jkeM6Gd7R8mntYrRXoywhPhW2vFBZIr5XOAzY3aXaWs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=c/7sqjYWRoxAXTj2hR2rx+t8dpn3vEikTe5qpDFnAy9Ey2h8C2Qi9Oz2Qegb4cf3P\n\tLWLdJuHMesMm3QPkSNb8cTzoTyJpyQpCFDPCaDFge71EQHRVFXh/XfIrXfNTxnDS3g\n\tX5RjPk5CDausFT578sO4nYHDjuVl64toyhYwbwA4=","Message-ID":"","Date":"Sat, 29 Jun 2024 12:15:24 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 3/9] libcamera: mali-c55: Init camera properties","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tKieran Bingham ","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-4-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240626140309.50052-4-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]