{"id":20416,"url":"https://patchwork.libcamera.org/api/patches/20416/?format=json","web_url":"https://patchwork.libcamera.org/patch/20416/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240626140309.50052-4-jacopo.mondi@ideasonboard.com>","date":"2024-06-26T14:02:59","name":"[v3,3/9] libcamera: mali-c55: Init camera properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1aca73ed991770979887e9913c105c729c720980","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20416/mbox/","series":[{"id":4420,"url":"https://patchwork.libcamera.org/api/series/4420/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4420","date":"2024-06-26T14:02:56","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":3,"mbox":"https://patchwork.libcamera.org/series/4420/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20416/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20416/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 648F6BDB1D\n\tfor ;\n\tWed, 26 Jun 2024 14:03:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C514D62B64;\n\tWed, 26 Jun 2024 16:03:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2092262B49\n\tfor ;\n\tWed, 26 Jun 2024 16:03:23 +0200 (CEST)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B825C1237;\n\tWed, 26 Jun 2024 16:02:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lBD97S78\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719410580;\n\tbh=jgYwYoDGRGixIJ/WZJZiadl0tEs1luH3Fe9Sy2Hl0uc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lBD97S78s7J4H6qTlmGdUiBOFjUELVD9ttreR031JPAeCFGc2P0g06Fawa1cLZwBB\n\tucM/ut7BsLrt7MVR7YuC/YE4IcqpuKKIhj6xvFuKpVdJWW8pNUQfbMWqRfzeuIUZrk\n\te/pU+eZCd2mvdqi885g3tLNhW6kRPAocYqQitsqU=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tJacopo Mondi ,\n\tKieran Bingham ","Subject":"[PATCH v3 3/9] libcamera: mali-c55: Init camera properties","Date":"Wed, 26 Jun 2024 16:02:59 +0200","Message-ID":"<20240626140309.50052-4-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Daniel Scally \n\nInitialise the camera properties using the CameraSensor properties.\n\nSigned-off-by: Daniel Scally \nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex d1ae1a61d5a9..bffd842c2af1 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -965,7 +965,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tif (data->init())\n \t\t\treturn false;\n \n-\t\t/* \\todo: Init properties and controls. */\n+\t\tdata->properties_ = data->sensor_->properties();\n \n \t\tregisterMaliCamera(std::move(data), sensor->name());\n \t}\n","prefixes":["v3","3/9"]}