[{"id":30156,"web_url":"https://patchwork.libcamera.org/comment/30156/","msgid":"<082e2659-6f0f-4c7d-b988-931303a5327e@ideasonboard.com>","date":"2024-06-29T06:31:19","subject":"Re: [PATCH v3 1/9] libcamera: mali-c55: Limit max size to sensor\n\tresolution","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo\n\nThank you for the patch\n\nOn 26/06/24 7:32 pm, Jacopo Mondi wrote:\n> The Mali C55 ISP cannot upscale. The maximum allowed output size\n> is the sensor's resolution.\n>\n> For RAW streams this is already handled in adjustRawSizes(), while\n> for processed streams the maximum allowed resolution was wrongly\n> set to the ISP maximum output size (8192x8192).\n>\n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 45c71c1dd619..1c1fef2337f0 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -342,7 +342,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \t\trawConfig = &config;\n> \t}\n> \n> -\tSize maxSize = kMaliC55MaxSize;\n> +\t/*\n> +\t * The C55 can not upscale. Limit the configuration to the ISP\n> +\t * capabilities and the sensor resolution.\n> +\t */\n> +\tSize maxSize = kMaliC55MaxSize.boundedTo(data_->resolution());\n> \tif (rawConfig) {\n> \t\t/*\n> \t\t * \\todo Take into account the Bayer components ordering once","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D61B3BDB1D\n\tfor ;\n\tSat, 29 Jun 2024 06:31:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FF5362C99;\n\tSat, 29 Jun 2024 08:31:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7393619C7\n\tfor ;\n\tSat, 29 Jun 2024 08:31:24 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9ABE4B0;\n\tSat, 29 Jun 2024 08:30:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P10cA0Og\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719642659;\n\tbh=T2E8ySUN24CFU5likgH9K/2m/9WBFmNl83up/GgHSf4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=P10cA0Og4O39XrFC5qBtKp95JQUqJ5PQAo0W+fpvXlIbHhvodR5ct2Jg5D91dwC5q\n\tVaSyvdhhaG2fNMHiakjHkJ8dU/RdnRDY9Drtm7aerQ7Lcx2mMtjnih6AITFNtxMzqL\n\tmomzL7QrMb1SU+YlIEV4ja3LRPz+0gL1ruRrYRPM=","Message-ID":"<082e2659-6f0f-4c7d-b988-931303a5327e@ideasonboard.com>","Date":"Sat, 29 Jun 2024 12:01:19 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/9] libcamera: mali-c55: Limit max size to sensor\n\tresolution","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","References":"<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>\n\t<20240626140309.50052-2-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240626140309.50052-2-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]