[{"id":30110,"web_url":"https://patchwork.libcamera.org/comment/30110/","msgid":"<55283565-4014-47e9-be91-dcbb1101c5d3@ideasonboard.com>","date":"2024-06-28T03:41:06","subject":"Re: [PATCH 05/19] libcamera: software_isp: Let IPASoftSimple inherit\n\tModule","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan\n\nThank you for the patch.\n\nOn 26/06/24 12:50 pm, Milan Zamazal wrote:\n> The Module class is a base class for All IPA modules.\n\nnit: \"In addition, implement logPrefix() for the softIPA.\"\n>\n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/soft_simple.cpp | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index b7746ce0..04f283c8 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -30,6 +30,7 @@\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> #include \"black_level.h\"\n> +#include \"module.h\"\n> \n> namespace libcamera {\n> LOG_DEFINE_CATEGORY(IPASoft)\n> @@ -54,7 +55,7 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n> */\n> static constexpr float kExposureSatisfactory = 0.2;\n> \n> -class IPASoftSimple : public ipa::soft::IPASoftInterface\n> +class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n> {\n> public:\n> \tIPASoftSimple()\n> @@ -76,6 +77,9 @@ public:\n> \n> \tvoid processStats(const ControlList &sensorControls) override;\n> \n> +protected:\n> +\tstd::string logPrefix() const override;\n> +\n> private:\n> \tvoid updateExposure(double exposureMSV);\n> \n> @@ -421,6 +425,11 @@ void IPASoftSimple::updateExposure(double exposureMSV)\n> \tagain_ = std::clamp(again_, againMin_, againMax_);\n> }\n> \n> +std::string IPASoftSimple::logPrefix() const\n> +{\n> +\treturn \"soft\";\n\nmy preference here would \"IPASoft\" but let's see what others think...\n\nReviewed-by: Umang Jain \n> +}\n> +\n> } /* namespace ipa::soft */\n> \n> /*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61DD5BDB1D\n\tfor ;\n\tFri, 28 Jun 2024 03:41:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A29D062C98;\n\tFri, 28 Jun 2024 05:41:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 867BF62C98\n\tfor ;\n\tFri, 28 Jun 2024 05:41:11 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A8A2BEB;\n\tFri, 28 Jun 2024 05:40:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ORHlY0h1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719546047;\n\tbh=QvzmvReAZXC6sUWOVP6+/Y8wBO50y6LSFIe70pnFOj8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ORHlY0h1PxjKbGUu1rcO+vgn07sJuo4iOmeqhabhK6UwYoAXLEnp+m6u/lidAYm3W\n\tyTLR5kssvmUhLEzoU/31cVxiaLlMnYw5DGdOL5FTcDxAOrS+uVNMfsfOw/kd+Z4fmp\n\tZJZ9V4UzZhkz4cWi8tzakT+GYxDq23R150E60Y9Y=","Message-ID":"<55283565-4014-47e9-be91-dcbb1101c5d3@ideasonboard.com>","Date":"Fri, 28 Jun 2024 09:11:06 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 05/19] libcamera: software_isp: Let IPASoftSimple inherit\n\tModule","Content-Language":"en-US","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240626072100.55497-1-mzamazal@redhat.com>\n\t<20240626072100.55497-6-mzamazal@redhat.com>","From":"Umang Jain ","In-Reply-To":"<20240626072100.55497-6-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30277,"web_url":"https://patchwork.libcamera.org/comment/30277/","msgid":"<87o77eju51.fsf@redhat.com>","date":"2024-07-03T16:51:54","subject":"Re: [PATCH 05/19] libcamera: software_isp: Let IPASoftSimple\n\tinherit Module","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Umang,\n\nthank you for your reviews.\n\nUmang Jain writes:\n\n> Hi Milan\n>\n> Thank you for the patch.\n>\n> On 26/06/24 12:50 pm, Milan Zamazal wrote:\n>> The Module class is a base class for All IPA modules.\n>\n> nit: \"In addition, implement logPrefix() for the softIPA.\"\n>>\n>> Signed-off-by: Milan Zamazal \n>> ---\n>> src/ipa/simple/soft_simple.cpp | 11 ++++++++++-\n>> 1 file changed, 10 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n>> index b7746ce0..04f283c8 100644\n>> --- a/src/ipa/simple/soft_simple.cpp\n>> +++ b/src/ipa/simple/soft_simple.cpp\n>> @@ -30,6 +30,7 @@\n>> #include \"libipa/camera_sensor_helper.h\"\n>> #include \"black_level.h\"\n>> +#include \"module.h\"\n>> namespace libcamera {\n>> LOG_DEFINE_CATEGORY(IPASoft)\n>> @@ -54,7 +55,7 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n>> */\n>> static constexpr float kExposureSatisfactory = 0.2;\n>> -class IPASoftSimple : public ipa::soft::IPASoftInterface\n>> +class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n>> {\n>> public:\n>> \tIPASoftSimple()\n>> @@ -76,6 +77,9 @@ public:\n>> \tvoid processStats(const ControlList &sensorControls) override;\n>> +protected:\n>> +\tstd::string logPrefix() const override;\n>> +\n>> private:\n>> \tvoid updateExposure(double exposureMSV);\n>> @@ -421,6 +425,11 @@ void IPASoftSimple::updateExposure(double exposureMSV)\n>> \tagain_ = std::clamp(again_, againMin_, againMax_);\n>> }\n>> +std::string IPASoftSimple::logPrefix() const\n>> +{\n>> +\treturn \"soft\";\n>\n> my preference here would \"IPASoft\" but let's see what others think...\n\nNo other opinions and I think \"IPASoft\" is indeed clearer, although the\nother pipelines use non-\"IPA\" prefixes, so I'll use it.\n\n> Reviewed-by: Umang Jain \n>> +}\n>> +\n>> } /* namespace ipa::soft */\n>> /*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 231B1BEFBE\n\tfor ;\n\tWed, 3 Jul 2024 16:52:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D0BB62E22;\n\tWed, 3 Jul 2024 18:52:04 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E86162C95\n\tfor ;\n\tWed, 3 Jul 2024 18:52:02 +0200 (CEST)","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n\t[209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-588-JeajQo6GOqyzuWTeAX0b5Q-1; Wed, 03 Jul 2024 12:52:00 -0400","by mail-ej1-f69.google.com with SMTP id\n\ta640c23a62f3a-a77b2edfe06so3182966b.0\n\tfor ;\n\tWed, 03 Jul 2024 09:51:59 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a72ab08cecfsm530610866b.147.2024.07.03.09.51.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 Jul 2024 09:51:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OwUN57dw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1720025521;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=aGphrkXC03EvoVFyXE5osHZhqwltC8na6xt4o4JoUSM=;\n\tb=OwUN57dwR/EoMs4RWSZfD6C6f81k2GAJSqYB6ONQvVl5h1wQuQ1wtyHUBkoBNhSl8dIB27\n\topTwEGLiUnEdTIn4n33uXutHM7RLJJ9VCdnX0g80KS/mZkUS/CBtyudLz25kkQL8cP4TfZ\n\tk+N+/b8KqNuPt1eEPUT/TnsyUm9zzPg=","X-MC-Unique":"JeajQo6GOqyzuWTeAX0b5Q-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1720025518; x=1720630318;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=aGphrkXC03EvoVFyXE5osHZhqwltC8na6xt4o4JoUSM=;\n\tb=HK2Ir2hM5YpTuLB85SNwX1+I+6l+92vklWA3vkwxi62xgMHRo3yXVa8GMhSAtLzejP\n\tpjvwKWwGAJOPBekYZ+ktsRvEDux2LfsZEYs2UFQ+HBiYO7q0fr5ncRb59O2W0rNsWs/X\n\toMmxYAu6a+G0nrqqlk/7Da5RkCKazatahkaPfL1mTmL9qRGa0HXFrsCO6+SNuYiNMwFb\n\t7/ZbCh/iqeKc/gRDO3McybeIS8yiCg0de8y8VGxHArgdKiOYw4ZAdw+CCYMvb8AlbNVL\n\tmJGClXCh4QHX5dX26UfP+eherHoUG3LrGxkJJXlKB3UHWHu4kl+6KBOmouc0E4UElB4m\n\tGfVw==","X-Gm-Message-State":"AOJu0YwwndrZZ8np6q86Mv0OykfiKbc1Lj9ksAGVC+Svc1GzY/EF0Ubj\n\tEVdeyz8urrP8Cpoh24WN19h1yi87/xBFDIYQmnWy7B08dSP1VSHvSgsqtAWtIUZ/xxaAhcmcYGM\n\tDbtknQjFSsNo1C7ZXZGOvQM8Ry3SX1DxVMxHKPP5BQdKnrRLMVL9cpI27zmEXXbo+KnJYQPPgav\n\tjTGEMdXW/5g9exl9Xrewv1BZrRxf9K0abmrPcD+BcNffJNokViLXdC2oI=","X-Received":["by 2002:a17:907:868c:b0:a6f:63c7:3083 with SMTP id\n\ta640c23a62f3a-a751441f03bmr1028486866b.13.1720025518075; \n\tWed, 03 Jul 2024 09:51:58 -0700 (PDT)","by 2002:a17:907:868c:b0:a6f:63c7:3083 with SMTP id\n\ta640c23a62f3a-a751441f03bmr1028481766b.13.1720025516604; \n\tWed, 03 Jul 2024 09:51:56 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGSrzpJxcW8xbDMxH9bN/PN5I2QoJhr1p841b04dzOETsSVnTO27n5Nm0k6nNBj8wvI7qA3RA==","From":"Milan Zamazal ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 05/19] libcamera: software_isp: Let IPASoftSimple\n\tinherit Module","In-Reply-To":"<55283565-4014-47e9-be91-dcbb1101c5d3@ideasonboard.com> (Umang\n\tJain's message of \"Fri, 28 Jun 2024 09:11:06 +0530\")","References":"<20240626072100.55497-1-mzamazal@redhat.com>\n\t<20240626072100.55497-6-mzamazal@redhat.com>\n\t<55283565-4014-47e9-be91-dcbb1101c5d3@ideasonboard.com>","Date":"Wed, 03 Jul 2024 18:51:54 +0200","Message-ID":"<87o77eju51.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]