[{"id":30111,"web_url":"https://patchwork.libcamera.org/comment/30111/","msgid":"","date":"2024-06-28T03:49:46","subject":"Re: [PATCH 07/19] libcamera: software_isp: Remove dots in\n\tDebayer::process docstring","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"HI Milan\n\nOn 26/06/24 12:50 pm, Milan Zamazal wrote:\n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/software_isp/debayer.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index f4a299d5..65fc4efc 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -94,11 +94,12 @@ Debayer::~Debayer()\n> */\n> \n> /**\n> - * \\fn void Debayer::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n> - * \\brief Process the bayer data into the requested format.\n> - * \\param[in] input The input buffer.\n> - * \\param[in] output The output buffer.\n> - * \\param[in] params The parameters to be used in debayering.\n> + * \\fn void Debayer::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n\nI believe the change in arguments (i.e. frame) belongs to your next \npatch 08/19.\n> + * \\brief Process the bayer data into the requested format\n> + * \\param[in] frame The frame number\n> + * \\param[in] input The input buffer\n> + * \\param[in] output The output buffer\n> + * \\param[in] params The parameters to be used in debayering\n> *\n> * \\note DebayerParams is passed by value deliberately so that a copy is passed\n> * when this is run in another thread by invokeMethod().","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B37E8BD87C\n\tfor ;\n\tFri, 28 Jun 2024 03:49:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3F5C62C99;\n\tFri, 28 Jun 2024 05:49:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35864619C8\n\tfor ;\n\tFri, 28 Jun 2024 05:49:51 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 447EABEB;\n\tFri, 28 Jun 2024 05:49:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Rl4q3IYH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719546566;\n\tbh=b6OgQvHUtGAItVsUyjM0AWz6TDy/OHHZyvvpDp5oFrM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Rl4q3IYHA3BOXIE0VcGFmmVIh+ZvLamfvGp5FI/qutjFdSYpt36A9yR11wvgbRzIF\n\taRZATJ8r6f6KP2TzDBM0lLpT9vp1kqlg9QEEXN6etN+GaY+xWT+K3cWL8zX0Kg/zXM\n\taV5R0f+d7TqUzVIpmfOmSulVlvjp+1JaKSiZca5g=","Message-ID":"","Date":"Fri, 28 Jun 2024 09:19:46 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 07/19] libcamera: software_isp: Remove dots in\n\tDebayer::process docstring","Content-Language":"en-US","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240626072100.55497-1-mzamazal@redhat.com>\n\t<20240626072100.55497-8-mzamazal@redhat.com>","From":"Umang Jain ","In-Reply-To":"<20240626072100.55497-8-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]