[{"id":30107,"web_url":"https://patchwork.libcamera.org/comment/30107/","msgid":"<3fbd9e33-db22-4747-9cc1-f62c7fcb3bf0@ideasonboard.com>","date":"2024-06-28T03:32:00","subject":"Re: [PATCH 02/19] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn 26/06/24 12:50 pm, Milan Zamazal wrote:\n> To be in the same namespace as the other software ISP IPA stuff.\n>\n> Signed-off-by: Milan Zamazal \n\nLGTM,\n\nReviewed-by: Umang Jain \n> ---\n> src/ipa/simple/black_level.cpp | 5 +++++\n> src/ipa/simple/black_level.h | 4 ++++\n> 2 files changed, 9 insertions(+)\n>\n> diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\n> index cc490eb5..37e0109c 100644\n> --- a/src/ipa/simple/black_level.cpp\n> +++ b/src/ipa/simple/black_level.cpp\n> @@ -15,6 +15,8 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftBL)\n> \n> +namespace ipa::soft {\n> +\n> /**\n> * \\class BlackLevel\n> * \\brief Object providing black point level for software ISP\n> @@ -85,4 +87,7 @@ void BlackLevel::update(SwIspStats::Histogram &yHistogram)\n> \t\t}\n> \t};\n> }\n> +\n> +} /* namespace ipa::soft */\n> +\n> } /* namespace libcamera */\n> diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\n> index 5e032f9f..a04230c9 100644\n> --- a/src/ipa/simple/black_level.h\n> +++ b/src/ipa/simple/black_level.h\n> @@ -14,6 +14,8 @@\n> \n> namespace libcamera {\n> \n> +namespace ipa::soft {\n> +\n> class BlackLevel\n> {\n> public:\n> @@ -26,4 +28,6 @@ private:\n> \tbool blackLevelSet_;\n> };\n> \n> +} /* namespace ipa::soft */\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C991EBDB1D\n\tfor ;\n\tFri, 28 Jun 2024 03:32:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FCC462C99;\n\tFri, 28 Jun 2024 05:32:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08C62619C8\n\tfor ;\n\tFri, 28 Jun 2024 05:32:02 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C01ABEB;\n\tFri, 28 Jun 2024 05:31:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gO4JJ+Qc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719545497;\n\tbh=tpQsYylsaOEwePX0t8IKBulHFCPRT7JX2q5tv87ng10=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=gO4JJ+QcFs7j5tJ80HswA5GYW5nk0RawzMgD/a4GBxv7z0c9xduB9qqtKupZGrrjN\n\tXPPmd/DhvdbLW9J7nZV41LkOHSSGRXxdP8yM6cLfsukSXImaWNvtLrWVRQxOalivA6\n\tCYYkrfasPAbsrjA3iob3qGSKDzoXXRlKTJzKfFZQ=","Message-ID":"<3fbd9e33-db22-4747-9cc1-f62c7fcb3bf0@ideasonboard.com>","Date":"Fri, 28 Jun 2024 09:02:00 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 02/19] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","Content-Language":"en-US","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240626072100.55497-1-mzamazal@redhat.com>\n\t<20240626072100.55497-3-mzamazal@redhat.com>","From":"Umang Jain ","In-Reply-To":"<20240626072100.55497-3-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]