[{"id":30106,"web_url":"https://patchwork.libcamera.org/comment/30106/","msgid":"","date":"2024-06-28T03:30:58","subject":"Re: [PATCH 01/19] libcamera: software_isp: Remove superfluous\n\tincludes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn 26/06/24 12:50 pm, Milan Zamazal wrote:\n> Signed-off-by: Milan Zamazal \n\nnit: One line in commit message body is usually nice-to-have. For instance,\n\n\"Remove unused libcamera internal headers bayer_format.h, framebuffer.h \nand mapped_frameBuffer.h.\"\n\nOtherwise,\n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/software_isp/software_isp.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 20fb6f48..08a1afcc 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -16,10 +16,7 @@\n> #include \n> #include \n> \n> -#include \"libcamera/internal/bayer_format.h\"\n> -#include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> -#include \"libcamera/internal/mapped_framebuffer.h\"\n> #include \"libcamera/internal/software_isp/debayer_params.h\"\n> \n> #include \"debayer_cpu.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68E6ABDB1D\n\tfor ;\n\tFri, 28 Jun 2024 03:31:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02B9462C99;\n\tFri, 28 Jun 2024 05:31:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5EB4619C8\n\tfor ;\n\tFri, 28 Jun 2024 05:31:03 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D232EBEB;\n\tFri, 28 Jun 2024 05:30:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MWLFS8ug\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719545439;\n\tbh=YXzg7HvLQ2P2zZlObsQASbu4cC26uNGAFw2wr+hCLlw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=MWLFS8ugbVaZlHbb/hQUo2+JKu6zC5oLPA0azsNCRjg9kVJreWpGKEsKBWKp8FZjT\n\tZyBGXrX+lQDfjteegalt2ToRzew3vSSqOyLqZ8GN8vG1YQn81XgOckKVoMrMtyafVo\n\tXqPIjGZLzojl8AuAycJgdZvWCwf/Pj2jT4AKVBS0=","Message-ID":"","Date":"Fri, 28 Jun 2024 09:00:58 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 01/19] libcamera: software_isp: Remove superfluous\n\tincludes","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240626072100.55497-1-mzamazal@redhat.com>\n\t<20240626072100.55497-2-mzamazal@redhat.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240626072100.55497-2-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]