[{"id":30076,"web_url":"https://patchwork.libcamera.org/comment/30076/","msgid":"<171934720595.739659.8115242911770926002@ping.linuxembedded.co.uk>","date":"2024-06-25T20:26:45","subject":"Re: [PATCH v2 6/6] libcamera: mali-c55: Add stride and size to\n\trawConfig","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2024-06-25 20:04:19)\n> From: Daniel Scally \n> \n> Complete the RAW StreamConfiguration by populating the frame stride and\n> the frame size.\n> \n> Set the minimum required alignment to 4 bytes as the Mali C55 ISP output\n> RAW formats expanded to 16 bits and a RAW Bayer macro-pixel requires\n\ns/expanded/expands/ ?\n\n> two sample to be complete.\n\ns/sample/samples/\n\n> \n> Signed-off-by: Daniel Scally \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index f1c057c1aeb4..f52fc1e95a20 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -367,6 +367,10 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \n> maxSize = rawSize;\n> \n> + const PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n> + rawConfig->stride = info.stride(rawConfig->size.width, 0, 4);\n> + rawConfig->frameSize = info.frameSize(rawConfig->size, 4);\n> +\n\nLooks good. We should really have a validation in lc-compliance that\nchecks both stride and frameSize are set I think.\n\nReviewed-by: Kieran Bingham \n\n> rawConfig->setStream(const_cast(&data_->frStream_));\n> frPipeAvailable = false;\n> }\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9341BD87C\n\tfor ;\n\tTue, 25 Jun 2024 20:26:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4332D654A8;\n\tTue, 25 Jun 2024 22:26:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 156A8654A2\n\tfor ;\n\tTue, 25 Jun 2024 22:26:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FC847E0;\n\tTue, 25 Jun 2024 22:26:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GwPljTiC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719347186;\n\tbh=j+jGM849AopVjwAI6Y1Ju69hulFZa/u7XKpetsPwEoc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GwPljTiCI3Hhju+9gAbmJsfD3uWYxFgIx5LSv+HeVFVREel4W9wSXQ/7YcNYxv5GT\n\tmi7JFrk0V2Pf87B4tDWCj4GmJwybWw5/IXiu02radcdvqL+ndbNbrse11vk4jP3Upv\n\t7f0B3mpOF9Q7U6AxRlzoaXfFRL4LeihVMGiuD77c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240625190423.291429-7-jacopo.mondi@ideasonboard.com>","References":"<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>\n\t<20240625190423.291429-7-jacopo.mondi@ideasonboard.com>","Subject":"Re: [PATCH v2 6/6] libcamera: mali-c55: Add stride and size to\n\trawConfig","From":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tDaniel Scally ","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Jun 2024 21:26:45 +0100","Message-ID":"<171934720595.739659.8115242911770926002@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]