{"id":20389,"url":"https://patchwork.libcamera.org/api/patches/20389/?format=json","web_url":"https://patchwork.libcamera.org/patch/20389/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240625190423.291429-4-jacopo.mondi@ideasonboard.com>","date":"2024-06-25T19:04:16","name":"[v2,3/6] libcamera: mali-c55: Init camera properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1aca73ed991770979887e9913c105c729c720980","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20389/mbox/","series":[{"id":4418,"url":"https://patchwork.libcamera.org/api/series/4418/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4418","date":"2024-06-25T19:04:13","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/4418/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20389/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20389/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E366BDB1D\n\tfor ;\n\tTue, 25 Jun 2024 19:04:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8DC7654B3;\n\tTue, 25 Jun 2024 21:04:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E82FA654A1\n\tfor ;\n\tTue, 25 Jun 2024 21:04:36 +0200 (CEST)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27EC4BEB;\n\tTue, 25 Jun 2024 21:04:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KoY1LjT1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719342254;\n\tbh=bbpdqUEEbKi60HpXp9wyIAJWG8vuXO0xWMQMMOwRFos=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KoY1LjT1GXCtVTbAhCKHu4lWzWxwaUWX91jjNuI92oyx+mxbz2oxTm3Twk1du3EE0\n\tgX2/9tYKQ2jKogEmsk/5PSflhEtRR9BD+XeUNziNaaGMaMYj0jqcElQkV3bVFJqEqQ\n\t7JWkd3g0lQGjfn/+KNT0195tZklLmg4AHJJEz+W4=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tDaniel Scally ,\n\tKieran Bingham ","Subject":"[PATCH v2 3/6] libcamera: mali-c55: Init camera properties","Date":"Tue, 25 Jun 2024 21:04:16 +0200","Message-ID":"<20240625190423.291429-4-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>","References":"<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Daniel Scally \n\nInitialise the camera properties using the CameraSensor properties.\n\nSigned-off-by: Daniel Scally \nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 91f2ebd6fd26..796e2ca60e94 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -966,7 +966,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tif (data->init())\n \t\t\treturn false;\n \n-\t\t/* \\todo: Init properties and controls. */\n+\t\tdata->properties_ = data->sensor_->properties();\n \n \t\tregisterMaliCamera(std::move(data), sensor->name());\n \t}\n","prefixes":["v2","3/6"]}