[{"id":30064,"web_url":"https://patchwork.libcamera.org/comment/30064/","msgid":"<171926552193.625657.14613355508852291486@ping.linuxembedded.co.uk>","date":"2024-06-24T21:45:21","subject":"Re: [PATCH 10/10] meson: Enable warnings to flag missing\n\tdeclarations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-24 20:29:41)\n> A recently introduced typo resulted in a function definition not\n> matching its declaration. As the problem occurred in libipa, and IPA\n> modules are loaded dynamically and are linked with lazy symbol\n> resolution, the problem wasn't caught at build time.\n> \n> To try and catch future similar issues, enable the\n> -Wmissing-declarations warning.\n> \n> Suggested-by: Barnabás Pőcze \n> Signed-off-by: Laurent Pinchart \n> ---\n> meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 0ef4cdaafd76..2acd8c3e8cfe 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -95,6 +95,7 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n> endif\n> \n> common_arguments = [\n> + '-Wmissing-declarations',\n\nI love any opportunity that lets the tools protect us from ourselves...\n\nReviewed-by: Kieran Bingham \n\n> '-Wshadow',\n> '-include', meson.current_build_dir() / 'config.h',\n> ]\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE3E1BDB1D\n\tfor ;\n\tMon, 24 Jun 2024 21:45:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A70A6654A9;\n\tMon, 24 Jun 2024 23:45:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04AE7654A9\n\tfor ;\n\tMon, 24 Jun 2024 23:45:25 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04B1818ED;\n\tMon, 24 Jun 2024 23:45:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uCUbqckX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719265503;\n\tbh=II6T7AmozE6nnlivDGaatCMQ6amtcWyeChabI2KyiQk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uCUbqckXAhLahySXNWGqKqWNi5N5wY37iwgJVvmS2eYKgQ6nKsNGNCypgcF2Z4Ctl\n\t3SnetA27LsrSD1vwx3NOBdxhEQ73qwnCRHf4J2XQCYOyE6+iz7gkLUF5I74tsxNipD\n\tY+qBdnBsG1+J1BllhyJPbx/4udA5KSJuBJxkADWk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240624192941.22943-11-laurent.pinchart@ideasonboard.com>","References":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>\n\t<20240624192941.22943-11-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 10/10] meson: Enable warnings to flag missing\n\tdeclarations","From":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 24 Jun 2024 22:45:21 +0100","Message-ID":"<171926552193.625657.14613355508852291486@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]